From 953035009601a971137ecc2c7d5e662189cfda50 Mon Sep 17 00:00:00 2001 From: Brandon Williams Date: Wed, 16 May 2018 15:58:02 -0700 Subject: [PATCH] remote: remove add_prune_tags_to_fetch_refspec Remove 'add_prune_tags_to_fetch_refspec()' function and instead have the only caller directly add the tag refspec using 'refspec_append()'. Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano --- builtin/fetch.c | 2 +- remote.c | 5 ----- remote.h | 2 -- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/builtin/fetch.c b/builtin/fetch.c index 30083d4bc2..7a1637d35e 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -1392,7 +1392,7 @@ static int fetch_one(struct remote *remote, int argc, const char **argv, int pru maybe_prune_tags = prune_tags_ok && prune_tags; if (maybe_prune_tags && remote_via_config) - add_prune_tags_to_fetch_refspec(remote); + refspec_append(&remote->fetch, TAG_REFSPEC); if (argc > 0 || (maybe_prune_tags && !remote_via_config)) { size_t nr_alloc = st_add3(argc, maybe_prune_tags, 1); diff --git a/remote.c b/remote.c index 26842ce37f..4a9bddf0d7 100644 --- a/remote.c +++ b/remote.c @@ -77,11 +77,6 @@ static const char *alias_url(const char *url, struct rewrites *r) return xstrfmt("%s%s", r->rewrite[longest_i]->base, url + longest->len); } -void add_prune_tags_to_fetch_refspec(struct remote *remote) -{ - refspec_append(&remote->fetch, TAG_REFSPEC); -} - static void add_url(struct remote *remote, const char *url) { ALLOC_GROW(remote->url, remote->url_nr + 1, remote->url_alloc); diff --git a/remote.h b/remote.h index e7d00fe2a3..4ffbc0082d 100644 --- a/remote.h +++ b/remote.h @@ -290,6 +290,4 @@ extern int parseopt_push_cas_option(const struct option *, const char *arg, int extern int is_empty_cas(const struct push_cas_option *); void apply_push_cas(struct push_cas_option *, struct remote *, struct ref *); -void add_prune_tags_to_fetch_refspec(struct remote *remote); - #endif