зеркало из https://github.com/microsoft/git.git
t/perf: do not run tests in user's $SHELL
The environment variable $SHELL is usually set to the user's interactive shell. Our build and test scripts never use $SHELL because there are no guarantees about its input language. Instead, we use /bin/sh which should be a POSIX shell. For systems with a broken /bin/sh, we allow to override that path via SHELL_PATH. To run tests in yet another shell we allow to override SHELL_PATH with TEST_SHELL_PATH. Perf tests run in $SHELL via a wrapper defined in t/perf/perf-lib.sh, so they break with e.g. SHELL=python. Use TEST_SHELL_PATH like in other tests. TEST_SHELL_PATH is always defined because t/perf/perf-lib.sh includes t/test-lib.sh, which includes GIT-BUILD-OPTIONS. Acked-by: Jeff King <peff@peff.net> Signed-off-by: Johannes Altmanninger <aclopte@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
e9d7761bb9
Коммит
9ccab75608
|
@ -161,7 +161,7 @@ test_run_perf_ () {
|
|||
test_cleanup=:
|
||||
test_export_="test_cleanup"
|
||||
export test_cleanup test_export_
|
||||
"$GTIME" -f "%E %U %S" -o test_time.$i "$SHELL" -c '
|
||||
"$GTIME" -f "%E %U %S" -o test_time.$i "$TEST_SHELL_PATH" -c '
|
||||
. '"$TEST_DIRECTORY"/test-lib-functions.sh'
|
||||
test_export () {
|
||||
test_export_="$test_export_ $*"
|
||||
|
|
Загрузка…
Ссылка в новой задаче