зеркало из https://github.com/microsoft/git.git
pretty.c: make git_pretty_formats_config return -1 on git_config_string failure
`git_pretty_formats_config()` continues without checking git_config_string's return value which can lead to a SEGFAULT. Instead return -1 when git_config_string fails signalling `git_config()` to die printing the location of the erroneous variable. Signed-off-by: Tanay Abhra <tanayabh@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
d31f3ad23d
Коммит
a26bc613a6
4
pretty.c
4
pretty.c
|
@ -66,7 +66,9 @@ static int git_pretty_formats_config(const char *var, const char *value, void *c
|
|||
|
||||
commit_format->name = xstrdup(name);
|
||||
commit_format->format = CMIT_FMT_USERFORMAT;
|
||||
git_config_string(&fmt, var, value);
|
||||
if (git_config_string(&fmt, var, value))
|
||||
return -1;
|
||||
|
||||
if (starts_with(fmt, "format:") || starts_with(fmt, "tformat:")) {
|
||||
commit_format->is_tformat = fmt[0] == 't';
|
||||
fmt = strchr(fmt, ':') + 1;
|
||||
|
|
Загрузка…
Ссылка в новой задаче