зеркало из https://github.com/microsoft/git.git
trailer: use CHILD_PROCESS_INIT in apply_command()
Initialize the struct child_process variable cp at declaration time. This is shorter, saves a function call and prevents using the variable before initialization by mistake. Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
66edfe9ddc
Коммит
b226293b44
|
@ -228,7 +228,7 @@ static const char *apply_command(const char *command, const char *arg)
|
||||||
{
|
{
|
||||||
struct strbuf cmd = STRBUF_INIT;
|
struct strbuf cmd = STRBUF_INIT;
|
||||||
struct strbuf buf = STRBUF_INIT;
|
struct strbuf buf = STRBUF_INIT;
|
||||||
struct child_process cp;
|
struct child_process cp = CHILD_PROCESS_INIT;
|
||||||
const char *argv[] = {NULL, NULL};
|
const char *argv[] = {NULL, NULL};
|
||||||
const char *result;
|
const char *result;
|
||||||
|
|
||||||
|
@ -237,7 +237,6 @@ static const char *apply_command(const char *command, const char *arg)
|
||||||
strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);
|
strbuf_replace(&cmd, TRAILER_ARG_STRING, arg);
|
||||||
|
|
||||||
argv[0] = cmd.buf;
|
argv[0] = cmd.buf;
|
||||||
child_process_init(&cp);
|
|
||||||
cp.argv = argv;
|
cp.argv = argv;
|
||||||
cp.env = local_repo_env;
|
cp.env = local_repo_env;
|
||||||
cp.no_stdin = 1;
|
cp.no_stdin = 1;
|
||||||
|
|
Загрузка…
Ссылка в новой задаче