зеркало из https://github.com/microsoft/git.git
userdiff: comment on the builtin patterns
Remind developers that they do not need to go overboard to implement patterns to prepare for invalid constructs. They only have to be sufficiently permissive, assuming that the payload is syntactically correct, and that may allow them to be simpler. Text stolen mostly from, and further improved by, Johannes Sixt. Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
ebf3c04b26
Коммит
b6029b3279
10
userdiff.c
10
userdiff.c
|
@ -13,6 +13,16 @@ static int drivers_alloc;
|
|||
#define IPATTERN(name, pattern, word_regex) \
|
||||
{ name, NULL, -1, { pattern, REG_EXTENDED | REG_ICASE }, \
|
||||
word_regex "|[^[:space:]]|[\xc0-\xff][\x80-\xbf]+" }
|
||||
|
||||
/*
|
||||
* Built-in drivers for various languages, sorted by their names
|
||||
* (except that the "default" is left at the end).
|
||||
*
|
||||
* When writing or updating patterns, assume that the contents these
|
||||
* patterns are applied to are syntactically correct. The patterns
|
||||
* can be simple without implementing all syntactical corner cases, as
|
||||
* long as they are sufficiently permissive.
|
||||
*/
|
||||
static struct userdiff_driver builtin_drivers[] = {
|
||||
IPATTERN("ada",
|
||||
"!^(.*[ \t])?(is[ \t]+new|renames|is[ \t]+separate)([ \t].*)?$\n"
|
||||
|
|
Загрузка…
Ссылка в новой задаче