From 94ee8e2c98cf4adf0c69b3b8ce5039eea92347b7 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 28 Jan 2015 12:58:50 -0500 Subject: [PATCH] do not check truth value of flex arrays There is no point in checking "!ref->name" when ref is a "struct ref". The name field is a flex-array, and there always has a non-zero address. This is almost certainly not hurting anything, but it does cause clang-3.6 to complain. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- remote-curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/remote-curl.c b/remote-curl.c index 0eb6fc48fb..38cab05ec5 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -514,7 +514,7 @@ static int fetch_git(struct discovery *heads, argv[argc++] = url; for (i = 0; i < nr_heads; i++) { struct ref *ref = to_fetch[i]; - if (!ref->name || !*ref->name) + if (!*ref->name) die("cannot fetch by sha1 over smart http"); argv[argc++] = ref->name; }