safe_create_leading_directories(): split on first of multiple slashes

If the input path has multiple slashes between path components (e.g.,
"foo//bar"), then the old code was breaking the path at the last
slash, not the first one.  So in the above example, the second slash
was overwritten with NUL, resulting in the parent directory being
sought as "foo/".

When stat() is called on "foo/", it fails with ENOTDIR if "foo" exists
but is not a directory.  This caused the wrong path to be taken in the
subsequent logic.

So instead, split path components at the first intercomponent slash
rather than the last one.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2014-01-06 14:45:23 +01:00 коммит произвёл Junio C Hamano
Родитель 26c8ae2a57
Коммит bf10cf70ad
1 изменённых файлов: 3 добавлений и 2 удалений

Просмотреть файл

@ -115,9 +115,10 @@ int safe_create_leading_directories(char *path)
if (!slash)
break;
while (*(slash + 1) == '/')
slash++;
next_component = slash + 1;
while (*next_component == '/')
next_component++;
if (!*next_component)
break;