Merge branch 'py/revert-commit-comments'

This commit causes breakage on macOS, or in fact any platform using
older versions of Tcl. Revert it.

* py/revert-commit-comments:
  Revert "git-gui: remove lines starting with the comment character"
This commit is contained in:
Pratyush Yadav 2021-03-04 13:59:45 +05:30
Родитель b1056f60b6 c0698df057
Коммит df4f9e28f6
2 изменённых файлов: 2 добавлений и 21 удалений

Просмотреть файл

@ -875,7 +875,6 @@ set default_config(merge.summary) false
set default_config(merge.verbosity) 2 set default_config(merge.verbosity) 2
set default_config(user.name) {} set default_config(user.name) {}
set default_config(user.email) {} set default_config(user.email) {}
set default_config(core.commentchar) "#"
set default_config(gui.encoding) [encoding system] set default_config(gui.encoding) [encoding system]
set default_config(gui.matchtrackingbranch) false set default_config(gui.matchtrackingbranch) false
@ -3437,10 +3436,6 @@ proc trace_commit_type {varname args} {
merge {set txt [mc "Merge Commit Message:"]} merge {set txt [mc "Merge Commit Message:"]}
* {set txt [mc "Commit Message:"]} * {set txt [mc "Commit Message:"]}
} }
set comment_char [get_config core.commentchar]
set txt [string cat $txt \
[mc " (Lines starting with '$comment_char' will be ignored)"]]
$ui_coml conf -text $txt $ui_coml conf -text $txt
} }
trace add variable commit_type write trace_commit_type trace add variable commit_type write trace_commit_type

Просмотреть файл

@ -141,20 +141,6 @@ proc setup_commit_encoding {msg_wt {quiet 0}} {
} }
} }
proc strip_msg {msg} {
set cmd [concat [list | ] [_git_cmd stripspace] --strip-comments]
_trace_exec $cmd
set fd [open $cmd r+]
fconfigure $fd -translation binary -encoding utf-8
puts -nonewline $fd $msg
close $fd w
set result [read $fd]
close $fd
return $result
}
proc commit_tree {} { proc commit_tree {} {
global HEAD commit_type file_states ui_comm repo_config global HEAD commit_type file_states ui_comm repo_config
global pch_error global pch_error
@ -221,8 +207,8 @@ You must stage at least 1 file before you can commit.
# -- A message is required. # -- A message is required.
# #
set msg [strip_msg [$ui_comm get 1.0 end]] set msg [string trim [$ui_comm get 1.0 end]]
regsub -all -line {[ \t\r]+$} $msg {} msg
if {$msg eq {}} { if {$msg eq {}} {
error_popup [mc "Please supply a commit message. error_popup [mc "Please supply a commit message.