зеркало из https://github.com/microsoft/git.git
tests: paint known breakages in yellow
Yellow seems a more appropriate color than bold green when considering the universal traffic lights coloring scheme, where green conveys the impression that everything's OK, and amber that something's not quite right. Likewise, change the color of the summarized total number of known breakages from bold red to the same yellow to be less alarmist and more consistent with the above. An earlier version of this patch used bold yellow but because these are all long-known failures, reminding them to developers in bold over and over does not help encouraging them to take a look at them very much. This iteration paints them in plain yellow instead to make them less distracting. Signed-off-by: Adam Spiers <git@adamspiers.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
5e5c006eb7
Коммит
e8e5195573
|
@ -183,6 +183,8 @@ then
|
||||||
tput bold; tput setaf 1;; # bold red
|
tput bold; tput setaf 1;; # bold red
|
||||||
skip)
|
skip)
|
||||||
tput bold; tput setaf 2;; # bold green
|
tput bold; tput setaf 2;; # bold green
|
||||||
|
warn)
|
||||||
|
tput setaf 3;; # brown/yellow
|
||||||
pass)
|
pass)
|
||||||
tput setaf 2;; # green
|
tput setaf 2;; # green
|
||||||
info)
|
info)
|
||||||
|
@ -281,7 +283,7 @@ test_known_broken_ok_ () {
|
||||||
|
|
||||||
test_known_broken_failure_ () {
|
test_known_broken_failure_ () {
|
||||||
test_broken=$(($test_broken+1))
|
test_broken=$(($test_broken+1))
|
||||||
say_color skip "not ok $test_count - $@ # TODO known breakage"
|
say_color warn "not ok $test_count - $@ # TODO known breakage"
|
||||||
}
|
}
|
||||||
|
|
||||||
test_debug () {
|
test_debug () {
|
||||||
|
@ -375,7 +377,7 @@ test_done () {
|
||||||
fi
|
fi
|
||||||
if test "$test_broken" != 0
|
if test "$test_broken" != 0
|
||||||
then
|
then
|
||||||
say_color error "# still have $test_broken known breakage(s)"
|
say_color warn "# still have $test_broken known breakage(s)"
|
||||||
msg="remaining $(($test_count-$test_broken)) test(s)"
|
msg="remaining $(($test_count-$test_broken)) test(s)"
|
||||||
else
|
else
|
||||||
msg="$test_count test(s)"
|
msg="$test_count test(s)"
|
||||||
|
|
Загрузка…
Ссылка в новой задаче