зеркало из https://github.com/microsoft/git.git
fsck: use bitwise-or assignment operator to set flag
fsck_tree() has two different ways to set a flag variable, either by using a if-statement that guards an assignment, or by using a bitwise-or assignment operator. Most are done with the former, and only one variable is assigned with the latter. Since all the conditions are short-and-sweet, we can afford to uniformly use the latter style, which makes the resulting code shorter and easier to read. Signed-off-by: Hiroyuki Sano <sh19910711@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Родитель
7bbc4e8fdb
Коммит
effd12ec87
18
fsck.c
18
fsck.c
|
@ -165,18 +165,12 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
|
|||
|
||||
sha1 = tree_entry_extract(&desc, &name, &mode);
|
||||
|
||||
if (is_null_sha1(sha1))
|
||||
has_null_sha1 = 1;
|
||||
if (strchr(name, '/'))
|
||||
has_full_path = 1;
|
||||
if (!*name)
|
||||
has_empty_name = 1;
|
||||
if (!strcmp(name, "."))
|
||||
has_dot = 1;
|
||||
if (!strcmp(name, ".."))
|
||||
has_dotdot = 1;
|
||||
if (!strcmp(name, ".git"))
|
||||
has_dotgit = 1;
|
||||
has_null_sha1 |= is_null_sha1(sha1);
|
||||
has_full_path |= !!strchr(name, '/');
|
||||
has_empty_name |= !*name;
|
||||
has_dot |= !strcmp(name, ".");
|
||||
has_dotdot |= !strcmp(name, "..");
|
||||
has_dotgit |= !strcmp(name, ".git");
|
||||
has_zero_pad |= *(char *)desc.buffer == '0';
|
||||
update_tree_entry(&desc);
|
||||
|
||||
|
|
Загрузка…
Ссылка в новой задаче