зеркало из https://github.com/microsoft/git.git
refs.c: constify the sha arguments for ref_transaction_create|delete|update
ref_transaction_create|delete|update has no need to modify the sha1 arguments passed to it so it should use const unsigned char* instead of unsigned char*. Some functions, such as fast_forward_to(), already have its old/new sha1 arguments as consts. This function will at some point need to use ref_transaction_update() in which case this change is required. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> Acked-by: Michael Haggerty <mhagger@alum.mit.edu>
This commit is contained in:
Родитель
33f9fc5932
Коммит
f1c9350ad7
7
refs.c
7
refs.c
|
@ -3359,7 +3359,8 @@ static struct ref_update *add_update(struct ref_transaction *transaction,
|
|||
|
||||
void ref_transaction_update(struct ref_transaction *transaction,
|
||||
const char *refname,
|
||||
unsigned char *new_sha1, unsigned char *old_sha1,
|
||||
const unsigned char *new_sha1,
|
||||
const unsigned char *old_sha1,
|
||||
int flags, int have_old)
|
||||
{
|
||||
struct ref_update *update = add_update(transaction, refname);
|
||||
|
@ -3373,7 +3374,7 @@ void ref_transaction_update(struct ref_transaction *transaction,
|
|||
|
||||
void ref_transaction_create(struct ref_transaction *transaction,
|
||||
const char *refname,
|
||||
unsigned char *new_sha1,
|
||||
const unsigned char *new_sha1,
|
||||
int flags)
|
||||
{
|
||||
struct ref_update *update = add_update(transaction, refname);
|
||||
|
@ -3387,7 +3388,7 @@ void ref_transaction_create(struct ref_transaction *transaction,
|
|||
|
||||
void ref_transaction_delete(struct ref_transaction *transaction,
|
||||
const char *refname,
|
||||
unsigned char *old_sha1,
|
||||
const unsigned char *old_sha1,
|
||||
int flags, int have_old)
|
||||
{
|
||||
struct ref_update *update = add_update(transaction, refname);
|
||||
|
|
7
refs.h
7
refs.h
|
@ -240,7 +240,8 @@ struct ref_transaction *ref_transaction_begin(void);
|
|||
*/
|
||||
void ref_transaction_update(struct ref_transaction *transaction,
|
||||
const char *refname,
|
||||
unsigned char *new_sha1, unsigned char *old_sha1,
|
||||
const unsigned char *new_sha1,
|
||||
const unsigned char *old_sha1,
|
||||
int flags, int have_old);
|
||||
|
||||
/*
|
||||
|
@ -251,7 +252,7 @@ void ref_transaction_update(struct ref_transaction *transaction,
|
|||
*/
|
||||
void ref_transaction_create(struct ref_transaction *transaction,
|
||||
const char *refname,
|
||||
unsigned char *new_sha1,
|
||||
const unsigned char *new_sha1,
|
||||
int flags);
|
||||
|
||||
/*
|
||||
|
@ -261,7 +262,7 @@ void ref_transaction_create(struct ref_transaction *transaction,
|
|||
*/
|
||||
void ref_transaction_delete(struct ref_transaction *transaction,
|
||||
const char *refname,
|
||||
unsigned char *old_sha1,
|
||||
const unsigned char *old_sha1,
|
||||
int flags, int have_old);
|
||||
|
||||
/*
|
||||
|
|
Загрузка…
Ссылка в новой задаче