2019-07-10 19:43:32 +03:00
|
|
|
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
|
|
|
#
|
2019-10-15 22:33:16 +03:00
|
|
|
# This source code is licensed under the MIT license found in the
|
|
|
|
|
# LICENSE file in the root directory of this source tree.
|
2019-07-10 19:43:32 +03:00
|
|
|
|
|
|
|
|
if(NOT HERMES_IS_ANDROID)
|
|
|
|
|
# We need FindICU from 3.7
|
|
|
|
|
cmake_minimum_required(VERSION 3.7.0)
|
|
|
|
|
else()
|
|
|
|
|
# We'll be using ICU through Java, so we don't need FindICU.
|
|
|
|
|
# 3.6.0 is the minimum version shipped with the Android SDK.
|
|
|
|
|
cmake_minimum_required(VERSION 3.6.0)
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-08-01 04:14:53 +03:00
|
|
|
# Set the VERSION variables based on the project command
|
2019-08-01 20:31:25 +03:00
|
|
|
if (POLICY CMP0048)
|
|
|
|
|
cmake_policy(SET CMP0048 NEW)
|
|
|
|
|
endif()
|
|
|
|
|
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
# find_package uses <PackageName>_ROOT variables.
|
|
|
|
|
if (POLICY CMP0074)
|
|
|
|
|
cmake_policy(SET CMP0074 NEW)
|
|
|
|
|
endif()
|
2019-08-01 20:31:25 +03:00
|
|
|
# Include file check macros honor CMAKE_REQUIRED_LIBRARIES.
|
|
|
|
|
if (POLICY CMP0075)
|
|
|
|
|
cmake_policy(SET CMP0075 NEW)
|
|
|
|
|
endif()
|
2019-08-01 04:14:53 +03:00
|
|
|
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
# Only interpret if() arguments as variables or keywords when unquoted.
|
|
|
|
|
# CMake emits a warning if this is not set.
|
|
|
|
|
if (POLICY CMP0054)
|
|
|
|
|
cmake_policy(SET CMP0054 NEW)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Pick up a workaround for a CMake problem from LLVM r282552.
|
|
|
|
|
if(POLICY CMP0057)
|
|
|
|
|
cmake_policy(SET CMP0057 NEW)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Enable transitive library dependencies
|
|
|
|
|
if(POLICY CMP0022)
|
|
|
|
|
cmake_policy(SET CMP0022 NEW)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Don't complain about mixing plain and keyword target_link_libraries commands.
|
|
|
|
|
# Keyword style is when you specify whether library symbols are re-exported,
|
|
|
|
|
# e.g. target_link_libraries(target PRIVATE lib).
|
|
|
|
|
# LLVM currently uses plain-style target_link_libraries calls so we must
|
|
|
|
|
# allow mixing.
|
|
|
|
|
if (POLICY CMP0023)
|
|
|
|
|
cmake_policy(SET CMP0023 OLD)
|
|
|
|
|
endif()
|
|
|
|
|
|
2020-07-09 03:13:30 +03:00
|
|
|
# Allow reading the LOCATION property of a target to determine the eventual
|
|
|
|
|
# location of build targets. This is needed when building the debugging symbols
|
|
|
|
|
# bundles for Apple platforms.
|
|
|
|
|
if (POLICY CMP0026)
|
|
|
|
|
cmake_policy(SET CMP0026 OLD)
|
|
|
|
|
endif()
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
|
2020-09-09 05:19:09 +03:00
|
|
|
# Has to be set before `project` as per documentation
|
|
|
|
|
# https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html
|
|
|
|
|
set(CMAKE_OSX_SYSROOT ${HERMES_APPLE_TARGET_PLATFORM})
|
|
|
|
|
|
2020-07-09 03:13:30 +03:00
|
|
|
# This must be consistent with the release_version in:
|
|
|
|
|
# - android/build.gradle
|
|
|
|
|
# - npm/package.json
|
|
|
|
|
# - hermes.podspec
|
2019-08-01 04:14:53 +03:00
|
|
|
project(Hermes
|
2020-09-11 06:05:45 +03:00
|
|
|
VERSION 0.7.0
|
2019-08-01 04:14:53 +03:00
|
|
|
LANGUAGES C CXX)
|
2020-04-01 02:48:04 +03:00
|
|
|
# Optional suffix like "-rc3"
|
|
|
|
|
set(VERSION_SUFFIX "")
|
2019-07-23 01:43:22 +03:00
|
|
|
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/")
|
|
|
|
|
|
|
|
|
|
set(LLVH_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/external/llvh)
|
|
|
|
|
|
|
|
|
|
include(Hermes)
|
|
|
|
|
include(Lit)
|
2019-07-10 19:43:32 +03:00
|
|
|
|
2020-04-01 02:48:04 +03:00
|
|
|
set(HERMES_RELEASE_VERSION ${PROJECT_VERSION}${VERSION_SUFFIX})
|
2019-07-12 23:01:05 +03:00
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
# Project options.
|
2020-04-11 20:53:41 +03:00
|
|
|
|
|
|
|
|
set(HERMES_IS_ANDROID OFF CACHE BOOL
|
|
|
|
|
"Building for Android")
|
|
|
|
|
|
|
|
|
|
set(HERMES_IS_MOBILE_BUILD ${HERMES_IS_ANDROID} CACHE BOOL
|
|
|
|
|
"Building for a mobile device")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
set(HERMESVM_GCKIND NONCONTIG_GENERATIONAL
|
|
|
|
|
CACHE STRING
|
2020-05-05 05:02:13 +03:00
|
|
|
"HermesVM GC type: either NONCONTIG_GENERATIONAL, MALLOC, or HADES")
|
2019-07-10 19:43:32 +03:00
|
|
|
set(HERMESVM_GC_GENERATIONAL_MARKSWEEPCOMPACT OFF
|
|
|
|
|
CACHE BOOL
|
|
|
|
|
"HermesVM GC: only allocate into the old generation, mimicking a Mark-Sweep-Compact collector")
|
|
|
|
|
|
|
|
|
|
# Hermes VM opcode stats profiling
|
|
|
|
|
set(HERMESVM_PROFILER_OPCODE OFF CACHE BOOL
|
|
|
|
|
"Enable opcode stats profiling in hermes VM")
|
|
|
|
|
|
|
|
|
|
# Hermes VM basic block profiling
|
|
|
|
|
set(HERMESVM_PROFILER_BB OFF CACHE BOOL
|
|
|
|
|
"Enable basic block profiling in hermes VM")
|
|
|
|
|
|
|
|
|
|
# Hermes VM JS Function profiling
|
|
|
|
|
set(HERMESVM_PROFILER_JSFUNCTION OFF CACHE BOOL
|
|
|
|
|
"Enable JS Function profiling in hermes VM")
|
|
|
|
|
|
|
|
|
|
# Hermes VM native call profiling
|
|
|
|
|
set(HERMESVM_PROFILER_NATIVECALL OFF CACHE BOOL
|
|
|
|
|
"Enable native call profiling in hermes VM")
|
|
|
|
|
|
2019-08-27 21:32:00 +03:00
|
|
|
set(HERMESVM_SERIALIZE OFF CACHE BOOL
|
|
|
|
|
"Enable heap serialization and deserialization")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
set(HERMESVM_INDIRECT_THREADING ${DEFAULT_INTERPRETER_THREADING} CACHE BOOL
|
|
|
|
|
"Enable the indirect threaded interpreter")
|
|
|
|
|
|
|
|
|
|
set(HERMESVM_ALLOW_COMPRESSED_POINTERS ON CACHE BOOL
|
|
|
|
|
"Enable compressed pointers. If this is on and the target is a 64-bit build, compressed pointers will be used.")
|
|
|
|
|
|
2020-10-08 08:10:50 +03:00
|
|
|
set(HERMESVM_ALLOW_HUGE_PAGES OFF CACHE BOOL
|
|
|
|
|
"Enable huge pages to back the GC managed heap. Only useful on Linux.")
|
|
|
|
|
|
2019-10-18 02:37:43 +03:00
|
|
|
set(HERMESVM_API_TRACE OFF CACHE BOOL
|
|
|
|
|
"Enable tracing interactions via the API")
|
|
|
|
|
|
Introduce mode to simulate Android in Linux desktop synth replay.
Summary:
For convenient playback, we want to be able to replay a trace taken on 64-bit android on 64-bit desktop Linux. This diff introduces a config parameter and preprocessor variable governing that, and uses that preprocessor variable to fix the one place I found where the size of a class was different in 64-bit Android vs. Linux builds. Apparently, the platform we use on Linux has a small-string optimization, so std::string is 32 bytes, whereas it is only 8 bytes on Android. This makes the size of ExternalStringPrimitive differ between the two platforms.
To make them the same for replays on Linux, we add a config parameter indicating we are trying to simulate Android. ExternalStringPrimitive, when compiled with this mode, uses a pointer to the string, instead of having the string inline. This makes the sizes the same. (As a comment notes, if this made the size too small, then we would add padding.)
Reviewed By: tmikov
Differential Revision: D20821130
fbshipit-source-id: a125e5d116e07da1b16163b60cfa15860c37b265
2020-04-26 10:57:12 +03:00
|
|
|
set(HERMESVM_API_TRACE_ANDROID_REPLAY OFF CACHE BOOL
|
|
|
|
|
"Simulate Android config on Linux in API tracing.")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
# Hermes VM Handle sanitization (moving the heap after every alloc)
|
|
|
|
|
set(HERMESVM_SANITIZE_HANDLES OFF CACHE BOOL
|
|
|
|
|
"Enable Handle sanitization")
|
|
|
|
|
|
2020-04-23 02:55:50 +03:00
|
|
|
# Enable Address Sanitizer
|
|
|
|
|
set(HERMES_ENABLE_ADDRESS_SANITIZER OFF CACHE BOOL
|
|
|
|
|
"Enable -fsanitize=address")
|
|
|
|
|
|
|
|
|
|
# Enable Undefined Behavior Sanitizer
|
|
|
|
|
set(HERMES_ENABLE_UNDEFINED_BEHAVIOR_SANITIZER OFF CACHE BOOL
|
|
|
|
|
"Enable -fsanitize=undefined")
|
|
|
|
|
|
2020-08-25 03:54:00 +03:00
|
|
|
# Enable Thread Sanitizer
|
|
|
|
|
set(HERMES_ENABLE_THREAD_SANITIZER OFF CACHE BOOL
|
|
|
|
|
"Enable -fsanitize=thread")
|
|
|
|
|
|
2020-07-13 19:53:18 +03:00
|
|
|
set(HERMES_ENABLE_FUZZING OFF CACHE BOOL
|
2020-07-09 03:13:30 +03:00
|
|
|
"Enable fuzzing")
|
|
|
|
|
|
2020-09-29 01:04:05 +03:00
|
|
|
set(HERMES_ENABLE_TOOLS ON CACHE BOOL
|
|
|
|
|
"Enable CLI tools")
|
|
|
|
|
|
2020-09-23 00:39:57 +03:00
|
|
|
# Enable bitcode
|
|
|
|
|
set(HERMES_ENABLE_BITCODE OFF CACHE BOOL
|
|
|
|
|
"Include bitcode with the framework")
|
|
|
|
|
|
2020-05-22 00:19:04 +03:00
|
|
|
# Set linker flag for building the fuzzer
|
|
|
|
|
set(HERMES_FUZZING_FLAG "-fsanitize=fuzzer" CACHE STRING
|
|
|
|
|
"Linker argument to link fuzz targets against a given fuzzer.")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
# Build with -DHERMES_SLOW_DEBUG for debug builds
|
|
|
|
|
# This does not affect release builds
|
|
|
|
|
set(HERMES_SLOW_DEBUG ON CACHE BOOL
|
|
|
|
|
"Enable slow checks in Debug builds")
|
|
|
|
|
|
|
|
|
|
# On CentOS:
|
|
|
|
|
# sudo yum install zlib-static glibc-static ncurses-static readline-static
|
|
|
|
|
set(HERMES_STATIC_LINK OFF CACHE BOOL
|
|
|
|
|
"Link Hermes statically. May only work on GNU/Linux.")
|
|
|
|
|
|
2020-05-22 00:19:04 +03:00
|
|
|
set(HERMES_USE_STATIC_ICU OFF CACHE BOOL
|
|
|
|
|
"Force static linking of ICU. May only work on GNU/Linux.")
|
|
|
|
|
|
2020-04-11 20:53:41 +03:00
|
|
|
set(HERMES_ENABLE_DEBUGGER_DEFAULT OFF)
|
|
|
|
|
if (NOT HERMES_IS_MOBILE_BUILD)
|
|
|
|
|
set(HERMES_ENABLE_DEBUGGER_DEFAULT ON)
|
|
|
|
|
endif()
|
|
|
|
|
set(HERMES_ENABLE_DEBUGGER ${HERMES_ENABLE_DEBUGGER_DEFAULT} CACHE BOOL
|
2019-07-10 19:43:32 +03:00
|
|
|
"Build with debugger support")
|
|
|
|
|
|
2020-02-20 03:12:42 +03:00
|
|
|
set(HERMES_ENABLE_IR_INSTRUMENTATION OFF CACHE BOOL
|
|
|
|
|
"Build IR instrumentation support")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
set(HERMES_FACEBOOK_BUILD OFF CACHE BOOL
|
|
|
|
|
"Build Facebook (rather than open-source) version of Hermes")
|
|
|
|
|
|
|
|
|
|
set(HERMESVM_EXCEPTION_ON_OOM OFF CACHE BOOL
|
|
|
|
|
"GC Out-of-memory raises an exception, rather than causing a crash")
|
|
|
|
|
|
2019-09-12 20:07:45 +03:00
|
|
|
set(HERMESVM_PLATFORM_LOGGING OFF CACHE BOOL
|
|
|
|
|
"hermesLog(...) is enabled, using the platform's logging mechanism")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
set(HERMESVM_JIT OFF CACHE BOOL
|
|
|
|
|
"Enable the JIT")
|
|
|
|
|
|
|
|
|
|
set(HERMESVM_JIT_DISASSEMBLER OFF CACHE BOOL
|
|
|
|
|
"Enable the JIT disassembler")
|
|
|
|
|
|
|
|
|
|
set(HERMES_USE_FLOWPARSER OFF CACHE BOOL
|
|
|
|
|
"Use libflowparser for parsing es6")
|
|
|
|
|
|
|
|
|
|
set(HERMES_ENABLE_WERROR OFF CACHE BOOL
|
|
|
|
|
"Whether the build should have -Werror enabled")
|
|
|
|
|
|
2019-08-01 00:10:10 +03:00
|
|
|
set(HERMES_ENABLE_WIN10_ICU_FALLBACK ON CACHE BOOL
|
|
|
|
|
"Whether to allow falling back on Win10 ICU")
|
|
|
|
|
|
2019-08-02 03:46:09 +03:00
|
|
|
set(HERMES_GITHUB_RESOURCE_DIR "" CACHE STRING
|
|
|
|
|
"A directory with additional files to bundle in the GitHub release")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
set(ANDROID_LINUX_PERF_PATH ""
|
|
|
|
|
CACHE STRING
|
|
|
|
|
"If buildling for Android, full path to <linux/perf_events.h>")
|
|
|
|
|
|
2019-10-09 03:27:57 +03:00
|
|
|
set(HERMES_MSVC_MP ON CACHE STRING
|
|
|
|
|
"Enable /MP in MSVC for parallel builds")
|
|
|
|
|
|
2020-02-21 11:35:38 +03:00
|
|
|
set(EMSCRIPTEN_FASTCOMP ON CACHE BOOL
|
|
|
|
|
"Emscripten is using the fastcomp backend instead of the LLVM one")
|
|
|
|
|
|
2020-06-27 06:30:49 +03:00
|
|
|
set(HERMES_ENABLE_INTL OFF CACHE BOOL
|
|
|
|
|
"Enable JS Intl support (WIP)")
|
|
|
|
|
|
2020-07-09 03:13:30 +03:00
|
|
|
set(HERMES_ENABLE_TEST_SUITE ON CACHE BOOL
|
|
|
|
|
"Enable the test suite")
|
|
|
|
|
|
|
|
|
|
set(HERMES_BUILD_APPLE_FRAMEWORK ON CACHE BOOL
|
|
|
|
|
"Whether to build the libhermes target as a framework bundle or dylib on Apple platforms")
|
|
|
|
|
|
Add explicit option to build Apple dSYM (#296)
Summary:
Add `HERMES_BUILD_APPLE_DSYM` option to build a dSYM bundle for the libhermes target on Apple platforms.
This will work with any of the build types and is off by default.
Installing the tools with the install/strip target will ensure all tools and the runtime lib are stripped of debug symbols, but leaving the dSYM bundle in tact.
Pull Request resolved: https://github.com/facebook/hermes/pull/296
Test Plan:
### Build
```bash
./src/utils/build/configure.py --distribute --cmake-flags='-DHERMES_BUILD_APPLE_DSYM:BOOLEAN=true -DCMAKE_INSTALL_PREFIX:PATH=../destroot_release' build_release
cmake --build ./build_release
```
### Install without stripping
```bash
cmake --build ./build_release --target install
nm -a destroot_release/bin/hermesc | wc -l
27943
```
### Install with stripping
```bash
cmake --build ./build_release --target install/strip
nm -a destroot_release/bin/hermesc | wc -l
250
```
…and dSYM DWARF metadata is maintained:
```bash
dwarfdump --statistics destroot_release/Library/Frameworks/hermes.framework.dSYM
{"version":3,"file":"destroot_release/Library/Frameworks/hermes.framework.dSYM/Contents/Resources/DWARF/hermes","format":"Mach-O 64-bit x86-64","source functions":30305,"source functions with location":30302,"inlined functions":172725,"inlined funcs with abstract origins":172725,"unique source variables":79276,"source variables":353690,"variables with location":232195,"call site entries":186409,"scope bytes total":19161949,"scope bytes covered":10500176,"total function size":1763513,"total inlined function size":998375,"total formal params":300264,"formal params with source location":166067,"formal params with type":300264,"formal params with binary location":200407,"total vars":38809,"vars with source location":38385,"vars with type":38809,"vars with binary location":22161}
```
Reviewed By: tmikov
Differential Revision: D22576263
Pulled By: willholen
fbshipit-source-id: 2bda49e638d145ba5d029e77069d6adcc0b1dd8c
2020-07-17 00:04:10 +03:00
|
|
|
set(HERMES_BUILD_APPLE_DSYM OFF CACHE BOOL
|
|
|
|
|
"Whether to build a DWARF debugging symbols bundle")
|
|
|
|
|
|
2020-07-16 02:42:43 +03:00
|
|
|
if (HERMES_IS_ANDROID)
|
2020-03-06 04:04:01 +03:00
|
|
|
set(HERMES_IS_MOBILE_BUILD TRUE)
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
add_definitions(-DHERMES_PLATFORM_UNICODE=HERMES_PLATFORM_UNICODE_JAVA)
|
|
|
|
|
|
|
|
|
|
# The toolchain passes -Wa,--noexecstack which is valid for compiling
|
|
|
|
|
# but not for linking. Just ignore it.
|
|
|
|
|
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-unused-command-line-argument")
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-command-line-argument")
|
|
|
|
|
|
|
|
|
|
# JS developers aren't VM developers. Give them a faster build.
|
2019-09-04 22:47:52 +03:00
|
|
|
set(CMAKE_CXX_FLAGS_DEBUG "-O3 -g -DNDEBUG")
|
2019-07-10 19:43:32 +03:00
|
|
|
|
|
|
|
|
# The release build can focus on size.
|
|
|
|
|
set(CMAKE_CXX_FLAGS_RELEASE "-Os -DNDEBUG")
|
|
|
|
|
|
|
|
|
|
if (ANDROID_ABI STREQUAL "arm64-v8a")
|
|
|
|
|
# Using -flto on arm64 fails due to it using a different linker by default
|
|
|
|
|
# https://github.com/android-ndk/ndk/issues/242
|
|
|
|
|
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fuse-ld=gold")
|
|
|
|
|
endif()
|
|
|
|
|
endif()
|
|
|
|
|
|
Add explicit option to build Apple dSYM (#296)
Summary:
Add `HERMES_BUILD_APPLE_DSYM` option to build a dSYM bundle for the libhermes target on Apple platforms.
This will work with any of the build types and is off by default.
Installing the tools with the install/strip target will ensure all tools and the runtime lib are stripped of debug symbols, but leaving the dSYM bundle in tact.
Pull Request resolved: https://github.com/facebook/hermes/pull/296
Test Plan:
### Build
```bash
./src/utils/build/configure.py --distribute --cmake-flags='-DHERMES_BUILD_APPLE_DSYM:BOOLEAN=true -DCMAKE_INSTALL_PREFIX:PATH=../destroot_release' build_release
cmake --build ./build_release
```
### Install without stripping
```bash
cmake --build ./build_release --target install
nm -a destroot_release/bin/hermesc | wc -l
27943
```
### Install with stripping
```bash
cmake --build ./build_release --target install/strip
nm -a destroot_release/bin/hermesc | wc -l
250
```
…and dSYM DWARF metadata is maintained:
```bash
dwarfdump --statistics destroot_release/Library/Frameworks/hermes.framework.dSYM
{"version":3,"file":"destroot_release/Library/Frameworks/hermes.framework.dSYM/Contents/Resources/DWARF/hermes","format":"Mach-O 64-bit x86-64","source functions":30305,"source functions with location":30302,"inlined functions":172725,"inlined funcs with abstract origins":172725,"unique source variables":79276,"source variables":353690,"variables with location":232195,"call site entries":186409,"scope bytes total":19161949,"scope bytes covered":10500176,"total function size":1763513,"total inlined function size":998375,"total formal params":300264,"formal params with source location":166067,"formal params with type":300264,"formal params with binary location":200407,"total vars":38809,"vars with source location":38385,"vars with type":38809,"vars with binary location":22161}
```
Reviewed By: tmikov
Differential Revision: D22576263
Pulled By: willholen
fbshipit-source-id: 2bda49e638d145ba5d029e77069d6adcc0b1dd8c
2020-07-17 00:04:10 +03:00
|
|
|
if(HERMES_BUILD_APPLE_DSYM)
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -gdwarf")
|
|
|
|
|
endif()
|
|
|
|
|
|
2020-03-06 04:04:01 +03:00
|
|
|
if (HERMES_IS_MOBILE_BUILD)
|
|
|
|
|
add_definitions(-DHERMES_IS_MOBILE_BUILD)
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
# Enable debug mode by default
|
|
|
|
|
if ((NOT GENERATOR_IS_MULTI_CONFIG) AND CMAKE_BUILD_TYPE STREQUAL "")
|
|
|
|
|
set(CMAKE_BUILD_TYPE Debug)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (HERMES_STATIC_LINK)
|
2019-07-23 21:34:50 +03:00
|
|
|
set(CMAKE_EXE_LINKER_FLAGS "-static")
|
2020-05-22 00:19:04 +03:00
|
|
|
set(HERMES_USE_STATIC_ICU ON)
|
|
|
|
|
set(CMAKE_FIND_LIBRARY_SUFFIXES "${CMAKE_STATIC_LIBRARY_SUFFIX}")
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
CHECK_CXX_SOURCE_COMPILES(
|
|
|
|
|
"int main() { void *p = &&label; goto *p; label: return 0; }"
|
|
|
|
|
HAVE_COMPUTED_GOTO)
|
|
|
|
|
|
|
|
|
|
if(HAVE_COMPUTED_GOTO)
|
|
|
|
|
set(DEFAULT_INTERPRETER_THREADING ON)
|
|
|
|
|
else()
|
|
|
|
|
set(DEFAULT_INTERPRETER_THREADING OFF)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Check if the linker supports --gc-sections
|
|
|
|
|
# We can't simply CHECK_CXX_COMPILER_FLAG("-Wl,--gc-sections" ..) because CMake
|
|
|
|
|
# will compile and link separately and only passes the flag during compilation.
|
|
|
|
|
set(OLD_CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
|
|
|
|
|
set(CMAKE_EXE_LINKER_FLAGS "--gc-sections")
|
|
|
|
|
CHECK_CXX_COMPILER_FLAG("" HAVE_GC_SECTIONS)
|
|
|
|
|
set(CMAKE_EXE_LINKER_FLAGS "${OLD_CMAKE_EXE_LINKER_FLAGS}")
|
|
|
|
|
|
|
|
|
|
if(HAVE_GC_SECTIONS)
|
|
|
|
|
set(OPTIONAL_GC_SECTIONS "-Wl,--gc-sections")
|
|
|
|
|
else()
|
|
|
|
|
set(OPTIONAL_GC_SECTIONS "")
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-07-12 23:01:05 +03:00
|
|
|
# Make the HERMES_RELEASE_VERSION accessible for version printing in C++.
|
|
|
|
|
add_definitions(-DHERMES_RELEASE_VERSION="${HERMES_RELEASE_VERSION}")
|
|
|
|
|
|
2020-02-20 03:12:42 +03:00
|
|
|
if(HERMES_ENABLE_IR_INSTRUMENTATION)
|
|
|
|
|
add_definitions(-DHERMES_ENABLE_IR_INSTRUMENTATION)
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
add_definitions(-DHERMESVM_GC_${HERMESVM_GCKIND})
|
|
|
|
|
if(HERMESVM_GC_GENERATIONAL_MARKSWEEPCOMPACT)
|
|
|
|
|
add_definitions(-DHERMESVM_GC_GENERATIONAL_MARKSWEEPCOMPACT)
|
|
|
|
|
endif()
|
2019-09-28 01:17:53 +03:00
|
|
|
|
|
|
|
|
set(HERMES_PROFILER_MODE_IN_LIT_TEST "NONE")
|
2019-07-10 19:43:32 +03:00
|
|
|
if(HERMESVM_PROFILER_OPCODE)
|
|
|
|
|
add_definitions(-DHERMESVM_PROFILER_OPCODE)
|
2019-09-28 01:17:53 +03:00
|
|
|
set(HERMES_PROFILER_MODE_IN_LIT_TEST "OPCODE")
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
if(HERMESVM_PROFILER_BB)
|
|
|
|
|
add_definitions(-DHERMESVM_PROFILER_BB)
|
2019-09-28 01:17:53 +03:00
|
|
|
set(HERMES_PROFILER_MODE_IN_LIT_TEST "BB")
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
if(HERMESVM_PROFILER_JSFUNCTION)
|
|
|
|
|
add_definitions(-DHERMESVM_PROFILER_JSFUNCTION)
|
2019-09-28 01:17:53 +03:00
|
|
|
set(HERMES_PROFILER_MODE_IN_LIT_TEST "SAMPLING")
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
if(HERMESVM_PROFILER_NATIVECALL)
|
|
|
|
|
add_definitions(-DHERMESVM_PROFILER_NATIVECALL)
|
2019-09-28 01:17:53 +03:00
|
|
|
set(HERMES_PROFILER_MODE_IN_LIT_TEST "EXTERN")
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
2019-10-17 08:12:29 +03:00
|
|
|
if(HERMESVM_SERIALIZE)
|
|
|
|
|
add_definitions(-DHERMESVM_SERIALIZE)
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
if(HERMESVM_INDIRECT_THREADING)
|
|
|
|
|
add_definitions(-DHERMESVM_INDIRECT_THREADING)
|
|
|
|
|
endif()
|
2019-08-27 21:28:29 +03:00
|
|
|
if(HERMESVM_ALLOW_COMPRESSED_POINTERS)
|
|
|
|
|
add_definitions(-DHERMESVM_ALLOW_COMPRESSED_POINTERS)
|
|
|
|
|
endif()
|
2020-10-08 08:10:50 +03:00
|
|
|
if(HERMESVM_ALLOW_HUGE_PAGES)
|
|
|
|
|
add_definitions(-DHERMESVM_ALLOW_HUGE_PAGES)
|
|
|
|
|
endif()
|
2019-10-18 02:37:43 +03:00
|
|
|
if(HERMESVM_API_TRACE)
|
|
|
|
|
add_definitions(-DHERMESVM_API_TRACE)
|
|
|
|
|
endif()
|
Introduce mode to simulate Android in Linux desktop synth replay.
Summary:
For convenient playback, we want to be able to replay a trace taken on 64-bit android on 64-bit desktop Linux. This diff introduces a config parameter and preprocessor variable governing that, and uses that preprocessor variable to fix the one place I found where the size of a class was different in 64-bit Android vs. Linux builds. Apparently, the platform we use on Linux has a small-string optimization, so std::string is 32 bytes, whereas it is only 8 bytes on Android. This makes the size of ExternalStringPrimitive differ between the two platforms.
To make them the same for replays on Linux, we add a config parameter indicating we are trying to simulate Android. ExternalStringPrimitive, when compiled with this mode, uses a pointer to the string, instead of having the string inline. This makes the sizes the same. (As a comment notes, if this made the size too small, then we would add padding.)
Reviewed By: tmikov
Differential Revision: D20821130
fbshipit-source-id: a125e5d116e07da1b16163b60cfa15860c37b265
2020-04-26 10:57:12 +03:00
|
|
|
if(HERMESVM_API_TRACE_ANDROID_REPLAY)
|
|
|
|
|
add_definitions(-DHERMESVM_API_TRACE_ANDROID_REPLAY)
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
if(HERMESVM_SANITIZE_HANDLES)
|
|
|
|
|
add_definitions(-DHERMESVM_SANITIZE_HANDLES)
|
|
|
|
|
endif()
|
2020-04-23 02:55:50 +03:00
|
|
|
if (HERMES_ENABLE_ADDRESS_SANITIZER)
|
2020-07-01 08:11:30 +03:00
|
|
|
append("-fsanitize=address" CMAKE_CXX_FLAGS CMAKE_C_FLAGS CMAKE_EXE_LINKER_FLAGS)
|
2020-06-24 00:17:40 +03:00
|
|
|
# GCC does not automatically link libpthread when using ASAN
|
2020-07-01 08:11:30 +03:00
|
|
|
append("-lpthread" CMAKE_EXE_LINKER_FLAGS)
|
2020-04-23 02:55:50 +03:00
|
|
|
endif()
|
|
|
|
|
if (HERMES_ENABLE_UNDEFINED_BEHAVIOR_SANITIZER)
|
|
|
|
|
add_definitions(-DHERMES_UBSAN)
|
|
|
|
|
# Do not enable the vptr sanitizer, as it requires RTTI.
|
2020-05-22 00:19:04 +03:00
|
|
|
append("-fsanitize=undefined -fno-sanitize=vptr -fno-sanitize-recover=undefined" CMAKE_CXX_FLAGS CMAKE_C_FLAGS CMAKE_EXE_LINKER_FLAGS)
|
2020-04-23 02:55:50 +03:00
|
|
|
endif()
|
2020-08-25 03:54:00 +03:00
|
|
|
if (HERMES_ENABLE_THREAD_SANITIZER)
|
|
|
|
|
append("-fsanitize=thread" CMAKE_CXX_FLAGS CMAKE_C_FLAGS CMAKE_EXE_LINKER_FLAGS)
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
if(HERMES_FACEBOOK_BUILD)
|
|
|
|
|
add_definitions(-DHERMES_FACEBOOK_BUILD)
|
|
|
|
|
endif()
|
|
|
|
|
if(HERMESVM_EXCEPTION_ON_OOM)
|
|
|
|
|
add_definitions(-DHERMESVM_EXCEPTION_ON_OOM)
|
|
|
|
|
endif()
|
2019-09-12 20:07:45 +03:00
|
|
|
if(HERMESVM_PLATFORM_LOGGING)
|
|
|
|
|
add_definitions(-DHERMESVM_PLATFORM_LOGGING)
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
if(HERMESVM_JIT)
|
|
|
|
|
add_definitions(-DHERMESVM_JIT)
|
|
|
|
|
endif()
|
|
|
|
|
if(HERMESVM_JIT_DISASSEMBLER)
|
|
|
|
|
add_definitions(-DHERMESVM_JIT_DISASSEMBLER)
|
|
|
|
|
endif()
|
|
|
|
|
if (NOT (ANDROID_LINUX_PERF_PATH STREQUAL ""))
|
|
|
|
|
add_definitions(-DANDROID_LINUX_PERF_PATH="${ANDROID_LINUX_PERF_PATH}")
|
|
|
|
|
endif()
|
|
|
|
|
|
2020-06-27 06:30:49 +03:00
|
|
|
if (HERMES_ENABLE_INTL)
|
|
|
|
|
if (HERMES_IS_ANDROID)
|
|
|
|
|
add_definitions(-DHERMES_PLATFORM_INTL=HERMES_PLATFORM_INTL_ANDROID)
|
|
|
|
|
else()
|
|
|
|
|
add_definitions(-DHERMES_PLATFORM_INTL=HERMES_PLATFORM_INTL_DUMMY)
|
|
|
|
|
endif()
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
if (HERMES_ENABLE_WERROR)
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
# Turn all warnings into errors on GCC-compatible compilers.
|
|
|
|
|
if (GCC_COMPATIBLE)
|
|
|
|
|
append("-Werror" CMAKE_CXX_FLAGS CMAKE_C_FLAGS)
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Collect all header files and add them to the IDE.
|
|
|
|
|
file(GLOB_RECURSE ALL_HEADER_FILES "*.h")
|
|
|
|
|
|
|
|
|
|
if(HERMES_SLOW_DEBUG)
|
|
|
|
|
# Enable HERMES_SLOW_DEBUG in Debug mode
|
|
|
|
|
set_property(DIRECTORY APPEND PROPERTY
|
|
|
|
|
COMPILE_DEFINITIONS $<$<CONFIG:Debug>:HERMES_SLOW_DEBUG>)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if ((NOT GENERATOR_IS_MULTI_CONFIG) AND (CMAKE_BUILD_TYPE STREQUAL Debug))
|
|
|
|
|
set(HERMES_ASSUMED_BUILD_MODE_IN_LIT_TEST "dbg")
|
|
|
|
|
else()
|
|
|
|
|
set(HERMES_ASSUMED_BUILD_MODE_IN_LIT_TEST "opt")
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (NOT (GENERATOR_IS_MULTI_CONFIG OR CMAKE_BUILD_TYPE STREQUAL Debug OR CMAKE_COMPILER_IS_GNUCXX))
|
|
|
|
|
# Enable LTO if we are not multi config generator and not a DEBUG build
|
|
|
|
|
# and not GCC
|
|
|
|
|
# GCC currently fails to link Hermes with LTO (see t16557748)
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
option(HERMES_ENABLE_LTO "Build Hermes with LTO" ON)
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
|
2020-09-24 20:43:39 +03:00
|
|
|
if (CMAKE_COMPILER_IS_GNUCXX)
|
2019-12-06 02:33:58 +03:00
|
|
|
# Suppress uninteresting warnings about initializing ArrayRef from initializer lists.
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
check_cxx_compiler_flag("-Winit-list-lifetime" INIT_LIST_LIFETIME_FLAG)
|
|
|
|
|
append_if(INIT_LIST_LIFETIME_FLAG "-Wno-init-list-lifetime" CMAKE_CXX_FLAGS)
|
2020-09-24 20:43:39 +03:00
|
|
|
# Suppress the redundant move warnings in GCC 9, because it leads to suboptimal
|
|
|
|
|
# recommendations for older compilers that do not implement C++ Core Issue 1579.
|
|
|
|
|
check_cxx_compiler_flag("-Wredundant-move" REDUNDANT_MOVE_FLAG)
|
|
|
|
|
append_if(REDUNDANT_MOVE_FLAG "-Wno-redundant-move" CMAKE_CXX_FLAGS)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (GCC_COMPATIBLE)
|
2019-07-10 19:43:32 +03:00
|
|
|
# Don't export symbols unless we explicitly say so
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fvisibility=hidden")
|
|
|
|
|
elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC")
|
|
|
|
|
# C4068 unknown pragma
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -wd4068")
|
2019-10-10 02:28:01 +03:00
|
|
|
# C4200 nonstandard extension used: zero-sized array in struct/union
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -wd4200")
|
2019-07-10 19:43:32 +03:00
|
|
|
# C4201 nonstandard extension used: nameless struct/union
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -wd4201")
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
# C4530 C++ exception handler used, but unwind semantics are not enabled
|
|
|
|
|
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -wd4530")
|
2019-10-09 03:27:57 +03:00
|
|
|
# Parallelize build
|
|
|
|
|
if (HERMES_MSVC_MP)
|
|
|
|
|
add_definitions( /MP )
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Export a JSON file with the compilation commands that external tools can use
|
|
|
|
|
# to analyze the source code of the project.
|
|
|
|
|
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
|
|
|
|
|
|
|
|
|
|
# Attempt to use system ICU first, if none specified.
|
|
|
|
|
# Don't need ICU on Apple systems.
|
|
|
|
|
if (APPLE)
|
|
|
|
|
set(ICU_FOUND 1)
|
|
|
|
|
set(ICU_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/external/icu_decls)
|
|
|
|
|
set(ICU_LIBRARIES
|
|
|
|
|
icucore
|
|
|
|
|
)
|
|
|
|
|
include_directories(${ICU_INCLUDE_DIRS})
|
2020-02-21 11:35:38 +03:00
|
|
|
elseif(EMSCRIPTEN)
|
|
|
|
|
# Just ignore ICU on Emiscripten. For now.
|
|
|
|
|
set(ICU_FOUND 1)
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (NOT ICU_FOUND)
|
|
|
|
|
# Workaround: FindICU does not correctly recognize ICU include dir until
|
|
|
|
|
# CMake 3.8.0. https://github.com/Kitware/CMake/commit/cdf7e5d8
|
|
|
|
|
list(APPEND icu_include_suffixes "include")
|
|
|
|
|
|
2020-05-22 00:19:04 +03:00
|
|
|
set(CMAKE_FIND_LIBRARY_SUFFIXES_OLD "${CMAKE_FIND_LIBRARY_SUFFIXES}")
|
|
|
|
|
if (HERMES_USE_STATIC_ICU)
|
|
|
|
|
add_definitions(-DU_STATIC_IMPLEMENTATION)
|
|
|
|
|
set(CMAKE_FIND_LIBRARY_SUFFIXES "${CMAKE_STATIC_LIBRARY_SUFFIX}")
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
# FindICU uses ICU_ROOT variable as a hint
|
|
|
|
|
# Include 'uc' twice for static libraries that depend on each other.
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
find_global_package(ICU 52 COMPONENTS uc i18n data uc)
|
2019-07-10 19:43:32 +03:00
|
|
|
|
2020-05-22 00:19:04 +03:00
|
|
|
set(CMAKE_FIND_LIBRARY_SUFFIXES "${CMAKE_FIND_LIBRARY_SUFFIXES_OLD}")
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
if (ICU_FOUND)
|
|
|
|
|
foreach(LIB_FILE ${ICU_LIBRARIES})
|
|
|
|
|
get_filename_component(LIB_DIR ${LIB_FILE} DIRECTORY)
|
|
|
|
|
list(APPEND ICU_RPATH ${LIB_DIR})
|
|
|
|
|
endforeach(LIB_FILE)
|
|
|
|
|
list(REMOVE_DUPLICATES ICU_RPATH)
|
|
|
|
|
message("icu dir: ${ICU_RPATH}")
|
|
|
|
|
include_directories(${ICU_INCLUDE_DIRS})
|
|
|
|
|
endif()
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# ICU is available on Windows, but only since Windows 10 v1703.
|
|
|
|
|
# Therefore, use it only as fallback.
|
2019-08-01 00:10:10 +03:00
|
|
|
if (NOT ICU_FOUND AND HERMES_ENABLE_WIN10_ICU_FALLBACK AND
|
2019-07-10 19:43:32 +03:00
|
|
|
WIN32 AND # Windows 32 or 64 bit
|
|
|
|
|
# At least Windows 10 version 1703 (aka Creators Update)
|
|
|
|
|
NOT ${CMAKE_SYSTEM_VERSION} VERSION_LESS "10.0.15063")
|
|
|
|
|
add_definitions(-DUSE_WIN10_ICU)
|
|
|
|
|
set(ICU_FOUND 1)
|
|
|
|
|
set(ICU_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/external/icu_decls)
|
|
|
|
|
set(ICU_LIBRARIES
|
|
|
|
|
icuuc icuin
|
|
|
|
|
)
|
|
|
|
|
include_directories(${ICU_INCLUDE_DIRS})
|
|
|
|
|
message("Using Windows 10 built-in ICU")
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# If we have no ICU, then error out.
|
|
|
|
|
if (NOT HERMES_IS_ANDROID AND NOT ICU_FOUND)
|
|
|
|
|
message(FATAL_ERROR "Unable to find ICU.")
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
# Declare a function that links ICU for the given target.
|
|
|
|
|
# This adds the correct -rpath link flag as necessary.
|
|
|
|
|
function(hermes_link_icu target_name)
|
|
|
|
|
get_target_property(target_type ${target_name} TYPE)
|
2019-07-23 21:34:50 +03:00
|
|
|
target_link_libraries(${target_name} PRIVATE ${ICU_LIBRARIES})
|
2020-05-22 00:19:04 +03:00
|
|
|
|
|
|
|
|
if (HERMES_USE_STATIC_ICU)
|
|
|
|
|
if ((NOT EMSCRIPTEN) AND target_type MATCHES "EXECUTABLE|STATIC_LIBRARY")
|
|
|
|
|
target_link_libraries(${target_name} PRIVATE dl pthread)
|
|
|
|
|
elseif(target_type MATCHES "MODULE_LIBRARY|SHARED_LIBRARY")
|
|
|
|
|
message(WARNING "ICU cannot be statically linked against shared library target ${target_name}")
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (ICU_RPATH)
|
|
|
|
|
set_property(TARGET ${target_name} APPEND PROPERTY
|
|
|
|
|
INSTALL_RPATH ${ICU_RPATH})
|
|
|
|
|
set_property(TARGET ${target_name} PROPERTY
|
|
|
|
|
BUILD_WITH_INSTALL_RPATH TRUE)
|
|
|
|
|
endif()
|
|
|
|
|
endfunction()
|
|
|
|
|
|
|
|
|
|
if (APPLE)
|
|
|
|
|
find_library(CORE_FOUNDATION CoreFoundation)
|
|
|
|
|
else()
|
|
|
|
|
set(CORE_FOUNDATION "")
|
|
|
|
|
endif()
|
|
|
|
|
|
2020-02-21 11:35:38 +03:00
|
|
|
if (HERMES_USE_FLOWPARSER)
|
|
|
|
|
if (CMAKE_SYSTEM_NAME STREQUAL Darwin AND NOT HERMES_BUILD_32_BITS)
|
|
|
|
|
set(LIBFLOWPARSER ${CMAKE_CURRENT_SOURCE_DIR}/external/flowparser/libflowparser-mac.a)
|
|
|
|
|
elseif (CMAKE_SYSTEM_NAME STREQUAL Linux AND NOT HERMES_BUILD_32_BITS)
|
|
|
|
|
set(LIBFLOWPARSER ${CMAKE_CURRENT_SOURCE_DIR}/external/flowparser/libflowparser-linux.a)
|
|
|
|
|
else()
|
|
|
|
|
set(LIBFLOWPARSER "")
|
|
|
|
|
set(HERMES_USE_FLOWPARSER OFF)
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (HERMES_USE_FLOWPARSER)
|
|
|
|
|
add_definitions(-DHERMES_USE_FLOWPARSER)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
if (HERMES_ENABLE_DEBUGGER)
|
|
|
|
|
add_definitions(-DHERMES_ENABLE_DEBUGGER)
|
|
|
|
|
endif()
|
|
|
|
|
|
|
|
|
|
set(CMAKE_XCODE_ATTRIBUTE_CLANG_CXX_LANGUAGE_STANDARD "c++11")
|
|
|
|
|
|
|
|
|
|
set(HERMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
|
|
|
|
|
set(HERMES_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
|
|
|
|
|
|
|
|
|
|
if(EXISTS ${HERMES_SOURCE_DIR}/API/jsi)
|
|
|
|
|
set(HERMES_JSI_DIR ${HERMES_SOURCE_DIR}/API/jsi)
|
|
|
|
|
elseif(EXISTS ${FBSOURCE_DIR}/xplat/jsi)
|
|
|
|
|
set(HERMES_JSI_DIR ${FBSOURCE_DIR}/xplat/jsi)
|
|
|
|
|
elseif(EXISTS ${HERMES_SOURCE_DIR}/../jsi)
|
|
|
|
|
set(HERMES_JSI_DIR ${HERMES_SOURCE_DIR}/../jsi)
|
|
|
|
|
else()
|
|
|
|
|
message(FATAL_ERROR "Unable to find jsi.")
|
|
|
|
|
endif()
|
|
|
|
|
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
include_directories(
|
|
|
|
|
external/llvh/include
|
|
|
|
|
external/llvh/gen/include
|
|
|
|
|
${CMAKE_CURRENT_BINARY_DIR}/external/llvh/include
|
|
|
|
|
)
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
include_directories(BEFORE
|
|
|
|
|
${CMAKE_CURRENT_BINARY_DIR}/include
|
|
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/include
|
|
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/public
|
|
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/external/flowparser/include
|
|
|
|
|
${CMAKE_CURRENT_SOURCE_DIR}/external
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
if(HERMES_IS_ANDROID)
|
|
|
|
|
if(EXISTS ${HERMES_SOURCE_DIR}/first-party/fbjni/cxx)
|
|
|
|
|
set(FBJNI_PATH ${HERMES_SOURCE_DIR}/first-party/fbjni)
|
|
|
|
|
elseif(EXISTS ${FBSOURCE_DIR}/fbandroid/libraries/fbjni/cxx)
|
|
|
|
|
set(FBJNI_PATH ${FBSOURCE_DIR}/fbandroid/libraries/fbjni)
|
|
|
|
|
elseif(EXISTS ${HERMES_SOURCE_DIR}/../../fbandroid/libraries/fbjni/cxx)
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
set(FBJNI_PATH ${HERMES_SOURCE_DIR}/../../fbandroid/libraries/fbjni)
|
2019-07-10 19:43:32 +03:00
|
|
|
else()
|
|
|
|
|
message(FATAL_ERROR "Unable to find fbjni.")
|
|
|
|
|
endif()
|
|
|
|
|
include_directories("${FBJNI_PATH}/cxx/")
|
|
|
|
|
add_subdirectory(first-party/fbjni)
|
|
|
|
|
|
|
|
|
|
# JNI requires that JNI_OnLoad is (re-)exported for initialization.
|
|
|
|
|
set(OPTIONAL_JNI_ONLOAD "-Wl,--undefined=JNI_OnLoad")
|
|
|
|
|
endif()
|
|
|
|
|
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
set(CMAKE_CXX_STANDARD 11)
|
|
|
|
|
set(CMAKE_CXX_STANDARD_REQUIRED ON)
|
|
|
|
|
set(CMAKE_CXX_EXTENSIONS OFF)
|
|
|
|
|
|
|
|
|
|
add_subdirectory(external/llvh)
|
|
|
|
|
add_subdirectory(utils/hermes-lit)
|
2019-07-10 19:43:32 +03:00
|
|
|
add_subdirectory(include)
|
|
|
|
|
add_subdirectory(lib)
|
2020-07-09 03:13:30 +03:00
|
|
|
add_subdirectory(public)
|
2019-07-10 19:43:32 +03:00
|
|
|
add_subdirectory(external)
|
|
|
|
|
add_subdirectory(API)
|
2020-06-27 06:30:49 +03:00
|
|
|
add_subdirectory(android/intltest/java/com/facebook/hermes/test)
|
2019-07-10 19:43:32 +03:00
|
|
|
|
2020-09-29 01:04:05 +03:00
|
|
|
if(HERMES_ENABLE_TOOLS)
|
|
|
|
|
add_subdirectory(tools)
|
|
|
|
|
endif()
|
|
|
|
|
|
Use internal fork of LLVM
Summary:
Place a fork of LLVM git rev c179d7b006348005d2da228aed4c3c251590baa3
under `external/llvh`(1) and modify the CMake build to use it.
I am calling it a "fork", because it is not all of LLVM. Only the parts
that are used by Hermes are included, which at this time is only parts
of `libLLVMSupporrt`. Most(2) of LLVM build scripts are removed, and it
is treated just as another ordinary library.
(1) Why `llvh`? To be able to coexist with instances of the "real" LLVM,
we must change the namespace, all public symbols containing the `llvm`
string and the include directory name. `llvh` seemed as good a name as
any. I also considered `llvm-h` and `h-llvm`, but the problem is that
they are a superstring of `llvm` so it becomes harder to search for the
`llvm` string.
Note that the actual rename will happen in a follow up diff. It would be
a massive patch.
(2) libLLVMSupport relies on pretty elaborate feature detection scripts,
which would be painful to duplicate, so for now I have preserved them
under external/llvh/cmake.
Unfortunately turning LLVM into an ordinary library is not enough, since
we were implicitly relying on a lot of functionality provided by the
LLVM build scripts. Things like setting default warning flags, easily
turning exceptions on and off, etc.
I attempted to replace it with Hermes equivalents, which are now
provided by `cmake/Hermes.cmake`:
- `add_llvm_library/tool()` is replaced by `add_hermes_library/tool()`.
- Several `LLVM_xxx` variables are replaced my similar `HERMES_xxx`
ones.
As a result, building Hermes now requires only checking it out, and
running CMake and Ninja. It is a vastly simpler process than before.
== Limitations
- CMake LTO and ASAN builds aren't supported yet.
- The JIT requires the "real" LLVM for disassembly.
Reviewed By: avp
Differential Revision: D19658656
fbshipit-source-id: 5094d2af45e343973b1aab02c550a18b2bf93a06
2020-02-06 11:30:00 +03:00
|
|
|
# Make sure JSI is compiled with PIC
|
|
|
|
|
set(save_CMAKE_POSITION_INDEPENDENT_CODE ${CMAKE_POSITION_INDEPENDENT_CODE})
|
|
|
|
|
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
|
|
|
|
|
add_subdirectory(${HERMES_JSI_DIR}/jsi ${CMAKE_CURRENT_BINARY_DIR}/jsi)
|
|
|
|
|
set(CMAKE_POSITION_INDEPENDENT_CODE ${save_CMAKE_POSITION_INDEPENDENT_CODE})
|
|
|
|
|
|
2020-01-22 06:39:51 +03:00
|
|
|
if (EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/facebook)
|
|
|
|
|
add_subdirectory(facebook)
|
|
|
|
|
endif()
|
|
|
|
|
|
2019-07-10 19:43:32 +03:00
|
|
|
# Configure the test suites
|
|
|
|
|
#
|
2020-07-09 03:13:30 +03:00
|
|
|
if(HERMES_ENABLE_TEST_SUITE)
|
2020-09-29 01:04:05 +03:00
|
|
|
if(NOT HERMES_ENABLE_TOOLS)
|
|
|
|
|
message(FATAL_ERROR, "Running the test-suite requires the CLI tools to be built.")
|
|
|
|
|
endif()
|
|
|
|
|
|
2020-07-09 03:13:30 +03:00
|
|
|
add_subdirectory(unittests)
|
|
|
|
|
|
|
|
|
|
list(APPEND HERMES_TEST_DEPS
|
|
|
|
|
HermesUnitTests
|
|
|
|
|
hermes
|
|
|
|
|
hermesc
|
|
|
|
|
hvm
|
|
|
|
|
interp-dispatch-bench
|
|
|
|
|
hdb
|
|
|
|
|
hbcdump
|
|
|
|
|
hbc-attribute
|
|
|
|
|
hbc-deltaprep
|
|
|
|
|
hbc-diff
|
|
|
|
|
dependency-extractor
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
set(HERMES_LIT_TEST_PARAMS
|
|
|
|
|
test_exec_root=${HERMES_BINARY_DIR}/test
|
|
|
|
|
unittests_dir=${HERMES_BINARY_DIR}/unittests
|
|
|
|
|
debugger_enabled=${HERMES_ENABLE_DEBUGGER}
|
|
|
|
|
use_flowparser=${HERMES_USE_FLOWPARSER}
|
|
|
|
|
jit_enabled=${HERMESVM_JIT}
|
|
|
|
|
jit_disassembler_enabled=${HERMESVM_JIT_DISASSEMBLER}
|
|
|
|
|
hbc_deltaprep=${HERMES_TOOLS_OUTPUT_DIR}/hbc-deltaprep
|
|
|
|
|
dependency_extractor=${HERMES_TOOLS_OUTPUT_DIR}/dependency-extractor
|
|
|
|
|
FileCheck=${HERMES_TOOLS_OUTPUT_DIR}//FileCheck
|
|
|
|
|
hermes=${HERMES_TOOLS_OUTPUT_DIR}/hermes
|
|
|
|
|
hermesc=${HERMES_TOOLS_OUTPUT_DIR}/hermesc
|
|
|
|
|
hdb=${HERMES_TOOLS_OUTPUT_DIR}/hdb
|
|
|
|
|
hbcdump=${HERMES_TOOLS_OUTPUT_DIR}/hbcdump
|
|
|
|
|
hbc-deltaprep=${HERMES_TOOLS_OUTPUT_DIR}/hbc-deltaprep
|
|
|
|
|
hbc_diff=${HERMES_TOOLS_OUTPUT_DIR}/hbc-diff
|
|
|
|
|
build_mode=${HERMES_ASSUMED_BUILD_MODE_IN_LIT_TEST}
|
|
|
|
|
exception_on_oom_enabled=${HERMESVM_EXCEPTION_ON_OOM}
|
|
|
|
|
serialize_enabled=${HERMESVM_SERIALIZE}
|
|
|
|
|
profiler=${HERMES_PROFILER_MODE_IN_LIT_TEST}
|
|
|
|
|
gc=${HERMESVM_GCKIND}
|
|
|
|
|
ubsan=${HERMES_ENABLE_UNDEFINED_BEHAVIOR_SANITIZER}
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
set(LLVH_LIT_ARGS "-sv")
|
|
|
|
|
|
|
|
|
|
add_lit_testsuite(check-hermes "Running the Hermes regression tests"
|
|
|
|
|
${HERMES_SOURCE_DIR}/test
|
|
|
|
|
${HERMES_SOURCE_DIR}/unittests
|
|
|
|
|
PARAMS ${HERMES_LIT_TEST_PARAMS}
|
|
|
|
|
DEPENDS ${HERMES_TEST_DEPS}
|
|
|
|
|
ARGS ${HERMES_TEST_EXTRA_ARGS}
|
|
|
|
|
)
|
|
|
|
|
set_target_properties(check-hermes PROPERTIES FOLDER "Hermes regression tests")
|
|
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
|
|
|
|
|
# This is how github release files are built.
|
|
|
|
|
|
|
|
|
|
set(HERMES_GITHUB_DIR ${HERMES_BINARY_DIR}/github)
|
|
|
|
|
string(TOLOWER ${CMAKE_SYSTEM_NAME} HERMES_GITHUB_SYSTEM_NAME)
|
|
|
|
|
|
2020-09-29 01:04:05 +03:00
|
|
|
if(HERMES_ENABLE_TOOLS)
|
|
|
|
|
set(HERMES_CLI_GITHUB_FILE hermes-cli-${HERMES_GITHUB_SYSTEM_NAME}-v${HERMES_RELEASE_VERSION}.tar.gz)
|
|
|
|
|
set(HERMES_GITHUB_BUNDLE_DIR ${HERMES_BINARY_DIR}/bundle)
|
|
|
|
|
|
|
|
|
|
# If the github release should include extra files (like dlls)
|
|
|
|
|
if (HERMES_GITHUB_RESOURCE_DIR STREQUAL "")
|
|
|
|
|
set(HERMES_GITHUB_EXTRAS "")
|
2019-08-02 03:46:09 +03:00
|
|
|
else()
|
2020-09-29 01:04:05 +03:00
|
|
|
if (IS_DIRECTORY ${HERMES_GITHUB_RESOURCE_DIR})
|
|
|
|
|
file(GLOB HERMES_GITHUB_EXTRAS "${HERMES_GITHUB_RESOURCE_DIR}/*")
|
|
|
|
|
else()
|
|
|
|
|
message(FATAL_ERROR "Extra resource dir not found: ${HERMES_GITHUB_RESOURCE_DIR}")
|
|
|
|
|
endif()
|
2019-08-02 03:46:09 +03:00
|
|
|
endif()
|
2019-07-10 19:43:32 +03:00
|
|
|
|
2020-09-29 01:04:05 +03:00
|
|
|
# We need this as a separate target because Ninja doesn't run PRE_BUILD/PRE_LINKs in time
|
|
|
|
|
add_custom_command(
|
|
|
|
|
OUTPUT ${HERMES_GITHUB_BUNDLE_DIR}
|
|
|
|
|
COMMAND ${CMAKE_COMMAND} -E make_directory ${HERMES_GITHUB_BUNDLE_DIR})
|
|
|
|
|
add_custom_target(make_bundle_dir DEPENDS ${HERMES_GITHUB_BUNDLE_DIR})
|
|
|
|
|
|
|
|
|
|
add_custom_command(
|
|
|
|
|
OUTPUT ${HERMES_GITHUB_DIR}/${HERMES_CLI_GITHUB_FILE}
|
|
|
|
|
WORKING_DIRECTORY ${HERMES_GITHUB_BUNDLE_DIR}
|
|
|
|
|
DEPENDS hermes hermesc hdb hbcdump make_bundle_dir
|
|
|
|
|
VERBATIM
|
|
|
|
|
COMMAND
|
|
|
|
|
# We need bin/hermes or Release/bin/hermes.exe in a predictable location
|
|
|
|
|
${CMAKE_COMMAND} -E copy $<TARGET_FILE:hermes> $<TARGET_FILE:hermesc> $<TARGET_FILE:hdb> $<TARGET_FILE:hbcdump> ${HERMES_GITHUB_EXTRAS} .
|
|
|
|
|
COMMAND
|
|
|
|
|
${CMAKE_COMMAND} -E tar zcf ${HERMES_GITHUB_DIR}/${HERMES_CLI_GITHUB_FILE} .
|
|
|
|
|
)
|
2019-07-10 19:43:32 +03:00
|
|
|
|
2020-09-29 01:04:05 +03:00
|
|
|
add_custom_target(
|
|
|
|
|
github-cli-release
|
|
|
|
|
DEPENDS ${HERMES_GITHUB_DIR}/${HERMES_CLI_GITHUB_FILE})
|
|
|
|
|
endif()
|
2020-07-15 07:17:59 +03:00
|
|
|
|
2020-07-28 01:41:09 +03:00
|
|
|
set(HERMES_PKG_ROOT ${HERMES_GITHUB_DIR}/package-root)
|
|
|
|
|
set(HERMES_PKG_FRAMEWORK ${HERMES_PKG_ROOT}/destroot/Library/Frameworks/hermes.framework)
|
|
|
|
|
|
2020-07-15 07:17:59 +03:00
|
|
|
add_custom_target(
|
|
|
|
|
hermes-runtime-darwin-cocoapods-release
|
Add explicit option to build Apple dSYM (#296)
Summary:
Add `HERMES_BUILD_APPLE_DSYM` option to build a dSYM bundle for the libhermes target on Apple platforms.
This will work with any of the build types and is off by default.
Installing the tools with the install/strip target will ensure all tools and the runtime lib are stripped of debug symbols, but leaving the dSYM bundle in tact.
Pull Request resolved: https://github.com/facebook/hermes/pull/296
Test Plan:
### Build
```bash
./src/utils/build/configure.py --distribute --cmake-flags='-DHERMES_BUILD_APPLE_DSYM:BOOLEAN=true -DCMAKE_INSTALL_PREFIX:PATH=../destroot_release' build_release
cmake --build ./build_release
```
### Install without stripping
```bash
cmake --build ./build_release --target install
nm -a destroot_release/bin/hermesc | wc -l
27943
```
### Install with stripping
```bash
cmake --build ./build_release --target install/strip
nm -a destroot_release/bin/hermesc | wc -l
250
```
…and dSYM DWARF metadata is maintained:
```bash
dwarfdump --statistics destroot_release/Library/Frameworks/hermes.framework.dSYM
{"version":3,"file":"destroot_release/Library/Frameworks/hermes.framework.dSYM/Contents/Resources/DWARF/hermes","format":"Mach-O 64-bit x86-64","source functions":30305,"source functions with location":30302,"inlined functions":172725,"inlined funcs with abstract origins":172725,"unique source variables":79276,"source variables":353690,"variables with location":232195,"call site entries":186409,"scope bytes total":19161949,"scope bytes covered":10500176,"total function size":1763513,"total inlined function size":998375,"total formal params":300264,"formal params with source location":166067,"formal params with type":300264,"formal params with binary location":200407,"total vars":38809,"vars with source location":38385,"vars with type":38809,"vars with binary location":22161}
```
Reviewed By: tmikov
Differential Revision: D22576263
Pulled By: willholen
fbshipit-source-id: 2bda49e638d145ba5d029e77069d6adcc0b1dd8c
2020-07-17 00:04:10 +03:00
|
|
|
COMMAND
|
|
|
|
|
${CMAKE_COMMAND} --build . --target install/strip
|
2020-07-15 07:17:59 +03:00
|
|
|
COMMAND
|
2020-07-28 01:41:09 +03:00
|
|
|
mkdir -p ${HERMES_PKG_ROOT}/destroot/bin
|
|
|
|
|
COMMAND
|
|
|
|
|
cp ${CMAKE_INSTALL_PREFIX}/bin/hermesc ${HERMES_PKG_ROOT}/destroot/bin/
|
|
|
|
|
COMMAND
|
|
|
|
|
cp -R ${CMAKE_INSTALL_PREFIX}/Library ${HERMES_PKG_ROOT}/destroot/
|
2020-07-15 07:17:59 +03:00
|
|
|
COMMAND
|
2020-07-28 01:41:09 +03:00
|
|
|
cp -R ${CMAKE_INSTALL_PREFIX}/include ${HERMES_PKG_ROOT}/destroot/
|
2020-07-15 07:17:59 +03:00
|
|
|
COMMAND
|
2020-07-28 01:41:09 +03:00
|
|
|
cp ${CMAKE_CURRENT_SOURCE_DIR}/hermes.podspec ${CMAKE_CURRENT_SOURCE_DIR}/LICENSE ${HERMES_PKG_ROOT}
|
2020-07-15 07:17:59 +03:00
|
|
|
COMMAND
|
2020-07-28 01:41:09 +03:00
|
|
|
tar -C ${HERMES_PKG_ROOT}/ -czvf ${HERMES_GITHUB_DIR}/hermes-runtime-${HERMES_GITHUB_SYSTEM_NAME}-v${HERMES_RELEASE_VERSION}.tar.gz .
|
2020-09-11 06:05:45 +03:00
|
|
|
)
|
