5eef5cb9d5
Summary: There are a variety of Windows (MSVC) compiler warnings that fire when building Hermes. If we can fix them (or at least quiet them), we can get into a treat-warnings-as-errors state and stay clean moving forward. This diff fixes them all in the core Hermes code. (Sadly there are still warnings in many *test files* themselves, so I can't actually enable warnings-as-errors just yet) Reviewed By: jpporto Differential Revision: D41671449 fbshipit-source-id: faeda555f96a755f37b4b48e4a7a41d3faa51c57 |
||
---|---|---|
.. | ||
src | ||
CMakeLists.txt | ||
README.facebook | ||
UNLICENSE | ||
sanitize-blacklist.txt |
README.facebook
# Zip Library https://github.com/kuba--/zip Version: f72dce22bd25d10f8575ec54cf51bf5a5fdcb5ba Change this line in `miniz.h`: ``` #if MINIZ_X86_OR_X64_CPU ``` to ``` #if MINIZ_X86_OR_X64_CPU && !defined(HERMES_UBSAN) ``` Change this typedef in `zip.h`: ``` // 64-bit Windows is the only mainstream platform // where sizeof(long) != sizeof(void*) #ifdef _WIN64 typedef long long ssize_t; /* byte count or error */ #else typedef long ssize_t; /* byte count or error */ #endif ``` to ``` typedef intptr_t ssize_t; /* byte count or error */ ```