hermes-windows/external/zip
Brian Long 5eef5cb9d5 eliminate many windows warnings
Summary: There are a variety of Windows (MSVC) compiler warnings that fire when building Hermes. If we can fix them (or at least quiet them), we can get into a treat-warnings-as-errors state and stay clean moving forward. This diff fixes them all in the core Hermes code. (Sadly there are still warnings in many *test files* themselves, so I can't actually enable warnings-as-errors just yet)

Reviewed By: jpporto

Differential Revision: D41671449

fbshipit-source-id: faeda555f96a755f37b4b48e4a7a41d3faa51c57
2023-01-30 13:20:13 -08:00
..
src eliminate many windows warnings 2023-01-30 13:20:13 -08:00
CMakeLists.txt Use internal fork of LLVM 2020-02-06 00:34:00 -08:00
README.facebook Fix ssize_t conflict in 32 bit Windows 2021-07-08 10:53:14 -07:00
UNLICENSE Initial commit 2019-07-10 09:43:55 -07:00
sanitize-blacklist.txt Initial commit 2019-07-10 09:43:55 -07:00

README.facebook

# Zip Library
https://github.com/kuba--/zip
Version: f72dce22bd25d10f8575ec54cf51bf5a5fdcb5ba

Change this line in `miniz.h`:
```
#if MINIZ_X86_OR_X64_CPU
```
to
```
#if MINIZ_X86_OR_X64_CPU && !defined(HERMES_UBSAN)
```

Change this typedef in `zip.h`:
```
// 64-bit Windows is the only mainstream platform
// where sizeof(long) != sizeof(void*)
#ifdef _WIN64
typedef long long ssize_t; /* byte count or error */
#else
typedef long ssize_t; /* byte count or error */
#endif
```
to
```
typedef intptr_t ssize_t; /* byte count or error */
```