Use same RNG seed for TCP vs. QUIC random loss WAN tests. (#1533)

.azure/azure-pipelines.wanperf.yml

@@ -53,6 +53,10 @@ parameters:
   type: string
   displayName: Random Reorder Delta (ms)
   default: '0'
+- name: baseRandomSeed
+  type: string
+  displayName: Base Random Seed (hex string)
+  default: '""'
 - name: timeout
   type: string
   displayName: Timeout (min)
@@ -115,6 +119,7 @@ stages:
       randomLossDenominator: ${{ parameters.randomLossDenominator }}
       randomReorderDenominator: ${{ parameters.randomReorderDenominator }}
       reorderDelayDeltaMs: ${{ parameters.reorderDelayDeltaMs }}
+      baseRandomSeed: ${{ parameters.baseRandomSeed }}
       pacing: ${{ parameters.pacing }}
       timeout: ${{ parameters.timeout }}
       logProfile: ${{ parameters.logProfile }}

.azure/templates/run-wanperf.yml

@@ -19,6 +19,7 @@ parameters:
   randomLossDenominator: 0
   randomReorderDenominator: 0
   reorderDelayDeltaMs: 0
+  baseRandomSeed: '""'
   logProfile: 'None'
   extraArgs: ''
   timeout: 15
@@ -62,7 +63,7 @@ jobs:
     inputs:
       pwsh: true
       filePath: scripts/emulated-performance.ps1
-      arguments: -Protocol ${{ parameters.protocol }} -NumIterations ${{ parameters.iterations }} -BottleneckMbps ${{ parameters.rateMbps }} -BottleneckQueueRatio ${{ parameters.bottleneckQueueRatio }} -DurationMs ${{ parameters.durationMs }} -RttMs ${{ parameters.rttMs }} -Pacing ${{ parameters.pacing }} -RandomLossDenominator ${{ parameters.randomLossDenominator }} -RandomReorderDenominator ${{ parameters.randomReorderDenominator }} -ReorderDelayDeltaMs ${{ parameters.reorderDelayDeltaMs }} -LogProfile ${{ parameters.logProfile }} -Config ${{ parameters.config }} -Arch ${{ parameters.arch }} -Tls ${{ parameters.tls }} ${{ parameters.extraArgs }}
+      arguments: -Protocol ${{ parameters.protocol }} -NumIterations ${{ parameters.iterations }} -BottleneckMbps ${{ parameters.rateMbps }} -BottleneckQueueRatio ${{ parameters.bottleneckQueueRatio }} -DurationMs ${{ parameters.durationMs }} -RttMs ${{ parameters.rttMs }} -Pacing ${{ parameters.pacing }} -RandomLossDenominator ${{ parameters.randomLossDenominator }} -RandomReorderDenominator ${{ parameters.randomReorderDenominator }} -ReorderDelayDeltaMs ${{ parameters.reorderDelayDeltaMs }} -BaseRandomSeed ${{ parameters.baseRandomSeed }} -LogProfile ${{ parameters.logProfile }} -Config ${{ parameters.config }} -Arch ${{ parameters.arch }} -Tls ${{ parameters.tls }} ${{ parameters.extraArgs }}
 
   - task: CopyFiles@2
     displayName: Move Performance Results

scripts/emulated-performance.ps1

@@ -34,6 +34,9 @@ be in the current directory.
 .PARAMETER ReorderDelayDeltaMs
     The extra delay applied to any reordered packets in the emulated network.
 
+.PARAMETER BaseRandomSeed
+    Base seed value for the DuoNic RNG.
+
 .PARAMETER DurationMs
     The duration(s) of each test run over the emulated network.
 
@@ -79,6 +82,9 @@ param (
     [Parameter(Mandatory = $false)]
     [Int32[]]$ReorderDelayDeltaMs = 0,
 
+    [Parameter(Mandatory = $false)]
+    [string]$BaseRandomSeed = "",
+
     [Parameter(Mandatory = $false)]
     [Int32[]]$DurationMs = 10000,
 
@@ -222,6 +228,9 @@ function Get-LatestWanTestResult([string]$Branch, [string]$CommitHash) {
     }
 }
 
+# Root directory of the project.
+$RootDir = Split-Path $PSScriptRoot -Parent
+
 # See if we are an AZP PR
 $PrBranchName = $env:SYSTEM_PULLREQUEST_TARGETBRANCH
 if ([string]::IsNullOrWhiteSpace($PrBranchName)) {
@@ -255,9 +264,6 @@ if ("" -eq $Tls) {
     }
 }
 
-# Root directory of the project.
-$RootDir = Split-Path $PSScriptRoot -Parent
-
 # Script for controlling loggings.
 $LogScript = Join-Path $RootDir "scripts" "log.ps1"
 
@@ -276,6 +282,17 @@ if ($LogProfile -ne "None") {
 $Platform = $IsWindows ? "windows" : "linux"
 $PlatformName = (($IsWindows ? "Windows" : "Linux") + "_$($Arch)_$($Tls)")
 
+if ($BaseRandomSeed -eq "") {
+    for ($i = 0; $i -lt 3; $i++) {
+        $BaseRandomSeed += $(Get-Random).ToString('x8')
+    }
+    $BaseRandomSeed += $(Get-Random).ToString('x8').Substring(0,6)
+    # This gives 15 bytes of random seed, and the last byte will be
+    # the iteration count.
+}
+
+Write-Host "BaseRandomSeed: $($BaseRandomSeed)"
+
 # Path to the secnetperf exectuable.
 $ExeName = $IsWindows ? "secnetperf.exe" : "secnetperf"
 $SecNetPerf = Join-Path $RootDir "artifacts" "bin" $Platform "$($Arch)_$($Config)_$($Tls)" $ExeName
@@ -359,9 +376,6 @@ foreach ($ThisReorderDelayDeltaMs in $ReorderDelayDeltaMs) {
     Set-NetAdapterAdvancedProperty duo? -DisplayName RandomLossDenominator -RegistryValue $ThisRandomLossDenominator -NoRestart
     Set-NetAdapterAdvancedProperty duo? -DisplayName RandomReorderDenominator -RegistryValue $ThisRandomReorderDenominator -NoRestart
     Set-NetAdapterAdvancedProperty duo? -DisplayName ReorderDelayDeltaMs -RegistryValue $ThisReorderDelayDeltaMs -NoRestart
-    Write-Debug "Restarting NIC"
-    Restart-NetAdapter duo?
-    Start-Sleep 5 # (wait for duonic to restart)
 
     # Loop over all the test configurations.
     foreach ($ThisProtocol in $Protocol) {
@@ -380,6 +394,9 @@ foreach ($ThisReorderDelayDeltaMs in $ReorderDelayDeltaMs) {
         Write-Debug "Run upload test: Duration=$ThisDurationMs ms, Pacing=$ThisPacing"
         for ($i = 0; $i -lt $NumIterations; $i++) {
 
+            $RandomSeed = $BaseRandomSeed + $i.ToString('x2').Substring(0,2)
+            Set-NetAdapterAdvancedProperty duo? -DisplayName RandomSeed -RegistryValue $RandomSeed -NoRestart
+
             if ($LogProfile -ne "None") {
                 try {
                     & $LogScript -Start -Profile $LogProfile | Out-Null
@@ -388,6 +405,10 @@ foreach ($ThisReorderDelayDeltaMs in $ReorderDelayDeltaMs) {
                 }
             }
 
+            Write-Debug "Restarting NIC"
+            Restart-NetAdapter duo?
+            Start-Sleep 5 # (wait for duonic to restart)
+
             # Run the throughput upload test with the current configuration.
             Write-Debug "Run upload test: Iteration=$($i + 1)"