From 35f819aa1dda6a5071401935c7b16f63aced62a9 Mon Sep 17 00:00:00 2001 From: Nick Banks Date: Mon, 18 Mar 2024 07:51:20 -0400 Subject: [PATCH] Skip Unit Tests in Code Coverage (#4199) --- .github/workflows/code-coverage.yml | 2 +- src/inc/msquic.hpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml index 0aea0a0ac..75abcefe3 100644 --- a/.github/workflows/code-coverage.yml +++ b/.github/workflows/code-coverage.yml @@ -74,7 +74,7 @@ jobs: shell: pwsh timeout-minutes: 120 continue-on-error: true - run: scripts/test.ps1 -NoProgress -IsolationMode Batch -CodeCoverage -Config ${{ matrix.vec.config }} -Arch ${{ matrix.vec.arch }} -Tls ${{ matrix.vec.tls }} -LogProfile Full.Light ${{ matrix.vec.xdp }} ${{ matrix.vec.qtip }} + run: scripts/test.ps1 -NoProgress -IsolationMode Batch -SkipUnitTests -CodeCoverage -Config ${{ matrix.vec.config }} -Arch ${{ matrix.vec.arch }} -Tls ${{ matrix.vec.tls }} -LogProfile Full.Light ${{ matrix.vec.xdp }} ${{ matrix.vec.qtip }} - name: Upload Results uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 with: diff --git a/src/inc/msquic.hpp b/src/inc/msquic.hpp index 3162d81db..04e6ec4d0 100644 --- a/src/inc/msquic.hpp +++ b/src/inc/msquic.hpp @@ -240,7 +240,9 @@ public: Config.Name = Name; Config.Callback = WatchdogThreadCallback; Config.Context = this; - CXPLAT_FRE_ASSERT(QUIC_SUCCEEDED(WatchdogThread.Create(&Config))); + if (WatchdogTimeoutMs != UINT32_MAX) { + CXPLAT_FRE_ASSERT(QUIC_SUCCEEDED(WatchdogThread.Create(&Config))); + } } ~CxPlatWatchdog() noexcept { ShutdownEvent.Set();