From eb3155b62ff422e3dddd201bcb4f8175d0270bd7 Mon Sep 17 00:00:00 2001
From: Joey Vagedes <joeyvagedes@microsoft.com>
Date: Wed, 13 Mar 2024 17:18:41 -0700
Subject: [PATCH] .github/workflows/publish-qemu-bin.yml: reliability updates
 (#880)

## Description

Updates release pipeline for the qemu binary to release qemu v7.2.0 as a
external dependency and to also provide the following roms:

- efi-e1000e.rom
- efi-virtio.rom

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Verified Terminal was not in an invalid state after exiting qemu, and
that the above roms were successfully found at runtime.

## Integration Instructions

Perform a release and update the qemu external dependency inside
mu_tiano_platforms
---
 .github/publish-qemu-config.yml        | 4 ++--
 .github/workflows/publish-qemu-bin.yml | 4 ++++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/publish-qemu-config.yml b/.github/publish-qemu-config.yml
index c072c420..5f8a174f 100644
--- a/.github/publish-qemu-config.yml
+++ b/.github/publish-qemu-config.yml
@@ -1,4 +1,4 @@
 {
-    "windows": "2023.7.25",
-    "linux": "v8.0.0"
+    "windows": "2022.12.30",
+    "linux": "v7.2.0"
 }
diff --git a/.github/workflows/publish-qemu-bin.yml b/.github/workflows/publish-qemu-bin.yml
index 73e765c7..f7f06496 100644
--- a/.github/workflows/publish-qemu-bin.yml
+++ b/.github/workflows/publish-qemu-bin.yml
@@ -40,6 +40,8 @@ jobs:
         cp "C:\Program Files\qemu\qemu-system-x86_64.exe" temp
         cp "C:\Program Files\qemu\qemu-system-aarch64.exe" temp
         cp "C:\Program Files\qemu\share\efi-e1000.rom" temp\share
+        cp "C:\Program Files\qemu\share\efi-e1000e.rom" temp\share
+        cp "C:\Program Files\qemu\share\efi-virtio.rom" temp\share
         cp "C:\Program Files\qemu\share\kvmvapic.bin" temp\share
         cp "C:\Program Files\qemu\share\vgabios-cirrus.bin" temp\share
         cp "C:\Program Files\qemu\share\vgabios-stdvga.bin" temp\share
@@ -101,6 +103,8 @@ jobs:
         mkdir -p temp/share
         cp qemu/bin/qemu-system-x86_64 qemu/bin/qemu-system-aarch64 temp
         cp qemu/bin/qemu-bundle/usr/local/share/qemu/efi-e1000.rom temp/share
+        cp qemu/bin/qemu-bundle/usr/local/share/qemu/efi-e1000e.rom temp/share
+        cp qemu/bin/qemu-bundle/usr/local/share/qemu/efi-virtio.rom temp/share
         cp qemu/bin/qemu-bundle/usr/local/share/qemu/vgabios-cirrus.bin temp/share
         cp qemu/bin/qemu-bundle/usr/local/share/qemu/vgabios-stdvga.bin temp/share
         cp qemu/bin/qemu-bundle/usr/local/share/qemu/kvmvapic.bin temp/share