onnxruntime/csharp
Scott McKay 8ff41aea09
Fix 4 more bad delegates missing the attribute that cause iOS AOT errors at runtime (#18390)
### Description
<!-- Describe your changes. -->
Fix bad delegates.
Add script to detect mismatch, and run in CI and when creating nuget
package.

Ignore whitespace when looking at the diff to the .cs file as
clang-format ran.

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
#18363
2023-11-14 14:00:21 +10:00
..
ApiDocs Add C# API documentation for training (and some other changes) (#15935) 2023-05-16 03:15:24 -07:00
sample [C#] Rename unreleased API, add utilities (#16806) 2023-08-02 10:06:42 -07:00
src Fix 4 more bad delegates missing the attribute that cause iOS AOT errors at runtime (#18390) 2023-11-14 14:00:21 +10:00
test [On-Device Training] Expose Parameters through the Training API (#17364) 2023-09-25 20:03:24 -07:00
testdata Format all python files under onnxruntime with black and isort (#11324) 2022-04-26 09:35:16 -07:00
tools Fix 4 more bad delegates missing the attribute that cause iOS AOT errors at runtime (#18390) 2023-11-14 14:00:21 +10:00
.clang-format Add MAUI test app that can be used to test model loading and performance (#16658) 2023-07-18 08:21:18 +10:00
Directory.Build.props.in Patch Protobuf and ONNX's cmake files and enforce BinSkim check (#13694) 2022-11-18 10:09:47 -08:00
NuGet.CSharp.config Various fixes to the CSharp setup (#15782) 2023-05-05 14:27:30 +10:00
OnnxRuntime.CSharp.proj Fix 4 more bad delegates missing the attribute that cause iOS AOT errors at runtime (#18390) 2023-11-14 14:00:21 +10:00
OnnxRuntime.CSharp.sln Add csharp docfx (#12596) 2022-08-25 09:51:32 -05:00
OnnxRuntime.DesktopOnly.CSharp.sln Limit inclusion of Xamarin mobile target frameworks. (#9834) 2021-11-23 11:29:53 +10:00
OnnxRuntime.snk Copy System.Numerics.Tensors sources from dotnet/corefx into onnxruntime (#1605) 2019-08-15 17:28:47 -07:00
readme.md Basic CSharp packaging support for ROCm EP (#15535) 2023-05-16 07:27:38 +08:00
readme.txt Limit inclusion of Xamarin mobile target frameworks. (#9834) 2021-11-23 11:29:53 +10:00

readme.md

ORT C# Managed Library

The solution files here are used to produce nuget packages for the C# bindings.

Note that the project naming is currently confusing and needs updating.

  • The Microsoft.ML.OnnxRuntime project produces the Microsoft.ML.OnnxRuntime.Managed nuget package.
  • The Microsoft.ML.OnnxRuntime nuget package contains the native (i.e. C++) code for various platforms.

Solution files

The main solution file is OnnxRuntime.CSharp.sln. This includes desktop and Xamarin mobile projects. OnnxRuntime.DesktopOnly.CSharp.sln is a copy of that with all the mobile projects removed. This is due to there being no way to selectively exclude a csproj from the sln if Xamarin isn't available.

If changes are required, either update the main solution first and copy the relevant changes across, or copy the entire file and remove the mobile projects (anything with iOS, Android or Droid in the name).

Development setup:

Requirements:

Windows

NOTE: The usage of this solution is primarily for ORT developers creating the managed Microsoft.ML.OnnxRuntime.Managed nuget package. Due to that, the requirements are quite specific.

Visual Studio 2022 v17.2.4 or later, with Xamarin workloads

There's no good way to use Visual Studio 2022 17.3 Preview in a CI, so we currently have to build pre-.net6 targets using VS, and .net6 targets using dotnet. We can't build them all using dotnet as the xamarin targets require msbuild. We can't package them using dotnet as that also requires msbuild.

Once the official VS 2022 release supports .net6 and is available in the CI we can revert to the original simple setup of building everything using msbuild.

To test packaging locally you will also need nuget.exe. Download from https://www.nuget.org/downloads. Put in a folder (e.g. C:\Program Files (x86)\NuGet). Add that folder to your PATH.

Linux

  1. Install .Net SDK.
  2. Install Mono.
    wget http://download.mono-project.com/repo/xamarin.gpg && sudo apt-key add xamarin.gpg && rm xamarin.gpg
    echo "deb https://download.mono-project.com/repo/ubuntu stable-bionic main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list
    sudo apt update -y && apt install -y mono-devel
    
  3. Install nupkg.exe
    wget https://dist.nuget.org/win-x86-commandline/latest/nuget.exe && sudo mv nuget.exe /usr/local/bin/nuget.exe
    echo 'mono /usr/local/bin/nuget.exe $@' | sudo tee /usr/local/bin/nuget
    chmod a+x /usr/local/bin/nuget
    

Magic incantations to build the nuget managed package locally:

Windows

If we're starting with VS 2022 17.2.4 we should have dotnet sdk 6.0.301

Make sure all the required workloads are installed dotnet workload install android ios maccatalyst macos - original example from here: - dotnet workload install android ios maccatalyst macos maui --source https://aka.ms/dotnet6/nuget/index.json --source https://api.nuget.org/v3/index.json - don't need 'maui' in this list until we update the sample/test apps - didn't seem to need --source arg/s for local build. YMMV.

Build pre-net6 targets msbuild -t:restore .\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj -p:SelectedTargets=PreNet6 msbuild -t:build .\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj -p:SelectedTargets=PreNet6

Need to run msbuild twice - once to restore which creates some json configs that are needed like Microsoft.ML.OnnxRuntime\obj\project.assets.json, and once to build using the configs.

Build net6 targets dotnet build .\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj -p:SelectedTargets=Net6

The dotnet build does the restore internally.

Create project.assets.json in obj dir with all targets so the nuget package creation includes them all msbuild -t:restore .\src\Microsoft.ML.OnnxRuntime\Microsoft.ML.OnnxRuntime.csproj -p:SelectedTargets=All

Create nuget package msbuild .\OnnxRuntime.CSharp.proj -t:CreatePackage -p:OrtPackageId=Microsoft.ML.OnnxRuntime -p:Configuration=Debug -p:Platform="Any CPU"

Linux

For example, to build a CUDA GPU package, just run:

./build.sh \
  --config="Release" \
  --cmake_generator Ninja \
  --use_cuda \
    --cuda_home=/usr/local/cuda \
    --cudnn_home=/usr \
  --build_nuget \
  --msbuild_extra_options \
    /p:SelectedTargets=Net6 \
    /p:Net6Targets=net6.0 \
    /p:TargetFrameworks=netstandard2.0 \
    /p:IsLinuxBuild=true

Note: to build a pure CPU development package, you need to add /p:OrtPackageId="Microsoft.ML.OnnxRuntime" to --msbuild_extra_options. Otherwise, it will try to create Xamarin mobile targets which may not be properly configured on your devbox.

A .nupkg file will be produced at you build root, say, build/Release.

To consume the package, in your .net project,

nuget add <path/to/packages.nuget> -Source ./packages/
dotnet add package microsoft.ml.onnxruntime.managed -s ./packages --prerelease
dotnet add package microsoft.ml.onnxruntime.gpu -s ./packages --prerelease