* Remove hardcoded references to microsoft (#6)
* add config to some more mail options
Co-authored-by: Moritz Fuchs <moritz.fuchs@sap.com>
Co-authored-by: Tobias Gabriel <tobias.gabriel@sap.com>
Updates the open source project to reflect the recent updates
around continuing to make it easier to build in paralell and have
company-specific updates without impacting the upstream as much.
- Improved new repository lockdown experience
- Supports swapping description and website URL for repos temporarily until approval
- Supports an initial README commit directing people to the setup experience, if there are no commits yet
- Directly created repos become private immediately but retain access for the initial creator of the repo with read permission
- Removes new repository branch rename feature (GitHub natively supports org-level and enterprise-level custom defaults now)
- Removes 'uuid' dependency to favor newer Node LTS 14+ crypto.randomUUID
- App and job configuration object replaces "treatGitHubAppAsBackground" with "enableAllGitHubApps"
- Table encryption bug fix when pulling from key vault
- Chore: updates NPM dependencies
- Removes antiquated Azure Storage and table SDKs
- Removes dependency on painless-config-resolver (which is now inline inside the project and adopts the latest Azure SDK for KeyVault)
- Adds company-specific unlink and link mail template overrides
- Adds new unlink notification mail to people who remove themselves, or are removed
- Updates more legacy functions from callbacks to more modern equivalents
- Removes unused reports "data lake" storage methods
- Removes moment timezone library
- System administrator data can now alternatively come from security groups instead of hard-coded configuration
Breaking changes
- Removes painless-config support. .env and environment/container env methods only. If you have a JSON env file, update it to a .env-compatible format for local development use.
- Changes JSON paging APIs to be zero-based indexes
- Additional optional security app configuration
- Fixes a minor configuration issue
- Adds a more robust "RepositoryEntity" that is not used in the site, but by jobs or data systems
- Updated deps
- Graph provider adds a "get direct reports" method
Removing explicit casts from req.app.settings.providers and using
a function.
Switching from Mocha (which was mostly unused) to Jest.
Moving around type definitions and interfaces in a big way to try
and cleanup some legacy.
This is a set of changes that is still stabalizing. Code churn around modernization
could impact company-specific implementations.
interim refactoring as part of a GitHub Enterprise prototype. please avoid using or extending or open an issue in the repo if you are to discuss what should stay vs get yanked.
- introduces a temporary OperationsCore class and a nearly-empty typed interface for operations
- these types will reduce or be removed once the prototype is validated
- "capabilities" allow for partial implementation of operations methods in the prototype
- custom mail provider
- additional view properties or recipients for new repos
- additional non-client API routes
- custom view names in certain places
- ability to process firehose events optionally in a separate codepath
- removes Microsoft-specific mail provider from the project
- fixes a startup race condition
- more interfaces and types exported down the tree to reduce import statements
- additional insights and reduced error logging for valid not found scenarios
- graph manager removes old callback code and interfaces have minor **breaking renames** as a result
- moves some email-sending functions into independent files to reduce core class line count
- ignored catches replaced with telemetry more consistently (partial)
- graph provider adds optional caching (note: this is not yet stable)
- webhook firehose will only attempt deleting messages once
- latest Octokit versions
- uses reusable functions throughout GitHub API calls for max age seconds, background refresh, page size variables
- fixes a bug around app header selection for cross-organization calls
- attempts to use GitHub App authentication instead of central operations token in more places
- supports alternate GitHub REST API locations for app authentication and the API itself
- new GitHub APIs integrated into business classes: get repository issues
- removes request module family, adopting axios
This significant pull request patches the open source project with a number
of updates from inside Microsoft as part of connecting an automated publishing
process to keep the public version up-to-date and buildable.
We are also removing Microsoft-specific endpoints and APIs when easy enough to
do, and adding a "company-specific" extension model to try as we go about this.
- Removes legacy "Witness Redis" code that was a Microsoft-internal thing
- Refactors Mail Address Provider for function signatures with a Promise, no callbacks
- Refactors Microsoft Mail Address Provider to use the Graph Provider for mail lookup instead of the legacy Redis system
- Minor chores on updating some imports, default export module functions
- Web server listen routine happens sooner during startup to better land Kubernetes readiness and liveness probes
- Replaces extended operations mail with dedicated, optional notification email addresses for new repos, new links, and related operations
- Updates to newer libraries including Octokit v18
During the month of May and June, we forked this application internally
as part of a specific set of temporary changes. To converge once again
with the open source version and make it easier to collaborate with others,
this brings the latest changes up.
There is a need to refactor and feature flag the service account piece into
the newer experience as new debt.
Refactoring of the Postgres and EMP (entity metadata provider) interface
to make it more performant, moving beyond the original key-value store
approach for entities and allowing for "native" columns that can have
solid indexes on the columns.
The goal of this integration is to be able to create indexes on the
date fields for open source contributions. Previously, storing this
data inside of Postgres JSON columns made casting difficult or slow
to compute when querying for these values.
Also begins to ship queries away from a central cross-EMP query enum
into compartmenatlized entities.
This introduces a new opt-in (feature flag) capability to reduce the
amount of manual organization operations that are required for
common scenarios.
For a relatively small GitHub team size (configurable, default to
around 15 people), this allows people to self-service "upgrade"
themselves to be a team maintainer if the team does not have
many maintainers.
The # of maintainers that are supported by default for this feature
to light up is zero (0) or 1... since we recommend that every
team have at least 2 maintainers.
If a manager is known for an employee, we will also notify
the manager via a carbon copy on e-mails related to new repos,
locked forks, or newly created repos that still need classification.
As a quick change, this does not add a feature flag to enable or disable
this; however, if a manager is not known via the corporate contacts or
cached employee information system, there will be no error.
Chore: cleaning up app startup routines
- Modernizing with promises instead of callbacks
- Cleans up TypeScript interfaces for the app
- Moving to v2 of `painless-config-resolver`, reducing package count
- Reduces redundant startup code
- Introduces job object and job success return values, simplifies insights reporting when enabled
- Consistent timeout scheme for jobs
- chore: the root app is now a module
- updated election implementation for FOSS Fund
- fixes a null ref in the corporate contact provider after a timeout
- terminates the `reports` job quickly for now (the job remains broken)
- adds a new configuration setting for an election manager e-mail contact
- app insights should filter out HTTP 404 API responses which are technically a success
- updated vote displays
- updated script for 2nd mail campaign
Features
- Team pages now encourage native GitHub.com use for management
- Adding vote capabilities for FOSS Fund (a specialized feature only)
Bug fixes
- Fix for GitHub REST API request endpoints using `requestAsPost`
Chores
- Removing async library
- Cleaner throttle use through a newer `throat` library version and removing confusing typings
- Removes dead code
- Entity metadata providers are moving to a decoupled query and type system vs declarative shared enum sets
- Firehose code is now using await/async and staggers logical threads evenly
- Newer versions of all core dependencies
- More routes imported as modules instead of through `require`
- Enables GitHub App-based server-to-server communication
- Enables dynamic (database-backed) organization setting configuration
- QueryCache system, when paired with a Postgres database and GitHub App webhooks keeps teams, repo lists, etc. up-to-date more efficiently than the older GitHub REST API-based method
- Various bug fixes
- Entities (links, join requests, repo metadata) refactored
- Entities can be stored in Postgres, Azure Table, or memory
- Introduces a quickstart memory provider mode
- Evolution of more classes and methods to ES6, await/async, TypeScript typings
- Updates of package versions
Major updates to the application, including some minor breaking changes.
The public updates (that make it less Microsoft-specific) are still in
development; this represents trying to get it ready for updates.
Jeff Wilcox
Nick Schonning
mofury
Jeff Wilcox
Jeff Wilcox
Jeff Wilcox
Roman Fritsch