From 06c8881dad4199bca84ed7445a612ef748c53a24 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Fri, 6 Nov 2020 15:08:03 -0800 Subject: [PATCH] browser(firefox): fix videoSessionId (#4374) PRIx8 produced "%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx%hx", so video session ids were clashing between pages, and popup videos did not work. --- browser_patches/firefox/BUILD_NUMBER | 4 ++-- .../firefox/juggler/screencast/nsScreencastService.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/browser_patches/firefox/BUILD_NUMBER b/browser_patches/firefox/BUILD_NUMBER index d3dc8cd47c..b864c6fe59 100644 --- a/browser_patches/firefox/BUILD_NUMBER +++ b/browser_patches/firefox/BUILD_NUMBER @@ -1,2 +1,2 @@ -1203 -Changed: lushnikov@chromium.org Thu Nov 5 17:39:41 PST 2020 +1204 +Changed: dgozman@gmail.com Fri Nov 6 14:37:05 PST 2020 diff --git a/browser_patches/firefox/juggler/screencast/nsScreencastService.cpp b/browser_patches/firefox/juggler/screencast/nsScreencastService.cpp index 7cd810e08d..36e4c69e4d 100644 --- a/browser_patches/firefox/juggler/screencast/nsScreencastService.cpp +++ b/browser_patches/firefox/juggler/screencast/nsScreencastService.cpp @@ -73,7 +73,7 @@ nsresult generateUid(nsString& uid) { NS_ENSURE_SUCCESS(rv, rv); for (int i = 0; i < kLen; i++) { - uid.AppendPrintf("%" PRIx8, buffer[i]); + uid.AppendPrintf("%02x", buffer[i]); } free(buffer); return rv;