From 45e581bcbcef5f242265e7326d3d05d1c1956b29 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Sun, 14 Aug 2022 23:02:30 -0700 Subject: [PATCH] devops: fix firefox builds (#16530) Turns out Firefox mach does not respect `DEBIAN_FRONTEND=noninteractive` command and insists on interactive input for the mozbuild folder creation. Pre-creation of the folder avoid this codepath. --- browser_patches/docker/firefox-beta/debian-11.dockerfile | 1 + browser_patches/docker/firefox-beta/ubuntu-18.04.dockerfile | 1 + .../docker/firefox-beta/ubuntu-20.04-arm64.dockerfile | 1 + browser_patches/docker/firefox-beta/ubuntu-20.04.dockerfile | 1 + .../docker/firefox-beta/ubuntu-22.04-arm64.dockerfile | 1 + browser_patches/docker/firefox-beta/ubuntu-22.04.dockerfile | 1 + browser_patches/docker/firefox/debian-11.dockerfile | 1 + browser_patches/docker/firefox/ubuntu-18.04.dockerfile | 1 + browser_patches/docker/firefox/ubuntu-20.04-arm64.dockerfile | 1 + browser_patches/docker/firefox/ubuntu-20.04.dockerfile | 1 + browser_patches/docker/firefox/ubuntu-22.04-arm64.dockerfile | 1 + browser_patches/docker/firefox/ubuntu-22.04.dockerfile | 1 + 12 files changed, 12 insertions(+) diff --git a/browser_patches/docker/firefox-beta/debian-11.dockerfile b/browser_patches/docker/firefox-beta/debian-11.dockerfile index 034db787a7..714e0f3860 100644 --- a/browser_patches/docker/firefox-beta/debian-11.dockerfile +++ b/browser_patches/docker/firefox-beta/debian-11.dockerfile @@ -46,6 +46,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox-beta/ubuntu-18.04.dockerfile b/browser_patches/docker/firefox-beta/ubuntu-18.04.dockerfile index 2ff837ead5..b329797466 100644 --- a/browser_patches/docker/firefox-beta/ubuntu-18.04.dockerfile +++ b/browser_patches/docker/firefox-beta/ubuntu-18.04.dockerfile @@ -52,6 +52,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox-beta/ubuntu-20.04-arm64.dockerfile b/browser_patches/docker/firefox-beta/ubuntu-20.04-arm64.dockerfile index fd977444fe..8528f52ac2 100644 --- a/browser_patches/docker/firefox-beta/ubuntu-20.04-arm64.dockerfile +++ b/browser_patches/docker/firefox-beta/ubuntu-20.04-arm64.dockerfile @@ -54,6 +54,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox-beta/ubuntu-20.04.dockerfile b/browser_patches/docker/firefox-beta/ubuntu-20.04.dockerfile index c964549910..d6dcbab630 100644 --- a/browser_patches/docker/firefox-beta/ubuntu-20.04.dockerfile +++ b/browser_patches/docker/firefox-beta/ubuntu-20.04.dockerfile @@ -46,6 +46,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox-beta/ubuntu-22.04-arm64.dockerfile b/browser_patches/docker/firefox-beta/ubuntu-22.04-arm64.dockerfile index 71e00ace7c..768e956b09 100644 --- a/browser_patches/docker/firefox-beta/ubuntu-22.04-arm64.dockerfile +++ b/browser_patches/docker/firefox-beta/ubuntu-22.04-arm64.dockerfile @@ -54,6 +54,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox-beta/ubuntu-22.04.dockerfile b/browser_patches/docker/firefox-beta/ubuntu-22.04.dockerfile index f3fd4019b3..348ef04af3 100644 --- a/browser_patches/docker/firefox-beta/ubuntu-22.04.dockerfile +++ b/browser_patches/docker/firefox-beta/ubuntu-22.04.dockerfile @@ -46,6 +46,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox/debian-11.dockerfile b/browser_patches/docker/firefox/debian-11.dockerfile index 034db787a7..714e0f3860 100644 --- a/browser_patches/docker/firefox/debian-11.dockerfile +++ b/browser_patches/docker/firefox/debian-11.dockerfile @@ -46,6 +46,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox/ubuntu-18.04.dockerfile b/browser_patches/docker/firefox/ubuntu-18.04.dockerfile index 2ff837ead5..b329797466 100644 --- a/browser_patches/docker/firefox/ubuntu-18.04.dockerfile +++ b/browser_patches/docker/firefox/ubuntu-18.04.dockerfile @@ -52,6 +52,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox/ubuntu-20.04-arm64.dockerfile b/browser_patches/docker/firefox/ubuntu-20.04-arm64.dockerfile index fd977444fe..8528f52ac2 100644 --- a/browser_patches/docker/firefox/ubuntu-20.04-arm64.dockerfile +++ b/browser_patches/docker/firefox/ubuntu-20.04-arm64.dockerfile @@ -54,6 +54,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox/ubuntu-20.04.dockerfile b/browser_patches/docker/firefox/ubuntu-20.04.dockerfile index c964549910..d6dcbab630 100644 --- a/browser_patches/docker/firefox/ubuntu-20.04.dockerfile +++ b/browser_patches/docker/firefox/ubuntu-20.04.dockerfile @@ -46,6 +46,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox/ubuntu-22.04-arm64.dockerfile b/browser_patches/docker/firefox/ubuntu-22.04-arm64.dockerfile index 71e00ace7c..768e956b09 100644 --- a/browser_patches/docker/firefox/ubuntu-22.04-arm64.dockerfile +++ b/browser_patches/docker/firefox/ubuntu-22.04-arm64.dockerfile @@ -54,6 +54,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright diff --git a/browser_patches/docker/firefox/ubuntu-22.04.dockerfile b/browser_patches/docker/firefox/ubuntu-22.04.dockerfile index f3fd4019b3..348ef04af3 100644 --- a/browser_patches/docker/firefox/ubuntu-22.04.dockerfile +++ b/browser_patches/docker/firefox/ubuntu-22.04.dockerfile @@ -46,6 +46,7 @@ USER pwuser RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y ENV PATH="${PATH}:/home/pwuser/.cargo/bin" +RUN mkdir -p /home/pwuser/.mozbuild RUN cd /home/pwuser && git clone --depth=1 https://github.com/microsoft/playwright WORKDIR /home/pwuser/playwright