From e8419f85b69e069a0d3f51a8646c5a0acbb3fb51 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Mon, 30 Nov 2020 20:05:15 -0800 Subject: [PATCH] browser(firefox): support alertCheck and confirmCheck dialogs (#4553) These are shown with "prevent this page from showing more dialogs" checkbox. --- browser_patches/firefox/BUILD_NUMBER | 4 ++-- browser_patches/firefox/juggler/TargetRegistry.js | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/browser_patches/firefox/BUILD_NUMBER b/browser_patches/firefox/BUILD_NUMBER index 716ac56df3..2048c6e22c 100644 --- a/browser_patches/firefox/BUILD_NUMBER +++ b/browser_patches/firefox/BUILD_NUMBER @@ -1,2 +1,2 @@ -1216 -Changed: lushnikov@chromium.org Mon 30 Nov 2020 09:59:07 AM PST +1217 +Changed: dgozman@gmail.com Mon Nov 30 18:45:31 PST 2020 diff --git a/browser_patches/firefox/juggler/TargetRegistry.js b/browser_patches/firefox/juggler/TargetRegistry.js index ce6ac64f95..fe5e09b582 100644 --- a/browser_patches/firefox/juggler/TargetRegistry.js +++ b/browser_patches/firefox/juggler/TargetRegistry.js @@ -773,9 +773,13 @@ class Dialog { const type = prompt.args.promptType; switch (type) { case 'alert': + case 'alertCheck': + return new Dialog(prompt, 'alert'); case 'prompt': + return new Dialog(prompt, 'prompt'); case 'confirm': - return new Dialog(prompt, type); + case 'confirmCheck': + return new Dialog(prompt, 'confirm'); case 'confirmEx': return new Dialog(prompt, 'beforeunload'); default: