From f72d4009529e79953dd12e02c5dd715ad9d96ffd Mon Sep 17 00:00:00 2001 From: chimurai <655241+chimurai@users.noreply.github.com> Date: Mon, 30 Jan 2023 09:53:28 +0100 Subject: [PATCH] chore: fix typos (#20473) --- browser_patches/winldd/README.md | 4 ++-- docs/src/accessibility-testing-java.md | 4 ++-- docs/src/accessibility-testing-js.md | 2 +- docs/src/api/class-locator.md | 4 ++-- docs/src/codegen.md | 2 +- docs/src/library-js.md | 2 +- docs/src/mock.md | 10 +++++----- docs/src/other-locators.md | 8 ++++---- .../service-workers-experimental-network-events-js.md | 4 ++-- docs/src/test-api/class-test.md | 2 +- docs/src/test-configuration-js.md | 2 +- docs/src/test-parameterize-js.md | 2 +- docs/src/test-reporters-js.md | 2 +- packages/playwright-core/types/types.d.ts | 4 ++-- packages/playwright-test/types/test.d.ts | 2 +- tests/assets/axe-core/README.md | 2 +- tests/assets/wpt/README.md | 2 +- .../fixtures/should-match/crbug-919955/README.md | 4 +--- .../should-match/tiny-antialiasing-sample/README.md | 2 +- tests/library/defaultbrowsercontext-1.spec.ts | 2 +- tests/library/favicon.spec.ts | 2 +- tests/library/screenshot.spec.ts | 2 +- tests/library/tap.spec.ts | 4 ++-- tests/page/page-evaluate.spec.ts | 6 +++--- tests/page/page-event-network.spec.ts | 2 +- tests/page/selectors-react.spec.ts | 4 ++-- tests/playwright-test/config.spec.ts | 2 +- tests/playwright-test/reporter-junit.spec.ts | 4 ++-- tests/stress/heap.spec.ts | 2 +- 29 files changed, 46 insertions(+), 48 deletions(-) diff --git a/browser_patches/winldd/README.md b/browser_patches/winldd/README.md index 69c7ad0e4e..d953b130d5 100644 --- a/browser_patches/winldd/README.md +++ b/browser_patches/winldd/README.md @@ -1,7 +1,7 @@ # Tool for printing .exe and .dll dependencies on Windows This is similar to `ldd` on linux in that loads specified files and tries to -resolve all DLLs referenced by it, printing in the formar ` => | "no found"` +resolve all DLLs referenced by it, printing in the format ` => | "no found"` To minimize dependencies we link all C runtime libraries statically, there is still one dynamic dependency on `dbghelp.dll` which is supposed to be preinstalled on all Windows machines. @@ -9,4 +9,4 @@ on all Windows machines. ## Build instructions Open `PrintDeps.sln` solution in Visual Studio 2019 and build `x64/Release` configuration. We -currently commit output binary into `bin/PrintDeps.exe` and bundle it in every npm. \ No newline at end of file +currently commit output binary into `bin/PrintDeps.exe` and bundle it in every npm. diff --git a/docs/src/accessibility-testing-java.md b/docs/src/accessibility-testing-java.md index 12d86056a4..402ecca096 100644 --- a/docs/src/accessibility-testing-java.md +++ b/docs/src/accessibility-testing-java.md @@ -91,7 +91,7 @@ void navigationMenuFlyoutShouldNotHaveAutomaticallyDetectableAccessibilityViolat ### Example 3: Scanning for WCAG violations -By default, axe checks against a wide variety of accessibility rules. Some of these rules correspond to specific success criteria from the [Web Content Accessibility Guidelines (WCAG)](https://www.w3.org/TR/WCAG21/), and others are "best practice" rules that are not specifically required by any WCAG criteron. +By default, axe checks against a wide variety of accessibility rules. Some of these rules correspond to specific success criteria from the [Web Content Accessibility Guidelines (WCAG)](https://www.w3.org/TR/WCAG21/), and others are "best practice" rules that are not specifically required by any WCAG criterion. You can constrain an accessibility scan to only run those rules which are "tagged" as corresponding to specific WCAG success criteria by using [`AxeBuilder.withTags()`](https://github.com/dequelabs/axe-core-maven-html/blob/develop/playwright/README.md#axebuilderwithtagsliststring-rules). For example, [Accessibility Insights for Web's Automated Checks](https://accessibilityinsights.io/docs/web/getstarted/fastpass/?referrer=playwright-accessibility-testing-java) only include axe rules that test for violations of WCAG A and AA success criteria; to match that behavior, you would use the tags `wcag2a`, `wcag2aa`, `wcag21a`, and `wcag21aa`. @@ -165,7 +165,7 @@ shouldOnlyHaveAccessibilityViolationsMatchingKnownFingerprints() throws Exceptio AxeResults accessibilityScanResults = new AxeBuilder(page).analyze(); List violationFingerprints = fingerprintsFromScanResults(accessibilityScanResults); - + assertEquals(Arrays.asList( new ViolationFingerprint("aria-roles", "[span[role=\"invalid\"]]"), new ViolationFingerprint("color-contrast", "[li:nth-child(2) > span]"), diff --git a/docs/src/accessibility-testing-js.md b/docs/src/accessibility-testing-js.md index 69aa566854..c255048133 100644 --- a/docs/src/accessibility-testing-js.md +++ b/docs/src/accessibility-testing-js.md @@ -91,7 +91,7 @@ test('navigation menu flyout should not have automatically detectable accessibil ### Scanning for WCAG violations -By default, axe checks against a wide variety of accessibility rules. Some of these rules correspond to specific success criteria from the [Web Content Accessibility Guidelines (WCAG)](https://www.w3.org/TR/WCAG21/), and others are "best practice" rules that are not specifically required by any WCAG criteron. +By default, axe checks against a wide variety of accessibility rules. Some of these rules correspond to specific success criteria from the [Web Content Accessibility Guidelines (WCAG)](https://www.w3.org/TR/WCAG21/), and others are "best practice" rules that are not specifically required by any WCAG criterion. You can constrain an accessibility scan to only run those rules which are "tagged" as corresponding to specific WCAG success criteria by using [`AxeBuilder.withTags()`](https://github.com/dequelabs/axe-core-npm/blob/develop/packages/playwright/README.md#axebuilderwithtagstags-stringarray). For example, [Accessibility Insights for Web's Automated Checks](https://accessibilityinsights.io/docs/web/getstarted/fastpass/?referrer=playwright-accessibility-testing-js) only include axe rules that test for violations of WCAG A and AA success criteria; to match that behavior, you would use the tags `wcag2a`, `wcag2aa`, `wcag21a`, and `wcag21aa`. diff --git a/docs/src/api/class-locator.md b/docs/src/api/class-locator.md index f4002654d4..a1a530ab7e 100644 --- a/docs/src/api/class-locator.md +++ b/docs/src/api/class-locator.md @@ -448,7 +448,7 @@ When all steps combined have not finished during the specified [`option: timeout ## async method: Locator.dispatchEvent * since: v1.14 -Programmaticaly dispatch an event on the matching element. +Programmatically dispatch an event on the matching element. **Usage** @@ -1427,7 +1427,7 @@ A page this locator belongs to. ## async method: Locator.press * since: v1.14 -Focuses the mathing element and presses a combintation of the keys. +Focuses the matching element and presses a combination of the keys. **Usage** diff --git a/docs/src/codegen.md b/docs/src/codegen.md index d7d8769f49..6eb35a0a5b 100644 --- a/docs/src/codegen.md +++ b/docs/src/codegen.md @@ -119,7 +119,7 @@ playwright codegen --timezone="Europe/Rome" --geolocation="41.890221,12.492348" pwsh bin/Debug/netX/playwright.ps1 codegen --timezone="Europe/Rome" --geolocation="41.890221,12.492348" --lang="it-IT" maps.google.com ``` -Codegen generating code for tests for google maps showing timezone, geoloation as Rome, Italy and in Italian language +Codegen generating code for tests for google maps showing timezone, geolocation as Rome, Italy and in Italian language ## Preserve authenticated state diff --git a/docs/src/library-js.md b/docs/src/library-js.md index 4e978ed468..3eb44371c0 100644 --- a/docs/src/library-js.md +++ b/docs/src/library-js.md @@ -101,7 +101,7 @@ The key differences to note are as follows: | Installation | `npm install playwright` | `npm init playwright@latest` - note `install` vs. `init` | | Install browsers | Chromium, Firefox, WebKit are installed by default | `npx playwright install` or `npx playwright install chromium` for a single one | | `import`/`require` name | `playwright` | `@playwright/test` | -| Initialization | Explicitly need to:
  1. Pick a browser to use, e.g. `chromium`
  2. Launch browser with [`method: BrowserType.launch`]
  3. Create a context with [`method: Browser.newContext`], and pass any context options explcitly, e.g. `devices['iPhone 11']`
  4. Create a page with [`method: BrowserContext.newPage`]
| An isolated `page` and `context` are provided to each test out-of the box, along with other [built-in fixtures](./test-fixtures.md#built-in-fixtures). No explicit creation. If referenced by the test in it's arguments, the Test Runner will create them for the test. (i.e. lazy-initialization) | +| Initialization | Explicitly need to:
  1. Pick a browser to use, e.g. `chromium`
  2. Launch browser with [`method: BrowserType.launch`]
  3. Create a context with [`method: Browser.newContext`], and pass any context options explicitly, e.g. `devices['iPhone 11']`
  4. Create a page with [`method: BrowserContext.newPage`]
| An isolated `page` and `context` are provided to each test out-of the box, along with other [built-in fixtures](./test-fixtures.md#built-in-fixtures). No explicit creation. If referenced by the test in it's arguments, the Test Runner will create them for the test. (i.e. lazy-initialization) | | Assertions | No built-in Web-First Assertions | [Web-First assertions](./test-assertions.md) like:
  • [`method: PageAssertions.toHaveTitle`]
  • [`method: PageAssertions.toHaveScreenshot#1`]
which auto-wait and retry for the condition to be met.| | Cleanup | Explicitly need to:
  1. Close context with [`method: BrowserContext.close`]
  2. Close browser with [`method: Browser.close`]
| No explicit close of [built-in fixtures](./test-fixtures.md#built-in-fixtures); the Test Runner will take care of it. | Running | When using the Library, you run the code as a node script, possibly with some compilation first. | When using the Test Runner, you use the `npx playwright test` command. Along with your [config](./test-configuration.md), the Test Runner handles any compilation and choosing what to run and how to run it. | diff --git a/docs/src/mock.md b/docs/src/mock.md index 6e26fa8e3f..ef9504c3f6 100644 --- a/docs/src/mock.md +++ b/docs/src/mock.md @@ -66,7 +66,7 @@ await page.route('https://dog.ceo/api/breeds/list/all', async route => { const response = await route.fetch(); const json = await response.json(); json.message['big_red_dog'] = []; - // Fullfill using the original response, while patching the response body + // Fulfill using the original response, while patching the response body // with the given JSON object. await route.fulfill({ response, json }); }); @@ -77,7 +77,7 @@ async def handle(route): response = await route.fulfill() json = await response.json() json["message"]["big_red_dog"] = [] - # Fullfill using the original response, while patching the response body + # Fulfill using the original response, while patching the response body # with the given JSON object. await route.fulfill(response=response, json=json) @@ -89,7 +89,7 @@ def handle(route): response = route.fulfill() json = response.json() json["message"]["big_red_dog"] = [] - # Fullfill using the original response, while patching the response body + # Fulfill using the original response, while patching the response body # with the given JSON object. route.fulfill(response=response, json=json) @@ -102,7 +102,7 @@ await page.RouteAsync("https://dog.ceo/api/breeds/list/all", async route => var response = await route.FetchAsync(); dynamic json = await response.JsonAsync(); json.message.big_red_dog = new string[] {}; - // Fullfill using the original response, while patching the response body + // Fulfill using the original response, while patching the response body // with the given JSON object. await route.FulfillAsync(new() { Response = response, Json = json }); }); @@ -114,7 +114,7 @@ page.route("https://dog.ceo/api/breeds/list/all", route -> { JsonObject json = new Gson().fromJson(response.text(), JsonObject.class); JsonObject message = json.get("message").getAsJsonObject(); message.set("big_red_dog", new JsonArray()); - // Fullfill using the original response, while patching the response body + // Fulfill using the original response, while patching the response body // with the given JSON object. route.fulfill(new Route.FulfillOptions() .setResponse(response) diff --git a/docs/src/other-locators.md b/docs/src/other-locators.md index ddb1a4f03a..62fd93ee7d 100644 --- a/docs/src/other-locators.md +++ b/docs/src/other-locators.md @@ -13,7 +13,7 @@ In addition to recommended locators like [`method: Page.getByRole`] and [`method ## CSS locator :::note -We recommend prioritzing [user-visible locators](./locators.md#quick-guide) like text or accessible role instead of using CSS that is tied to the implementation and could break when the page changes. +We recommend prioritizing [user-visible locators](./locators.md#quick-guide) like text or accessible role instead of using CSS that is tied to the implementation and could break when the page changes. ::: Playwright can locate an element by CSS selector. @@ -42,7 +42,7 @@ Playwright augments standard CSS selectors in two ways: Playwright include a number of CSS pseudo-classes to match elements by their text content. -- `article:has-text("Playwright")` - the `:has-text()` matches any element containing specified text somewhere inside, possibly in a child or a descendant element. Matching is case-insensitive, trims whitestapce and searches for a substring. +- `article:has-text("Playwright")` - the `:has-text()` matches any element containing specified text somewhere inside, possibly in a child or a descendant element. Matching is case-insensitive, trims whitespace and searches for a substring. For example, `article:has-text("Playwright")` matches `
Playwright
`. @@ -122,7 +122,7 @@ Input elements of the type `button` and `submit` are matched by their `value` in ### CSS: matching only visible elements -Playwrigt supports the `:visible` pseudo class in CSS selectors. For example, `css=button` matches all the buttons on the page, while `css=button:visible` only matches visible buttons. This is useful to distinguish elements that are very similar but differ in visibility. +Playwright supports the `:visible` pseudo class in CSS selectors. For example, `css=button` matches all the buttons on the page, while `css=button:visible` only matches visible buttons. This is useful to distinguish elements that are very similar but differ in visibility. Consider a page with two buttons, first invisible and second visible. @@ -618,7 +618,7 @@ Vue locator, as well as [Vue DevTools](https://chrome.google.com/webstore/detail ## XPath locator :::warning -We recommend prioritzing [user-visible locators](./locators.md#quick-guide) like text or accessible role instead of using XPath that is tied to the implementation and easily break when the page changes. +We recommend prioritizing [user-visible locators](./locators.md#quick-guide) like text or accessible role instead of using XPath that is tied to the implementation and easily break when the page changes. ::: XPath locators are equivalent to calling [`Document.evaluate`](https://developer.mozilla.org/en/docs/Web/API/Document/evaluate). diff --git a/docs/src/service-workers-experimental-network-events-js.md b/docs/src/service-workers-experimental-network-events-js.md index 2846d0d84e..b29a4eec73 100644 --- a/docs/src/service-workers-experimental-network-events-js.md +++ b/docs/src/service-workers-experimental-network-events-js.md @@ -65,7 +65,7 @@ Worker serviceWorker = page.waitForRequest(() -> { [`event: BrowserContext.serviceWorker`] is fired ***before*** the Service Worker's main script has been evaluated, so ***before*** calling service[`method: Worker.evaluate`] you should wait on its activation. -There are more iodiomatic methods of waiting for a Service Worker to be activated, but the following is an implementation agnostic method: +There are more idiomatic methods of waiting for a Service Worker to be activated, but the following is an implementation agnostic method: ```js tab=js-ts await page.evaluate(async () => { @@ -219,7 +219,7 @@ self.addEventListener("fetch", (event) => { // 3. Prevent tracker.js from being retrieved, and returns a placeholder response if (event.request.url.endsWith("tracker.js")) - return new Response('conosole.log("no trackers!")', { + return new Response('console.log("no trackers!")', { status: 200, headers: { "Content-Type": "text/javascript" }, }); diff --git a/docs/src/test-api/class-test.md b/docs/src/test-api/class-test.md index dae0dc0161..7bc8f3b2e1 100644 --- a/docs/src/test-api/class-test.md +++ b/docs/src/test-api/class-test.md @@ -830,7 +830,7 @@ An object containing fixtures and/or options. Learn more about [fixtures format] ## method: Test.fail#1 * since: v1.10 -Unconditonally marks a test as "should fail". Playwright Test runs this test and ensures that it is actually failing. This is useful for documentation purposes to acknowledge that some functionality is broken until it is fixed. +Unconditionally marks a test as "should fail". Playwright Test runs this test and ensures that it is actually failing. This is useful for documentation purposes to acknowledge that some functionality is broken until it is fixed. **Usage** diff --git a/docs/src/test-configuration-js.md b/docs/src/test-configuration-js.md index 3cf4a6a0ae..c570d6e183 100644 --- a/docs/src/test-configuration-js.md +++ b/docs/src/test-configuration-js.md @@ -425,7 +425,7 @@ However, most common ones like `headless` or `viewport` are available directly i ## Explicit Context Creation and Option Inheritance -If using the built-in `browser` fixture, calling [`method: Browser.newContext`] will create a context with options inherted from the config: +If using the built-in `browser` fixture, calling [`method: Browser.newContext`] will create a context with options inherited from the config: ```js tab=js-ts // playwright.config.ts diff --git a/docs/src/test-parameterize-js.md b/docs/src/test-parameterize-js.md index c80f6c7509..610266fb3d 100644 --- a/docs/src/test-parameterize-js.md +++ b/docs/src/test-parameterize-js.md @@ -200,7 +200,7 @@ test(`example test`, async ({ page }) => { }); ``` -You can run this test with your secrect username and password set in the command line. +You can run this test with your secret username and password set in the command line. ```bash tab=bash-bash USERNAME=me PASSWORD=secret npx playwright test diff --git a/docs/src/test-reporters-js.md b/docs/src/test-reporters-js.md index 43a1ddc699..237e9e8447 100644 --- a/docs/src/test-reporters-js.md +++ b/docs/src/test-reporters-js.md @@ -479,7 +479,7 @@ test('using specific annotations for passing test metadata to Xray', async ({}, }); ``` -Please note that the semantics of these properties will depend on the tool that will process this evoled report format; there are no standard property names/annotations. +Please note that the semantics of these properties will depend on the tool that will process this evolved report format; there are no standard property names/annotations. If the configuration option `embedAttachmentsAsProperty` is defined, then a `property` with its name is created. Attachments, including their contents, will be embedded on the JUnit XML report inside `` elements under this `property`. Attachments are obtained from the `TestInfo` object, using either a path or a body, and are added as base64 encoded content. Embedding attachments can be used to attach screenshots or any other relevant evidence; nevertheless, use it wisely as it affects the report size. diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts index 71e6418b19..100045c8c9 100644 --- a/packages/playwright-core/types/types.d.ts +++ b/packages/playwright-core/types/types.d.ts @@ -10496,7 +10496,7 @@ export interface Locator { }): Promise; /** - * Programmaticaly dispatch an event on the matching element. + * Programmatically dispatch an event on the matching element. * * **Usage** * @@ -11405,7 +11405,7 @@ export interface Locator { page(): Page; /** - * Focuses the mathing element and presses a combintation of the keys. + * Focuses the matching element and presses a combination of the keys. * * **Usage** * diff --git a/packages/playwright-test/types/test.d.ts b/packages/playwright-test/types/test.d.ts index 4612371ae2..0d0a79b1fc 100644 --- a/packages/playwright-test/types/test.d.ts +++ b/packages/playwright-test/types/test.d.ts @@ -2757,7 +2757,7 @@ export interface TestType boolean, description?: string): void; /** - * Unconditonally marks a test as "should fail". Playwright Test runs this test and ensures that it is actually + * Unconditionally marks a test as "should fail". Playwright Test runs this test and ensures that it is actually * failing. This is useful for documentation purposes to acknowledge that some functionality is broken until it is * fixed. * diff --git a/tests/assets/axe-core/README.md b/tests/assets/axe-core/README.md index 6b075462f8..654c90288d 100644 --- a/tests/assets/axe-core/README.md +++ b/tests/assets/axe-core/README.md @@ -3,6 +3,6 @@ Tests derived from axe-core test suite: https://github.com/dequelabs/axe-core/tr Includes: - `LICENSE` -Modifed: +Modified: - `implicit-role.js` contains test cases extracted from `/test/commons/aria/implicit-role.js` - `accessible-text.js` contains test cases extracted from `/test/commons/aria/accessible-text.js` diff --git a/tests/assets/wpt/README.md b/tests/assets/wpt/README.md index 260e43a7ec..2275a2c043 100644 --- a/tests/assets/wpt/README.md +++ b/tests/assets/wpt/README.md @@ -6,5 +6,5 @@ Includes: - `accname/foo.jpg` - `wai-aria/scripts/manual.css` -Modifed: +Modified: - `wai-aria/scripts/ATTAcomm.js` contains our own harness to avoid modifying test files diff --git a/tests/image_tools/fixtures/should-match/crbug-919955/README.md b/tests/image_tools/fixtures/should-match/crbug-919955/README.md index 518dfdbb36..929e969cd6 100644 --- a/tests/image_tools/fixtures/should-match/crbug-919955/README.md +++ b/tests/image_tools/fixtures/should-match/crbug-919955/README.md @@ -1,5 +1,3 @@ -# Chrome non-determenistic rendering +# Chrome non-deterministic rendering Reported by: https://bugs.chromium.org/p/chromium/issues/detail?id=919955 - - diff --git a/tests/image_tools/fixtures/should-match/tiny-antialiasing-sample/README.md b/tests/image_tools/fixtures/should-match/tiny-antialiasing-sample/README.md index f65b71ed44..4562c8788c 100644 --- a/tests/image_tools/fixtures/should-match/tiny-antialiasing-sample/README.md +++ b/tests/image_tools/fixtures/should-match/tiny-antialiasing-sample/README.md @@ -1,5 +1,5 @@ # Tiny anti-aliasing sample This is a 10x10 image sample with a 3 anti-aliased pixels in-between. This is actually -a cropped down snapshot of one of the [ubuntu-x86-vs-ubunu-arm samples](../ubuntu-x86-vs-ubuntu-arm/samples/stylings_stories-Stylings-stories-Texture-bar-should-use-custom-path-chrome/stylings-stories/texture/bar/should-use-custom-path-actual.png) handy for debugging +a cropped down snapshot of one of the [ubuntu-x86-vs-ubuntu-arm samples](../ubuntu-x86-vs-ubuntu-arm/samples/stylings_stories-Stylings-stories-Texture-bar-should-use-custom-path-chrome/stylings-stories/texture/bar/should-use-custom-path-actual.png) handy for debugging purposes. diff --git a/tests/library/defaultbrowsercontext-1.spec.ts b/tests/library/defaultbrowsercontext-1.spec.ts index 9d922fa931..3aa7357d2f 100644 --- a/tests/library/defaultbrowsercontext-1.spec.ts +++ b/tests/library/defaultbrowsercontext-1.spec.ts @@ -171,7 +171,7 @@ it('should support offline option', async ({ server, launchPersistent }) => { }); it('should support acceptDownloads option', async ({ server, launchPersistent, mode }) => { - it.skip(mode !== 'default', 'download.path() is not avaialble in remote mode'); + it.skip(mode !== 'default', 'download.path() is not available in remote mode'); const { page } = await launchPersistent(); server.setRoute('/download', (req, res) => { diff --git a/tests/library/favicon.spec.ts b/tests/library/favicon.spec.ts index 6c9e206168..f3e318a60f 100644 --- a/tests/library/favicon.spec.ts +++ b/tests/library/favicon.spec.ts @@ -21,7 +21,7 @@ it('should load svg favicon with prefer-color-scheme', async ({ page, server, br it.skip(headless && browserName !== 'firefox', 'headless browsers, except firefox, do not request favicons'); it.skip(!headless && browserName === 'webkit' && !channel, 'headed webkit does not have a favicon feature'); - // Browsers aggresively cache favicons, so force bust with the + // Browsers aggressively cache favicons, so force bust with the // `d` parameter to make iterating on this test more predictable and isolated. const favicon = `/favicon.svg?d=${Date.now()}`; server.setRoute(favicon, (req, res) => { diff --git a/tests/library/screenshot.spec.ts b/tests/library/screenshot.spec.ts index 842ecf84ae..a99c3f7e70 100644 --- a/tests/library/screenshot.spec.ts +++ b/tests/library/screenshot.spec.ts @@ -131,7 +131,7 @@ browserTest.describe('page screenshot', () => { }); browserTest('should work with large size', async ({ browserName, headless, platform, contextFactory }) => { - browserTest.fixme(browserName === 'chromium' && !headless && platform === 'linux', 'Chromium has gpu problems on linux with large screnshots'); + browserTest.fixme(browserName === 'chromium' && !headless && platform === 'linux', 'Chromium has gpu problems on linux with large screenshots'); browserTest.slow(true, 'Large screenshot is slow'); const context = await contextFactory(); diff --git a/tests/library/tap.spec.ts b/tests/library/tap.spec.ts index 40be993139..56adabfe41 100644 --- a/tests/library/tap.spec.ts +++ b/tests/library/tap.spec.ts @@ -28,7 +28,7 @@ it('should send all of the correct events @smoke', async ({ page }) => { await page.tap('#a'); const eventsHandle = await trackEvents(await page.$('#b')); await page.tap('#b'); - // webkit doesnt send pointerenter or pointerleave or mouseout + // webkit doesn't send pointerenter or pointerleave or mouseout expect(await eventsHandle.jsonValue()).toEqual([ 'pointerover', 'pointerenter', 'pointerdown', 'touchstart', @@ -96,7 +96,7 @@ it('should wait for a navigation caused by a tap', async ({ page, server }) => { let resolved = false; const tapPromise = page.tap('a').then(() => resolved = true); const response = await responsePromise; - // make sure the tap doesnt resolve too early + // make sure the tap doesn't resolve too early await new Promise(x => setTimeout(x, 100)); expect(resolved).toBe(false); diff --git a/tests/page/page-evaluate.spec.ts b/tests/page/page-evaluate.spec.ts index eee558ed90..7f3e407e55 100644 --- a/tests/page/page-evaluate.spec.ts +++ b/tests/page/page-evaluate.spec.ts @@ -356,7 +356,7 @@ it('should properly serialize PerformanceMeasure object', async ({ page }) => { }]); }); -it('shuld properly serialize window.performance object', async ({ page }) => { +it('should properly serialize window.performance object', async ({ page }) => { expect(await page.evaluate(() => performance)).toEqual({ 'navigation': { 'redirectCount': 0, @@ -482,7 +482,7 @@ it('should not throw an error when evaluation does a navigation', async ({ page, }); it('should not throw an error when evaluation does a synchronous navigation and returns an object', async ({ page, server, browserName }) => { - // It is imporant to be on about:blank for sync reload. + // It is important to be on about:blank for sync reload. const result = await page.evaluate(() => { window.location.reload(); return { a: 42 }; @@ -491,7 +491,7 @@ it('should not throw an error when evaluation does a synchronous navigation and }); it('should not throw an error when evaluation does a synchronous navigation and returns undefined', async ({ page }) => { - // It is imporant to be on about:blank for sync reload. + // It is important to be on about:blank for sync reload. const result = await page.evaluate(() => { window.location.reload(); return undefined; diff --git a/tests/page/page-event-network.spec.ts b/tests/page/page-event-network.spec.ts index 490a0f8ce1..02f7211735 100644 --- a/tests/page/page-event-network.spec.ts +++ b/tests/page/page-event-network.spec.ts @@ -132,7 +132,7 @@ it('should resolve responses after a navigation', async ({ page, server, browser const responsePromise = request.response(); // navigate, which should cancel the request await page.goto(server.CROSS_PROCESS_PREFIX); - // make sure we arent stalling this request on the server + // make sure we aren't stalling this request on the server responseFromServer.end('done'); // the response should resolve to null, because the page navigated. expect(await responsePromise).toBe(null); diff --git a/tests/page/selectors-react.spec.ts b/tests/page/selectors-react.spec.ts index 8aecf26a20..bd3234b95a 100644 --- a/tests/page/selectors-react.spec.ts +++ b/tests/page/selectors-react.spec.ts @@ -73,11 +73,11 @@ for (const [name, url] of Object.entries(reacts)) { it('should exact match by props', async ({ page }) => { await expect(page.locator(`_react=BookItem[name = "The Great Gatsby"]`)).toHaveText('The Great Gatsby'); await expect(page.locator(`_react=BookItem[name = "The Great Gatsby"]`)).toHaveCount(1); - // case sensetive by default + // case sensitive by default await expect(page.locator(`_react=BookItem[name = "the great gatsby"]`)).toHaveCount(0); await expect(page.locator(`_react=BookItem[name = "the great gatsby" s]`)).toHaveCount(0); await expect(page.locator(`_react=BookItem[name = "the great gatsby" S]`)).toHaveCount(0); - // case insensetive with flag + // case insensitive with flag await expect(page.locator(`_react=BookItem[name = "the great gatsby" i]`)).toHaveCount(1); await expect(page.locator(`_react=BookItem[name = "the great gatsby" I]`)).toHaveCount(1); await expect(page.locator(`_react=BookItem[name = " The Great Gatsby "]`)).toHaveCount(0); diff --git a/tests/playwright-test/config.spec.ts b/tests/playwright-test/config.spec.ts index a239b95d30..f006c66871 100644 --- a/tests/playwright-test/config.spec.ts +++ b/tests/playwright-test/config.spec.ts @@ -350,7 +350,7 @@ test('should work without config file', async ({ runInlineTest }) => { expect(skipped).toBe(0); }); -test('should inerhit use options in projects', async ({ runInlineTest }) => { +test('should inherit use options in projects', async ({ runInlineTest }) => { const result = await runInlineTest({ 'playwright.config.ts': ` module.exports = { diff --git a/tests/playwright-test/reporter-junit.spec.ts b/tests/playwright-test/reporter-junit.spec.ts index 2116055fb6..75df34f504 100644 --- a/tests/playwright-test/reporter-junit.spec.ts +++ b/tests/playwright-test/reporter-junit.spec.ts @@ -386,7 +386,7 @@ test('should render all annotations to testcase value based properties, if reque expect(result.exitCode).toBe(0); }); -test('should embed attachments to a custom testcase property, if explictly requested', async ({ runInlineTest }) => { +test('should embed attachments to a custom testcase property, if explicitly requested', async ({ runInlineTest }) => { const result = await runInlineTest({ 'playwright.config.ts': ` const xrayOptions = { @@ -425,7 +425,7 @@ test('should embed attachments to a custom testcase property, if explictly reque expect(result.exitCode).toBe(0); }); -test('should not embed attachments to a custom testcase property, if not explictly requested', async ({ runInlineTest }) => { +test('should not embed attachments to a custom testcase property, if not explicitly requested', async ({ runInlineTest }) => { const result = await runInlineTest({ 'a.test.js': ` const { test } = pwt; diff --git a/tests/stress/heap.spec.ts b/tests/stress/heap.spec.ts index cf4451dc7e..573ef4bcab 100644 --- a/tests/stress/heap.spec.ts +++ b/tests/stress/heap.spec.ts @@ -43,7 +43,7 @@ test('should not leak fixtures w/o page', async ({}) => { test('should not leak server-side objects', async ({ page }) => { expect(await queryObjectCount(require('../../packages/playwright-core/lib/server/page').Page)).toBe(1); - // 4 is because v8 heap creates obejcts for descendant classes, so WKContext, CRContext, FFContext and our context instance. + // 4 is because v8 heap creates objects for descendant classes, so WKContext, CRContext, FFContext and our context instance. expect(await queryObjectCount(require('../../packages/playwright-core/lib/server/browserContext').BrowserContext)).toBe(4); expect(await queryObjectCount(require('../../packages/playwright-core/lib/server/browser').Browser)).toBe(4); });