From f8100bbb25fdd59aac2719788e9f0d5267d55cc2 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 1 Mar 2023 09:16:23 -0800 Subject: [PATCH] fix: expect unquoted npde.exe path (#21307) * It is more common to set env variable value without quotes on Windows (see the bug) * Use defined to check for string presence, it will work nicely with strings that contain whitespaces https://github.com/microsoft/playwright-java/issues/1213 --- utils/build/run-driver-win.cmd | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/utils/build/run-driver-win.cmd b/utils/build/run-driver-win.cmd index c343dc30bc..4ea002a667 100755 --- a/utils/build/run-driver-win.cmd +++ b/utils/build/run-driver-win.cmd @@ -1,6 +1,4 @@ @echo off setlocal -if not defined PLAYWRIGHT_NODEJS_PATH ( - set PLAYWRIGHT_NODEJS_PATH="%~dp0\node.exe" -) -""%PLAYWRIGHT_NODEJS_PATH%"" "%~dp0\package\lib\cli\cli.js" %* +if not defined PLAYWRIGHT_NODEJS_PATH set PLAYWRIGHT_NODEJS_PATH=%~dp0node.exe +"%PLAYWRIGHT_NODEJS_PATH%" "%~dp0package\lib\cli\cli.js" %* \ No newline at end of file