Merged PR 485264: Merge portal to master - Release version 1.14.0

This PR merges the changes from portal to master that was missed in the last releases. These changes include pipeline changes, SmartNarrative APIs, focousMode command settings, and more repo setup changes. Some of the changes in this PR was already cherry-picked to master, but they appear in this PR as this is a merge PR. I think we should always default to merging portal to master before release and use cherry pick only if there is a need to. Related work items: #701218, #839888, #847155, #891639, #916464, #964642, #965865
2023-11-29 09:37:57 +00:00 · 2023-11-29 09:37:57 +00:00 · 8531d87bbd
--- a/.config/merlinbot/nudge.yaml
+++ b/.config/merlinbot/nudge.yaml
@ -5,11 +5,9 @@ maxReviewersToNudge: 3
 # Do not nudge users that are included in the following list
 excludeUsers:
  - neryac@microsoft.com
-  - shyosef@microsoft.com
 #  - user2@microsoft.com
 # Do not nudge PRs authored by users that are included in the following list
-excludePrsFromAuthors:
-  - shyosef@microsoft.com
+# excludePrsFromAuthors:
 # To enable or disable early nudge on pull requests
 enableEarlyNudge: false
 # Number of days to wait after a pull request is created, to analyze it for an early nudge
--- a/.config/merlinbot/reviewerrecommender.yaml
+++ b/.config/merlinbot/reviewerrecommender.yaml
@ -9,5 +9,4 @@ maxReviewers: 2
 #  - ^/private/Product/PowerBI/NuGetPackages/
 # Do not make recommendations for reviewers that are included in the following list
 excludedReviewers:
-  - shyosef@microsoft.com
  - neryac@microsoft.com
--- a/.config/tsaoptions.json
+++ b/.config/tsaoptions.json
@ -0,0 +1,14 @@
+{
+    "codebaseName": "powerbi-models",
+    "instanceUrl": "https://powerbi.visualstudio.com",
+    "projectName": "Trident",
+    "areaPath" : "Trident\\ISV and ALM\\Embedded",
+    "iterationPath": "Trident\\Releases",
+    "notificationAliases": [
+        "corembed@microsoft.com"
+    ],
+    "codebaseAdmins": [
+        "redmond\\corembed"
+    ],
+    "ignoreBranchName": true
+}
--- a/.pipelines/OneBranch.Buddy.yml
+++ b/.pipelines/OneBranch.Buddy.yml
@ -17,15 +17,14 @@ parameters: # parameters are shown up in ADO UI in a build queue time
  default: false

 variables:
-  CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
  system.debug: ${{ parameters.debug }}
  ENABLE_PRS_DELAYSIGN: 1
  ROOT: $(Build.SourcesDirectory)
  REPOROOT: $(Build.SourcesDirectory)
  OUTPUTROOT: $(REPOROOT)\out
-  NUGET_XMLDOC_MODE: none
+  NUGET_XMLDOC_MODE: skip

-  WindowsContainerImage: 'cdpxwin1809.azurecr.io/global/obinfra/windows/1809/vs2019:latest' # Docker image which is used to build the project https://aka.ms/obpipelines/containers
+  WindowsContainerImage: 'onebranch.azurecr.io/windows/ltsc2019/vse2022:latest' # Docker image which is used to build the project https://aka.ms/obpipelines/containers

 resources:
  repositories:
@ -58,10 +57,11 @@ extends:

        steps:
          # Custom Versioning - we will build the version using package.json in versioning commands.
-          - task: CmdLine@2
+          - task: PowerShell@2
            displayName: 'Set Version'
            inputs:
-              script: '$(Build.SourcesDirectory)\.pipelines\onebranch_run_ps.cmd version.ps1'
+              targetType: 'filePath'
+              filePath: '$(Build.SourcesDirectory)\.pipelines\version.ps1'
              workingDirectory: '$(Build.SourcesDirectory)'

          # Add the versioning task after running Version script
@ -80,27 +80,47 @@ extends:
            inputs:
              workingFile: '$(Build.SourcesDirectory)\.npmrc'

-          # Commands to run during the restore stage
-          - task: CmdLine@2
+          - task: PowerShell@2
            displayName: 'Restore'
            inputs:
-              script: '$(Build.SourcesDirectory)\.pipelines\onebranch_run_ps.cmd restore.ps1'
+              targetType: 'filePath'
+              filePath: '$(Build.SourcesDirectory)\.pipelines\restore.ps1'
              workingDirectory: '$(Build.SourcesDirectory)'

-          # Commands to run during the build stage.
-          - task: CmdLine@2
+          - task: PowerShell@2
            displayName: 'Build'
            inputs:
-              script: '$(Build.SourcesDirectory)\.pipelines\onebranch_run_ps.cmd build.ps1'
+              targetType: 'filePath'
+              filePath: '$(Build.SourcesDirectory)\.pipelines\build.ps1'
              workingDirectory: '$(Build.SourcesDirectory)'

-          # Commands to run during the packaging stage.
-          - task: CmdLine@2
+          - task: PowerShell@2
            displayName: 'Package'
            inputs:
-              script: '$(Build.SourcesDirectory)\.pipelines\onebranch_run_ps.cmd package.ps1'
+              targetType: 'filePath'
+              filePath: '$(Build.SourcesDirectory)\.pipelines\package.ps1'
              workingDirectory: '$(Build.SourcesDirectory)'

+          # Copying build artifacts to the Output folder.
+          - task: CopyFiles@2
+            displayName: 'Copy Dist to Output folder'
+            inputs:
+              SourceFolder: '$(Build.SourcesDirectory)'
+              Contents: |
+                dist\**\*
+                LICENSE.txt
+                package.json
+                README.md
+              TargetFolder: '$(OUTPUTROOT)\outputs\build\build_artifacts'
+
+          - task: CopyFiles@2
+            displayName: 'Copy tgz-package to Output folder'
+            inputs:
+              SourceFolder: '$(Build.SourcesDirectory)'
+              Contents: |
+                *.tgz
+              TargetFolder: '$(OUTPUTROOT)\outputs\package\tgz-package'
+
          # Signing the files created by the build and packaging script
          - task: onebranch.pipeline.signing@1
            displayName: 'Sign binaries'
@ -108,24 +128,5 @@ extends:
              command: 'sign'
              signing_environment: 'azure-ado'
              signing_profile: 'internal_azure_service'
-              files_to_sign: 'dist\**\*;LICENSE.txt;package.json;README.md;**\*.tgz'
-              search_root: '$(Build.SourcesDirectory)'
-
-          # Copying build artifacts to the Output folder.
-          - task: CopyFiles@2
-            displayName: 'Copy Dist to Output folder'
-            inputs:
-              Contents: |
-                $(Build.SourcesDirectory)\dist\**\*
-                $(Build.SourcesDirectory)\LICENSE.txt
-                $(Build.SourcesDirectory)\package.json
-                $(Build.SourcesDirectory)\README.md
-              TargetFolder: '$(OUTPUTROOT)\outputs\build\build_artifacts'
-
-          # Copying tgz package to the Output folder.
-          - task: CopyFiles@2
-            displayName: 'Copy tgz-package to Output folder'
-            inputs:
-              Contents: |
-                $(Build.SourcesDirectory)\*.tgz
-              TargetFolder: '$(OUTPUTROOT)\outputs\package\tgz-package'
+              files_to_sign: '**'
+              search_root: '$(OUTPUTROOT)'
--- a/.pipelines/OneBranch.Official.yml
+++ b/.pipelines/OneBranch.Official.yml
@ -17,15 +17,18 @@ parameters: # parameters are shown up in ADO UI in a build queue time
  default: false

 variables:
-  CDP_DEFINITION_BUILD_COUNT: $[counter('', 0)] # needed for onebranch.pipeline.version task https://aka.ms/obpipelines/versioning
  system.debug: ${{ parameters.debug }}
  ENABLE_PRS_DELAYSIGN: 1
  ROOT: $(Build.SourcesDirectory)
  REPOROOT: $(Build.SourcesDirectory)
  OUTPUTROOT: $(REPOROOT)\out
  NUGET_XMLDOC_MODE: skip
+  ${{ if eq(variables['Build.DefinitionName'], 'powerbi-models-Official') }}:
+    obpTemplate: v2/OneBranch.Official.CrossPlat.yml@templates # https://aka.ms/obpipelines/templates
+  ${{ else }}:
+    obpTemplate: v2/OneBranch.NonOfficial.CrossPlat.yml@templates # https://aka.ms/obpipelines/templates

-  WindowsContainerImage: 'cdpxwin1809.azurecr.io/global/obinfra/windows/1809/vs2019:latest' # Docker image which is used to build the project https://aka.ms/obpipelines/containers
+  WindowsContainerImage: 'onebranch.azurecr.io/windows/ltsc2019/vse2022:latest' # Docker image which is used to build the project https://aka.ms/obpipelines/containers

 resources:
  repositories:
@ -35,13 +38,14 @@ resources:
      ref: refs/heads/main

 extends:
-  template: v2/OneBranch.Official.CrossPlat.yml@templates # https://aka.ms/obpipelines/templates
+  template: ${{ variables.obpTemplate }}
  parameters:
-    cloudvault: # https://aka.ms/obpipelines/cloudvault
-      enabled: false
    globalSdl: # https://aka.ms/obpipelines/sdl
+      codeql:
+        compiled: 
+          enabled: true
      tsa:
-        enabled: false # onebranch publish all sdl results to TSA. If TSA is disabled all SDL tools will forced into 'break' build mode.
+        enabled: true# onebranch publish all sdl results to TSA. If TSA is disabled all SDL tools will forced into 'break' build mode.
      cg:
        failOnAlert: false

@ -52,11 +56,9 @@ extends:
        pool:
          type: windows  # read more about custom job pool types at https://aka.ms/obpipelines/yaml/jobs

-        variables:
+        variables: # More settings at https://aka.ms/obpipelines/yaml/jobs
          ob_outputDirectory: '$(OUTPUTROOT)' # this directory is uploaded to pipeline artifacts, reddog and cloudvault. More info at https://aka.ms/obpipelines/artifacts
          ob_sdl_binskim_break: true # https://aka.ms/obpipelines/sdl
-          ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/master') }}: # conditionally enable symbolsPublishing for master branch only
-            ob_symbolsPublishing_enabled: true # https://aka.ms/obpipelines/symbols
          ob_artifactBaseName: 'drop'
          ob_sdl_cg_failOnAlert: false

@ -85,7 +87,6 @@ extends:
            inputs:
              workingFile: '$(Build.SourcesDirectory)\.npmrc'

-
          - task: PowerShell@2
            displayName: 'Restore'
            inputs:
@ -107,21 +108,11 @@ extends:
              filePath: '$(Build.SourcesDirectory)\.pipelines\package.ps1'
              workingDirectory: '$(Build.SourcesDirectory)'

-          # Signing the files created by the build and packaging script
-          - task: onebranch.pipeline.signing@1
-            displayName: 'Sign binaries'
-            inputs:
-              command: 'sign'
-              signing_environment: 'azure-ado'
-              signing_profile: 'internal_azure_service'
-              files_to_sign: 'dist\**\*;LICENSE.txt;package.json;README.md;**\*.tgz'
-              search_root: '$(Build.SourcesDirectory)'
-
          # Copying build artifacts to the Output folder.
          - task: CopyFiles@2
            displayName: 'Copy Dist to Output folder'
            inputs:
-              SourceFolder: $(Build.SourcesDirectory)
+              SourceFolder: '$(Build.SourcesDirectory)'
              Contents: |
                dist\**\*
                LICENSE.txt
@ -129,11 +120,20 @@ extends:
                README.md
              TargetFolder: '$(OUTPUTROOT)\outputs\build\build_artifacts'

-          # Copying tgz package to the Output folder.
          - task: CopyFiles@2
            displayName: 'Copy tgz-package to Output folder'
            inputs:
-              SourceFolder: $(Build.SourcesDirectory)
+              SourceFolder: '$(Build.SourcesDirectory)'
              Contents: |
-                **\*.tgz
-              TargetFolder: '$(OUTPUTROOT)\outputs\package\tgz-package'
+                *.tgz
+              TargetFolder: '$(OUTPUTROOT)\outputs\package\tgz-package'
+
+          # Signing the files created by the build and packaging script
+          - task: onebranch.pipeline.signing@1
+            displayName: 'Sign binaries'
+            inputs:
+              command: 'sign'
+              signing_environment: 'azure-ado'
+              signing_profile: 'internal_azure_service'
+              files_to_sign: '**'
+              search_root: '$(OUTPUTROOT)'
--- a/.pipelines/onebranch_run_ps.cmd
+++ b/.pipelines/onebranch_run_ps.cmd
@ -1,6 +0,0 @@
-setlocal enabledelayedexpansion
-pushd "%~dp0\.."
-powershell.exe -ExecutionPolicy Unrestricted -NoProfile -WindowStyle Hidden -NonInteractive -File "%~dp0%~1"
-endlocal
-popd
-exit /B %ERRORLEVEL%
--- a/karma.conf.js
+++ b/karma.conf.js
@ -14,12 +14,11 @@ module.exports = function (config) {
        exclude: [],
        reporters: argv.debug ? ['spec', 'kjhtml'] : ['spec', 'coverage', 'kjhtml'],
        autoWatch: true,
-        browsers: [argv.chrome ? 'Chrome_headless' : 'PhantomJS'],
+        browsers: ["Chrome_headless"],
        plugins: [
            'karma-chrome-launcher',
            'karma-jasmine',
            'karma-spec-reporter',
-            'karma-phantomjs-launcher',
            'karma-coverage',
            'karma-jasmine-html-reporter'
        ],
--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@ -1,6 +1,6 @@
 {
    "name": "powerbi-models",
-    "version": "1.13.0",
+    "version": "1.14.0",
    "description": "Contains JavaScript &amp; TypeScript object models for Microsoft Power BI JavaScript SDK. For each model there is a TypeScript interface, and a validation function to ensure and object is valid.",
    "main": "dist/models.js",
    "typings": "dist/models.d.ts",
@ -55,9 +55,7 @@
        "karma-coverage": "^2.0.1",
        "karma-jasmine": "^0.3.8",
        "karma-jasmine-html-reporter": "^0.2.2",
-        "karma-phantomjs-launcher": "^1.0.4",
        "karma-spec-reporter": "0.0.32",
-        "phantomjs-prebuilt": "^2.1.7",
        "ts-loader": "^6.2.1",
        "typedoc": "^0.22.14",
        "typescript": "~4.6.0",
--- a/src/models.ts
+++ b/src/models.ts
@ -524,6 +524,10 @@ export interface IHierarchyFilter extends IFilter {
    hierarchyData: IHierarchyFilterNode[];
 }

+export interface ISmartNarratives {
+    summaryText: string;
+}
+
 export enum FilterType {
    Advanced = 0,
    Basic = 1,
@ -1692,6 +1696,7 @@ export interface ICommandsSettings {
    groupVisualContainers?: ICommandSettings;
    summarize?: ICommandSettings;
    clearSelection?: ICommandSettings;
+    focusMode?: ICommandSettings;
 }

 export interface IPaginatedReportsCommandSettings {