Граф коммитов

2 Коммитов

Автор SHA1 Сообщение Дата
Ali Abu Foul a734aa6929 Merged PR 267928: Fix broken powerbi-models@1.10.1 - Release version 1.10.2 2022-05-29 14:03:31 +00:00
Karan Dewani 471765dbfc Merged PR 260487: Migrate the powerbi-models library from TSLint to ESLint
Completed the task of migrating from TSLint to ESLint.

1. Removed the TSLint configurations and added configurations for ESLint.
2. Updated the default Linter to ESLint.

The base `.eslintrc.js` is taken from the [JS SDK](https://dev.azure.com/powerbi/Embedded/_git/powerbi-javascript?path=/.eslintrc.js).

The following lines have been changed:
1. ![image (6).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/e063268f-1107-4b90-a0c0-1785e0769499/pullRequests/260485/attachments/image%20%286%29.png)
 for using the main `tsconfig` file instead of the test file.

2. ![image (6).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%286%29.png)
Rule in the `tslint.json`

3. ![image (7).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%287%29.png)
Rule in the `tslint.json`

4. ![image (8).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%288%29.png)
Rule in the `tslint.json`

5. ![image (9).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%289%29.png)
Rule in the `tslint.json`

6. ![image (10).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%2810%29.png)
Rule in the `tslint.json`

7. ![image (11).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%2811%29.png)
Rule in the `tslint.json`

8. ![image (12).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%2812%29.png)
Rule in the `tslint.json`

There are no warnings or errors found in `src` folder the console after running ESLint as seen in the following image:

![image (3).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%283%29.png)

There are no warnings or errors found in `test` folder the console after running ESLint as seen in the following image:

![image (4).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%284%29.png)

After running npm audit, we get 8 vulnerabilities as shown in the picture below. All the vulnerabilities are caused by using the gulp-watch library....
2022-05-16 05:26:46 +00:00