Karan Dewani
471765dbfc
Merged PR 260487: Migrate the powerbi-models library from TSLint to ESLint
...
Completed the task of migrating from TSLint to ESLint.
1. Removed the TSLint configurations and added configurations for ESLint.
2. Updated the default Linter to ESLint.
The base `.eslintrc.js` is taken from the [JS SDK](https://dev.azure.com/powerbi/Embedded/_git/powerbi-javascript?path=/.eslintrc.js ).
The following lines have been changed:
1. ![image (6).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/e063268f-1107-4b90-a0c0-1785e0769499/pullRequests/260485/attachments/image%20%286%29.png )
for using the main `tsconfig` file instead of the test file.
2. ![image (6).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%286%29.png )
Rule in the `tslint.json`
3. ![image (7).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%287%29.png )
Rule in the `tslint.json`
4. ![image (8).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%288%29.png )
Rule in the `tslint.json`
5. ![image (9).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%289%29.png )
Rule in the `tslint.json`
6. ![image (10).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%2810%29.png )
Rule in the `tslint.json`
7. ![image (11).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%2811%29.png )
Rule in the `tslint.json`
8. ![image (12).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%2812%29.png )
Rule in the `tslint.json`
There are no warnings or errors found in `src` folder the console after running ESLint as seen in the following image:
![image (3).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%283%29.png )
There are no warnings or errors found in `test` folder the console after running ESLint as seen in the following image:
![image (4).png](https://dev.azure.com/powerbi/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/260487/attachments/image%20%284%29.png )
After running npm audit, we get 8 vulnerabilities as shown in the picture below. All the vulnerabilities are caused by using the gulp-watch library....
2022-05-16 05:26:46 +00:00
Shahak Yosef
1f49a4269d
Merged PR 145114: Improve kjhtml
...
Fixes two problems:
- Auto watch doesn't re-run tests on file changes
- Closing tests window doesn't close the test process in the command line
2021-02-07 08:46:48 +00:00
Nerya Cohen
fb21bd5ac2
Merged PR 144056: update uglify options to keep only license comment
...
Changed the license to:
```javascript
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
```
And the headers will become:
```javascript
// powerbi-models v1.8.0
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
```
> Notice: `models.js` will have the header once at the top, and the license multiple times (once for each file).
2021-02-03 11:26:08 +00:00
Shahak Yosef
8c8ed0a0f8
Merged PR 139687: Add kjhtml
...
Add kjhtml to the Javascript SDK to make debugging tests easier.
## Know issues:
1) Closing the test page doesn't close the running command in the terminal, need a couple of `cntrl + c`, this is the same in other repositories.
For reference check [karma.baseconf.js](https://powerbi.visualstudio.com/PowerBIClients/_git/PowerBIClients?path=%2Fsrc%2FModern%2FIntegrationTesting%2FDesktopIntegrationTestHost%2Fkarma.baseconf.js&_a=contents&version=GBmaster ) and [karma.conf.js](https://powerbi.visualstudio.com/PowerBIClients/_git/PowerBIClients?path=%2Fsrc%2FClients%2FPowerBIPlayground%2FAngular%2Fkarma.conf.js&_a=contents&version=GBmaster )
![modelskhhmtl.PNG](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/139687/attachments/modelskhhmtl.PNG )
2021-01-18 07:00:11 +00:00
Nerya Cohen
45eb9d9ce3
Merged PR 136668: Merge portal into master
...
Related work items: #315960
2021-01-03 10:09:20 +00:00
Anant Singh
48031dae41
Merged PR 136452: Remove no-export dts from build output
...
This should fix the [Bug 349305](https://dev.azure.com/ceapex/Engineering/_workitems/edit/349305 ): Duplicate TOC entries in TypeScript reference
Prevents generation of "dist/models-noexports.d.ts"
![image.png](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/136452/attachments/image.png )
2020-12-31 10:45:30 +00:00
Anant Singh
7b635ec7d0
Merged PR 130054: [powerbi-models]: Make master up-to-date with portal
...
To release updated models
2020-11-30 04:57:39 +00:00
Nerya Cohen
c5eaefab2a
Merged PR 114606: [Release] Version 1.5.0
...
* Add `PageNavigationPosition`
* Add `personalBookmarksEnabled`
2020-09-21 09:56:41 +00:00
Shahak Yosef
796ed3ba73
Merged PR 73532: Remove noJeyKill
...
Now that the gh-pages task was removed we can remove the noJeyKill one as well
2020-03-08 11:37:18 +00:00
Anant Singh
105d63309e
Merged PR 70044: Upgraded tslint, webpack-stream, migrated from Typings to @types to fix compliance issues and removed gulp-gh-pages
...
Fixes compliance issues with *diff*, *https-proxy-agent*, *dot-prop*, *chokidar* and *micromatch* packages.
**Changes**:
- Removed _gulp-gh-pages_ package and usage as discussed with Ali
- Used _@types/jasmine_ and _@types/karma-jasmine_ instead of _Typings_(deprecated)
- Upgraded webpack to v2.7.0 and webpack-stream to v4.0.0
- Upgraded tslint to v5.20 and gulp-tslint to v7.1
**References**:
[Build config changes: Plugins](https://github.com/webpack/webpack/issues/3043 )
[Test config changes](https://v4.webpack.js.org/plugins/loader-options-plugin/ )
[import jasmine](https://github.com/angular/angular-cli/issues/8909 )
[migration from Typings to @types](http://codereform.com/blog/post/migrating-from-typings-to-npm-types/ )
[fsevent build warning in windows](https://stackoverflow.com/questions/40226745/npm-warn-notsup-skipping-optional-dependency-unsupported-platform-for-fsevents )
**Validation**:
Validated all embedding functionality with Playground demo on localhost using this _powerbi-models_ package as dependency
Attached sanity check with #316027
Result of `npm ls powerbi-models` at _powerbi-javascript\demo_
![image.png](https://powerbi.visualstudio.com/4c7b5adb-c2d0-4f18-b23c-edc4ac30f4e1/_apis/git/repositories/3e42401e-931d-4a96-b4b9-3533d1cf56ce/pullRequests/70044/attachments/image%20(4).png )
**Note**: Version of _powerbi-models_ was set to 1.3.3 for validation only
## Checklist
| Checklist point | Yes/No/NA |
|------|---------------|
| Have you checked that code does not contain commented code? | Yes|
| Is unit testing is performed and results are captured in TFS/VSO? Is the list of test cases executed shared? | Test script successful|
| Is the open errors/ warning details shared with the reviewer? | Yes|
| Is the functionality validated? | Yes|
|Work items attached| Yes|
Related work items: #298854 , #310349 , #316025 , #316027 , #317740
2020-03-03 08:56:33 +00:00
Joseph Haddad
73c0a8cfbc
Merged PR 53197: Update karma
...
Update karma
Related work items: #205810
2019-10-28 14:41:00 +00:00
Joseph Haddad
f1d2e5c79a
Merged PR 52328: Update gulp to version 4.0 in PowerBI-Models
...
Update gulp to version 4.0 in PowerBI-Models
Related work items: #205807
2019-10-23 08:24:01 +00:00
Amit Shuster
d5fc11e9d1
models refactor v1.0.0 update
2017-10-03 17:27:36 +03:00
Amit Shuster
e3ae3d18e0
initial version of validators
2017-10-02 10:38:56 +03:00
Matt Mazzola
f515e24b8a
Remove configuration parameter from tslint:test task which incorrectly attempted to add a rule but instead set only a single rule which gave false positive lint passes.
2016-09-07 17:14:59 -07:00
Matt Mazzola
e86026c26a
Setup tslint on build and test to enforce good practices and consistent style. ( #9 )
...
* Setup tslint on build and test to enforce good practices and consistent style.
* Auto-format all files to use consistent tab size of 2.
2016-08-22 09:52:58 -07:00
Matt Mazzola
6903134e1e
Change documentation generation to include json file within docs directory. Fix documentation deployment by adding .nojekyll before publishing.
2016-07-14 11:08:29 -07:00
Matt Mazzola
c2466e3b75
Add gulp ghpages task to deploy docs to gh-pages
2016-07-13 09:57:31 -07:00
Matt Mazzola
806e4dc48b
Add gulp docs task to generate documentation
2016-07-13 09:56:25 -07:00
Matt Mazzola
9f5c30671e
Update header generation to use webpack Banner plugin to fix source maps
2016-06-29 18:19:27 -07:00
Matt Mazzola
5d7379f90f
Add header to distributed .js and .ts files which includes name, version, copyright, company, and license.
2016-06-24 12:57:24 -07:00
Matt Mazzola
f447b418ae
Add .min.js exclusion to minification task
2016-06-23 17:40:34 -07:00
Matt Mazzola
007428c15c
Install del and update gulp to clean dist and tmp directories before build and test respectively.
2016-06-23 11:34:44 -07:00
Matt Mazzola
07c5810efd
Fix package.json main and typings references, add fix tsconfigs
2016-06-23 11:34:44 -07:00
Matt Mazzola
392499903e
Initial Commit of powerbi-models. Has interfaces which are shared between host and iframe code.
2016-06-23 11:34:44 -07:00