From 581b5a01c8eb4ef9d87d9bf9307eb10aefa3ddd9 Mon Sep 17 00:00:00 2001 From: Ali Hamud Date: Thu, 16 May 2019 11:51:08 +0300 Subject: [PATCH] change class to interface --- .gitignore | 3 ++- src/powerbi-report-authoring.ts | 16 +++++++++++++--- tslint.json | 1 + 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 8349a57..e8c5320 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ node_modules dist -package-lock.json \ No newline at end of file +package-lock.json +*.tgz diff --git a/src/powerbi-report-authoring.ts b/src/powerbi-report-authoring.ts index 372770e..6cc8563 100644 --- a/src/powerbi-report-authoring.ts +++ b/src/powerbi-report-authoring.ts @@ -10,9 +10,17 @@ import { import { extensions } from './extensions'; import { IVisualResponse } from './models'; +/* + * Class Augmentation/Extension Notes: + * - No need for export: All declarations are implicitly exported in an ambient context + * - Class Augmentation works through interfaces in typescript. + */ + // Extend Report object declare module 'powerbi-client' { - export class Report { + + // See "Class Augmentation/Extension Notes" above. + interface Report { /** * Get a visual type capabilities * @@ -32,7 +40,8 @@ declare module 'powerbi-client' { // Extend Page object declare module 'powerbi-client' { - export class Page { + // See "Class Augmentation/Extension Notes" above. + interface Page { /** * Creates an empty visual of a specific type. * @@ -57,7 +66,8 @@ declare module 'powerbi-client' { // Extend Visual object declare module 'powerbi-client' { - export class VisualDescriptor { + // See "Class Augmentation/Extension Notes" above. + interface VisualDescriptor { /** * Changes the visual type of an existing visual. * diff --git a/tslint.json b/tslint.json index 15f3fdf..c2da341 100644 --- a/tslint.json +++ b/tslint.json @@ -1,6 +1,7 @@ { "extends": "tslint:recommended", "rules": { + "interface-name": [false], "max-classes-per-file": [false], "max-line-length": [false], "member-access": false,