This commit is contained in:
Andrey Dubov 2020-01-13 16:41:41 +03:00 коммит произвёл GitHub
Родитель 14810b71d7
Коммит 3bb71eac2b
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
2 изменённых файлов: 148 добавлений и 61 удалений

2
.github/ISSUE_TEMPLATE.md поставляемый
Просмотреть файл

@ -16,7 +16,7 @@ What actually happens?
### Reproducible Demo
* Download https://github.com/Microsoft/react-native-code-push/archive/master.zip and unzip. From `Examples` folder run `node create-app.js appName react-native@0.47.1 react-native-code-push@5.0.0-beta` command to generate plain CodePushified React Native app. Please see description on top of `create-app.js` file content if needed
* Download https://github.com/Microsoft/react-native-code-push/archive/master.zip and unzip. From `Examples` folder run `node create-app.js appName react-native@0.61.5 react-native-code-push@6.0.0` command to generate plain CodePushified React Native app. Please see description on top of `create-app.js` file content if needed
* If you can't reproduce the bug on it, provide us as much info as possible about your project
### Environment

Просмотреть файл

@ -3,13 +3,14 @@ The script serves to generate CodePushified React Native app to reproduce issues
Requirements:
1. npm i -g react-native-cli
2. npm i -g code-push-cli
3. code-push register
2. npm i -g appcenter-cli
3. appcenter login
(If you use this script on macOS for react-native v0.60+ then you need to have CocoaPods installed)
Usage: node create-app.js <appName> <reactNativeVersion> <reactNativeCodePushVersion>
1. node create-app.js
2. node create-app.js myapp
3. node create-app.js myapp react-native@0.47.1 react-native-code-push@5.0.0-beta
3. node create-app.js myapp react-native@0.61.5 react-native-code-push@6.0.0
4. node create-app.js myapp react-native@latest Microsoft/react-native-code-push
Parameters:
@ -18,14 +19,14 @@ Parameters:
3. <reactNativeCodePushVersion> - react-native-code-push@latest
*/
let fs = require('fs');
let path = require('path');
let nexpect = require('./nexpect');
let child_proces = require('child_process');
let execSync = child_proces.execSync;
const fs = require('fs');
const path = require('path');
const nexpect = require('./nexpect');
const child_process = require('child_process');
const execSync = child_process.execSync;
let args = process.argv.slice(2);
let appName = args[0] || 'CodePushDemoAppTest';
const args = process.argv.slice(2);
const appName = args[0] || 'CodePushDemoAppTest';
if (fs.existsSync(appName)) {
console.error(`Folder with name "${appName}" already exists! Please delete`);
@ -34,17 +35,18 @@ if (fs.existsSync(appName)) {
// Checking if yarn is installed
try {
execSync('yarn bin');
execCommand('yarn bin');
} catch (err) {
console.error(`You must install 'yarn' to use this script!`);
process.exit();
}
let appNameAndroid = `${appName}-android`;
let appNameIOS = `${appName}-ios`;
let reactNativeVersion = args[1] || `react-native@${execSync('npm view react-native version')}`.trim();
let reactNativeVersionIsLowerThanV049 = isReactNativeVesionLowerThan(49);
let reactNativeCodePushVersion = args[2] || `react-native-code-push@${execSync('npm view react-native-code-push version')}`.trim();
const appNameAndroid = `${appName}-android`;
const appNameIOS = `${appName}-ios`;
let owner = null;
const reactNativeVersion = args[1] || `react-native@${execCommand('npm view react-native version')}`.trim();
const reactNativeVersionIsLowerThanV049 = isReactNativeVersionLowerThan(49);
const reactNativeCodePushVersion = args[2] || `react-native-code-push@${execCommand('npm view react-native-code-push version')}`.trim();
console.log(`App name: ${appName}`);
console.log(`React Native version: ${reactNativeVersion}`);
@ -56,8 +58,8 @@ let iosStagingDeploymentKey = null;
//GENERATE START
createCodePushApp(appNameAndroid, 'android');
createCodePushApp(appNameIOS, 'ios');
createCodePushApp(appNameAndroid, 'Android');
createCodePushApp(appNameIOS, 'iOS');
generatePlainReactNativeApp(appName, reactNativeVersion);
process.chdir(appName);
@ -67,24 +69,28 @@ linkCodePush(androidStagingDeploymentKey, iosStagingDeploymentKey);
function createCodePushApp(name, platform) {
function createCodePushApp(name, os) {
try {
console.log(`Creating CodePush app "${name}" to release updates for ${platform}...`);
execSync(`code-push app add ${name} ${platform} react-native`);
console.log(`Creating CodePush app "${name}" to release updates for ${os}...`);
const appResult = execCommand(`appcenter apps create -d ${name} -n ${name} -o ${os} -p React-Native --output json`);
const app = JSON.parse(appResult);
owner = app.owner.name;
console.log(`App "${name}" has been created \n`);
execCommand(`appcenter codepush deployment add -a ${owner}/${name} Staging`);
} catch (e) {
console.log(`App "${name}" already exists \n`);
}
let deploymentKeys = JSON.parse(execSync(`code-push deployment ls ${name} -k --format json`));
let stagingDeploymentKey = deploymentKeys[1].key;
console.log(`Deployment key for ${platform}: ${stagingDeploymentKey}`);
console.log(`Use "code-push release-react ${name} ${platform}" command to release updates for ${platform} \n`);
const deploymentKeysResult = execCommand(`appcenter codepush deployment list -a ${owner}/${name} -k --output json`);
const deploymentKeys = JSON.parse(deploymentKeysResult);
const stagingDeploymentKey = deploymentKeys[0][1];
console.log(`Deployment key for ${os}: ${stagingDeploymentKey}`);
console.log(`Use "appcenter codepush release-react ${owner}/${name}" command to release updates for ${os} \n`);
switch (platform) {
case 'android':
switch (os) {
case 'Android':
androidStagingDeploymentKey = stagingDeploymentKey;
break;
case 'ios':
case 'iOS':
iosStagingDeploymentKey = stagingDeploymentKey;
break;
}
@ -92,32 +98,43 @@ function createCodePushApp(name, platform) {
function generatePlainReactNativeApp(appName, reactNativeVersion) {
console.log(`Installing React Native...`);
execSync(`react-native init ${appName} --version ${reactNativeVersion}`);
execCommand(`react-native init ${appName} --version ${reactNativeVersion}`);
console.log(`React Native has been installed \n`);
}
function installCodePush(reactNativeCodePushVersion) {
console.log(`Installing React Native Module for CodePush...`);
execSync(`yarn add ${reactNativeCodePushVersion}`);
execCommand(`yarn add ${reactNativeCodePushVersion}`);
console.log(`React Native Module for CodePush has been installed \n`);
}
function linkCodePush(androidStagingDeploymentKey, iosStagingDeploymentKey) {
console.log(`Linking React Native Module for CodePush...`);
nexpect.spawn(`react-native link react-native-code-push`)
.wait("What is your CodePush deployment key for Android (hit <ENTER> to ignore)")
.sendline(androidStagingDeploymentKey)
.wait("What is your CodePush deployment key for iOS (hit <ENTER> to ignore)")
.sendline(iosStagingDeploymentKey)
.run(function (err) {
if (!err) {
console.log(`React Native Module for CodePush has been linked \n`);
setupAssets();
}
else {
console.log(err);
}
});
if (isReactNativeVersionLowerThan(60)) {
nexpect.spawn(`react-native link react-native-code-push`)
.wait("What is your CodePush deployment key for Android (hit <ENTER> to ignore)")
.sendline(androidStagingDeploymentKey)
.wait("What is your CodePush deployment key for iOS (hit <ENTER> to ignore)")
.sendline(iosStagingDeploymentKey)
.run(function (err) {
if (!err) {
console.log(`React Native Module for CodePush has been linked \n`);
setupAssets();
}
else {
console.log(err);
}
});
} else {
androidSetup();
if (process.platform === 'darwin') {
iosSetup();
} else {
console.log('Your OS is not "Mac OS" so the iOS application will not be configured')
}
setupAssets();
console.log(`React Native Module for CodePush has been linked \n`);
}
}
function setupAssets() {
@ -142,7 +159,7 @@ function setupAssets() {
if (err) {
return console.error(err);
}
var result = data.replace(/CodePushDemoApp/g, appName);
const result = data.replace(/CodePushDemoApp/g, appName);
fs.writeFile(fileToEdit, result, 'utf8', function (err) {
if (err) return console.error(err);
@ -159,31 +176,31 @@ function setupAssets() {
}
function optimizeToTestInDebugMode() {
let rnXcodeShLocationFolder = 'scripts';
const rnXcodeShLocationFolder = 'scripts';
try {
let rnVersions = JSON.parse(execSync(`npm view react-native versions --json`));
let currentRNversion = JSON.parse(fs.readFileSync('./package.json'))['dependencies']['react-native'];
const rnVersions = JSON.parse(execCommand(`npm view react-native versions --json`));
const currentRNversion = JSON.parse(fs.readFileSync('./package.json'))['dependencies']['react-native'];
if (rnVersions.indexOf(currentRNversion) > -1 &&
rnVersions.indexOf(currentRNversion) < rnVersions.indexOf("0.46.0-rc.0")) {
rnXcodeShLocationFolder = 'packager';
}
} catch(e) {}
} catch (e) { }
let rnXcodeShPath = `node_modules/react-native/${rnXcodeShLocationFolder}/react-native-xcode.sh`;
const rnXcodeShPath = `node_modules/react-native/${rnXcodeShLocationFolder}/react-native-xcode.sh`;
// Replace "if [[ "$PLATFORM_NAME" == *simulator ]]; then" with "if false; then" to force bundling
execSync(`sed -ie 's/if \\[\\[ "\$PLATFORM_NAME" == \\*simulator \\]\\]; then/if false; then/' ${rnXcodeShPath}`);
execSync(`perl -i -p0e 's/#ifdef DEBUG.*?#endif/jsCodeLocation = [CodePush bundleURL];/s' ios/${appName}/AppDelegate.m`);
execSync(`sed -ie 's/targetName.toLowerCase().contains("release")/true/' node_modules/react-native/react.gradle`);
execCommand(`sed -ie 's/if \\[\\[ "\$PLATFORM_NAME" == \\*simulator \\]\\]; then/if false; then/' ${rnXcodeShPath}`);
execCommand(`perl -i -p0e 's/#ifdef DEBUG.*?#endif/jsCodeLocation = [CodePush bundleURL];/s' ios/${appName}/AppDelegate.m`);
execCommand(`sed -ie 's/targetName.toLowerCase().contains("release")/true/' node_modules/react-native/react.gradle`);
}
function grantAccess(folderPath) {
execSync('chown -R `whoami` ' + folderPath);
execCommand('chown -R `whoami` ' + folderPath);
}
function copyRecursiveSync(src, dest) {
var exists = fs.existsSync(src);
var stats = exists && fs.statSync(src);
var isDirectory = exists && stats.isDirectory();
const exists = fs.existsSync(src);
const stats = exists && fs.statSync(src);
const isDirectory = exists && stats.isDirectory();
if (exists && isDirectory) {
fs.mkdirSync(dest);
fs.readdirSync(src).forEach(function (childItemName) {
@ -195,12 +212,82 @@ function copyRecursiveSync(src, dest) {
}
}
function isReactNativeVesionLowerThan(version) {
function isReactNativeVersionLowerThan(version) {
if (!reactNativeVersion ||
reactNativeVersion == "react-native@latest" ||
reactNativeVersion == "react-native@next")
return false;
let reactNativeVersionNumberString = reactNativeVersion.split("@")[1];
const reactNativeVersionNumberString = reactNativeVersion.split("@")[1];
return reactNativeVersionNumberString.split('.')[1] < version;
}
}
// Configuring android applications for react-native version higher than 0.60
function androidSetup() {
const buildGradlePath = path.join('android', 'app', 'build.gradle');
const mainApplicationPath = path.join('android', 'app', 'src', 'main', 'java', 'com', appName, 'MainApplication.java');
const stringsResourcesPath = path.join('android', 'app', 'src', 'main', 'res', 'values', 'strings.xml');
let stringsResourcesContent = fs.readFileSync(stringsResourcesPath, "utf8");
const insertAfterString = "<resources>";
const deploymentKeyString = `\t<string moduleConfig="true" name="CodePushDeploymentKey">${androidStagingDeploymentKey || "deployment-key-here"}</string>`;
stringsResourcesContent = stringsResourcesContent.replace(insertAfterString, `${insertAfterString}\n${deploymentKeyString}`);
fs.writeFileSync(stringsResourcesPath, stringsResourcesContent);
let buildGradleContents = fs.readFileSync(buildGradlePath, "utf8");
const reactGradleLink = buildGradleContents.match(/\napply from: ["'].*?react\.gradle["']/)[0];
const codePushGradleLink = `\napply from: "../../node_modules/react-native-code-push/android/codepush.gradle"`;
buildGradleContents = buildGradleContents.replace(reactGradleLink,
`${reactGradleLink}${codePushGradleLink}`);
fs.writeFileSync(buildGradlePath, buildGradleContents);
const getJSBundleFileOverride = `
@Override
protected String getJSBundleFile(){
return CodePush.getJSBundleFile();
}
`;
let mainApplicationContents = fs.readFileSync(mainApplicationPath, "utf8");
const reactNativeHostInstantiation = "new ReactNativeHost(this) {";
mainApplicationContents = mainApplicationContents.replace(reactNativeHostInstantiation,
`${reactNativeHostInstantiation}${getJSBundleFileOverride}`);
const importCodePush = `\nimport com.microsoft.codepush.react.CodePush;`;
const reactNativeHostInstantiationImport = "import android.app.Application;";
mainApplicationContents = mainApplicationContents.replace(reactNativeHostInstantiationImport,
`${reactNativeHostInstantiationImport}${importCodePush}`);
fs.writeFileSync(mainApplicationPath, mainApplicationContents);
}
// Configuring ios applications for react-native version higher than 0.60
function iosSetup() {
const plistPath = path.join('ios', appName, 'Info.plist');
const appDelegatePath = path.join('ios', appName, 'AppDelegate.m');
let plistContents = fs.readFileSync(plistPath, "utf8");
const falseInfoPlist = `<false/>`;
const codePushDeploymentKey = iosStagingDeploymentKey || 'deployment-key-here';
plistContents = plistContents.replace(falseInfoPlist,
`${falseInfoPlist}\n\t<key>CodePushDeploymentKey</key>\n\t<string>${codePushDeploymentKey}</string>`);
fs.writeFileSync(plistPath, plistContents);
let appDelegateContents = fs.readFileSync(appDelegatePath, "utf8");
const appDelegateHeaderImportStatement = `#import "AppDelegate.h"`;
const codePushHeaderImportStatementFormatted = `\n#import <CodePush/CodePush.h>`;
appDelegateContents = appDelegateContents.replace(appDelegateHeaderImportStatement,
`${appDelegateHeaderImportStatement}${codePushHeaderImportStatementFormatted}`);
const oldBundleUrl = "[[NSBundle mainBundle] URLForResource:@\"main\" withExtension:@\"jsbundle\"]";
const codePushBundleUrl = "[CodePush bundleURL]";
appDelegateContents = appDelegateContents.replace(oldBundleUrl, codePushBundleUrl);
fs.writeFileSync(appDelegatePath, appDelegateContents);
execCommand(`cd ios && pod install && cd ..`);
}
function execCommand(command) {
console.log(`\n\x1b[2m${command}\x1b[0m\n`);
const result = execSync(command).toString();
return result;
}