2019-02-22 05:22:05 +03:00
|
|
|
|
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
|
|
|
|
#
|
|
|
|
|
|
# This source code is licensed under the MIT license found in the
|
|
|
|
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
|
|
|
|
|
|
|
|
require "json"
|
|
|
|
|
|
|
|
|
|
|
|
package = JSON.parse(File.read(File.join(__dir__, "..", "..", "package.json")))
|
|
|
|
|
|
version = package['version']
|
|
|
|
|
|
|
|
|
|
|
|
source = { :git => 'https://github.com/facebook/react-native.git' }
|
|
|
|
|
|
if version == '1000.0.0'
|
|
|
|
|
|
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
|
|
|
|
|
source[:commit] = `git rev-parse HEAD`.strip
|
|
|
|
|
|
else
|
|
|
|
|
|
source[:tag] = "v#{version}"
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
|
|
folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
|
2020-01-21 23:41:45 +03:00
|
|
|
|
folly_version = '2020.01.13.00'
|
2019-02-22 05:22:05 +03:00
|
|
|
|
boost_compiler_flags = '-Wno-documentation'
|
|
|
|
|
|
|
|
|
|
|
|
Pod::Spec.new do |s|
|
|
|
|
|
|
s.name = "React-cxxreact"
|
|
|
|
|
|
s.version = version
|
|
|
|
|
|
s.summary = "-" # TODO
|
2020-02-25 00:06:47 +03:00
|
|
|
|
s.homepage = "https://reactnative.dev/"
|
2019-02-22 05:22:05 +03:00
|
|
|
|
s.license = package["license"]
|
|
|
|
|
|
s.author = "Facebook, Inc. and its affiliates"
|
2020-01-02 23:49:45 +03:00
|
|
|
|
s.platforms = { :ios => "10.0", :tvos => "10.0" }
|
2019-02-22 05:22:05 +03:00
|
|
|
|
s.source = source
|
|
|
|
|
|
s.source_files = "*.{cpp,h}"
|
|
|
|
|
|
s.exclude_files = "SampleCxxModule.*"
|
|
|
|
|
|
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
|
2019-07-10 20:18:03 +03:00
|
|
|
|
s.pod_target_xcconfig = { "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost-for-react-native\" \"$(PODS_ROOT)/Folly\" \"$(PODS_ROOT)/DoubleConversion\"" }
|
2019-02-22 05:22:05 +03:00
|
|
|
|
s.header_dir = "cxxreact"
|
|
|
|
|
|
|
|
|
|
|
|
s.dependency "boost-for-react-native", "1.63.0"
|
|
|
|
|
|
s.dependency "DoubleConversion"
|
|
|
|
|
|
s.dependency "Folly", folly_version
|
|
|
|
|
|
s.dependency "glog"
|
|
|
|
|
|
s.dependency "React-jsinspector", version
|
Get CallInvokers from the bridge
Summary:
## Context
For now, assume TurboModules doesn't exist.
**What happens when we call an async NativeModule method?**
Everytime JS calls an async NativeModule method, we don't immediately execute it. The legacy infra pushes the call into some queue managed by `MessageQueue.js`. This queue is "flushed" or "emptied" by the following events:
- **Flushed:** A C++ -> JS call. NativeModule async methods can called with an `onSuccess` and/or `onFail` callback(s). Calling `NativeToJsBridge::invokeCallback` to invoke one of these callbacks is one way for ObjC++/C++/Java to call into JS. Another way is via JSModule method calls, which are initiated by `NativeToJsBridge::callFunction`.
- **Flushed:** When `JSIExecutor::flush` is called. Since TurboModules don't exist, this only happens when we call `JSIExecutor::loadApplicationScript`.
- **Emptied:** When more than 5 ms have passed, and the queue hasn't been flushed/emptied, on the next async NativeModule method call, we add to the queue. Afterwards, we empty it, and invoke all the NativeModule method calls.
**So, what's the difference between flushed and emptied?**
> Note: These are two terms I just made up, but the distinction is important.
If the queue was "flushed", and it contained at least one NativeModule method call, `JsToNativeBridge` dispatches the `onBatchComplete` event. On Android, the UIManager module is the only module that listens to this event. This `onBatchComplete` event doesn't fire if the queue was "emptied".
**Why does any of this matter?**
1. TurboModules exist.
2. We need the TurboModules infra to have `JsToNativeBridge` dispatch `onBatchComplete`, which depends on:
- **Problem 1:** The queue being flushed on calls into JS from Java/C++/ObjC++.
- **Problem 2:** There being queued up NativeModule async method calls when the queue is flushed.
In D14656466, fkgozali fixed Problem 1 by making every C++/Java/Obj -> JS call from TurboModules also execute `JSIExecutor::flush()`. This means that, with TurboModules, we flush the NativeModule async method call queue as often as we do without TurboModules. So far, so good. However, we still have one big problem: As we convert more NativeModules to TurboModules, the average size of the queue of NativeModule method calls will become smaller and smaller, because more NativeModule method calls will be TurboModule method calls. This queue will more often be empty than not. Therefore, we'll end up dispatching the `onBatchComplete` event less often with TurboModules enabled. So, somehow, when we're about to flush the NativeModule method call queue, we need `JsToNativeBridge` to understand that we've executed TurboModule method calls in the batch. These calls would have normally been queued, which would have led the queue size to be non-zero. So if, during a batch, some TurboModule async method calls were executed, `JsToNativeBridge` should dispatch `onBatchComplete`.
**So, what does this diff do?**
1. Make `Instance` responsible for creating the JS `CallInvoker`.
2. Make `NativeToJsBridge` responsible for creating the native `CallInvoker`. `Instance` calls into `NativeToJsBridge` to get the native `CallInvoker`.
3. Hook up `CatalystInstanceImpl`, the Android bridge, with the new JS `CallInvoker`, and the new native `CallInvoker`. This fixes `onBatchComplete` on Android. iOS work is pending.
Changelog:
[Android][Fixed] - Ensure `onBatchComplete` is dispatched correctly with TurboModules
Reviewed By: mdvacca
Differential Revision: D20717931
fbshipit-source-id: bc3ccbd6c135b7f084edbc6ddb4d1e3c0c7e0875
2020-04-01 21:36:50 +03:00
|
|
|
|
s.dependency "React-callinvoker", version
|
2019-02-22 05:22:05 +03:00
|
|
|
|
end
|
