react-native-macos/bots/dangerfile.js

115 строки
5.0 KiB
JavaScript
Исходник Обычный вид История

Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
*/
'use strict';
const {danger, fail, message, warn} = require('danger');
Bots cleanup, avoid leaving inline reviews when N>5 (#24923) Summary: This PR cleans up some of our GitHub bots. The overall goal is to make the contribution process just a tad nicer. ### analysis-bot * The bot will continue leaving GitHub Reviews when it finds lint issues, but will abstain from leaving inline comments if they would exceed 5 in number. * The review comment left by the bot has instructions on how to reproduce the lint issues locally. This will educate PR authors on how to run lint and fix the issues without unnecessarily spamming the PR with 50+ comments, while still providing useful reviews to authors when only a handful of lint issues slip by. * Code moved to `bots/` directory for ease of discovery and co-location with pull-bot. * Added `yarn lint-ci` command. This seems like the right choice: it's running `yarn lint` and other linters, and it is only intended to run on CI. * It's still possible to run `yarn lint-ci` locally, though the script will stop short of posting a review to GitHub unless the necessary envvars are provided. * Added `yarn shellcheck` command. This can be run locally, though it requires `shellcheck` to be installed. * Outside of this PR, I added instructions on using shellcheck to https://github.com/facebook/react-native/wiki/Development-Dependencies * Updated Circle CI config to use these new commands, and streamlined the `analyze_pr` step. * Documented analysis-bot in `bots/README.md`. ### pull-bot * Bumped `danger-js` dependency. No breaking changes found in this minor bump from what I can tell. * Documented pull-bot in `bots/README.md`. ### misc * PR template: don't use jargon. ## Changelog [Internal] [Changed] - GitHub Bots cleanup Pull Request resolved: https://github.com/facebook/react-native/pull/24923 Differential Revision: D15399744 Pulled By: hramos fbshipit-source-id: 32632e775f8554424072270e3f98542de84bfb8c
2019-05-22 05:35:40 +03:00
const includes = require('lodash.includes');
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
const isFromPhabricator =
danger.github.pr.body &&
danger.github.pr.body.toLowerCase().includes('differential revision:');
// Provides advice if a summary section is missing, or body is too short
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
const includesSummary =
danger.github.pr.body &&
danger.github.pr.body.toLowerCase().includes('## summary');
if (!danger.github.pr.body || danger.github.pr.body.length < 50) {
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
fail(':grey_question: This pull request needs a description.');
} else if (!includesSummary && !isFromPhabricator) {
// PRs from Phabricator always includes the Summary by default.
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
const title = ':clipboard: Missing Summary';
const idea =
'Can you add a Summary? ' +
'To do so, add a "## Summary" section to your PR description. ' +
'This is a good place to explain the motivation for making this change.';
message(`${title} - <i>${idea}</i>`);
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
}
// Warns if there are changes to package.json, and tags the team.
const packageChanged = includes(danger.git.modified_files, 'package.json');
if (packageChanged) {
Flag large pull requests, add large-pr command Summary: We sometimes get large PRs that sit for a long time without being reviewed. In some cases, the PR touches too many files or lines, and the author would benefit from splitting the PR into smaller easier-to-review PRs. In this PR, we automatically flag such PRs using the existing Danger PR automation functionality. This PR achieves the objective by doing the following: * Add facebook-open-source-bot to `IssueCommands.txt`, allowing it to add labels and close issues/PRs via facebook-github-bot commands. * Adds a `large-pr` command to facebook-github-bot. This command will add a short blurb, apply a new "Large PR" label, and close the PR. * Updates the Dangerfile to check for PRs that touch over 600 lines and/or files. In such cases it will warn and then issue the large-pr command. Additional changes: * Tag core contributor PRs with the "Core Team" label. This is a slight change in policy, in that the label used to be applied after the fact (after the PR was escalated for review). It's more convenient to monitor labels, so we'll start checking for PRs tagged as such and ensure they get escalated as needed. cc skevy Thanks to TheSavior for suggesting this change. Testing against PR #10084 which touches over 600 lines: ``` $ cd danger $ DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger pr https://github.com/facebook/react-native/pull/10084 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/10084" { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" }, { message: ":exclamation: Big PR - <i>This PR is extremely unlikely to get reviewed because it touches 613 lines.</i>" } ], messages: [], markdowns: ["facebook-github-bot label Needs more information", "facebook-github-bot large-pr"] } ``` Result: successfully flagged as being a large PR. Closes https://github.com/facebook/react-native/pull/15519 Differential Revision: D5647085 Pulled By: hramos fbshipit-source-id: dfa0f6580b9373085eba856de257a8d2452efbdc
2017-08-17 06:55:18 +03:00
const title = ':lock: package.json';
const idea =
'Changes were made to package.json. ' +
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
'This will require a manual import by a Facebook employee.';
Flag large pull requests, add large-pr command Summary: We sometimes get large PRs that sit for a long time without being reviewed. In some cases, the PR touches too many files or lines, and the author would benefit from splitting the PR into smaller easier-to-review PRs. In this PR, we automatically flag such PRs using the existing Danger PR automation functionality. This PR achieves the objective by doing the following: * Add facebook-open-source-bot to `IssueCommands.txt`, allowing it to add labels and close issues/PRs via facebook-github-bot commands. * Adds a `large-pr` command to facebook-github-bot. This command will add a short blurb, apply a new "Large PR" label, and close the PR. * Updates the Dangerfile to check for PRs that touch over 600 lines and/or files. In such cases it will warn and then issue the large-pr command. Additional changes: * Tag core contributor PRs with the "Core Team" label. This is a slight change in policy, in that the label used to be applied after the fact (after the PR was escalated for review). It's more convenient to monitor labels, so we'll start checking for PRs tagged as such and ensure they get escalated as needed. cc skevy Thanks to TheSavior for suggesting this change. Testing against PR #10084 which touches over 600 lines: ``` $ cd danger $ DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger pr https://github.com/facebook/react-native/pull/10084 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/10084" { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" }, { message: ":exclamation: Big PR - <i>This PR is extremely unlikely to get reviewed because it touches 613 lines.</i>" } ], messages: [], markdowns: ["facebook-github-bot label Needs more information", "facebook-github-bot large-pr"] } ``` Result: successfully flagged as being a large PR. Closes https://github.com/facebook/react-native/pull/15519 Differential Revision: D5647085 Pulled By: hramos fbshipit-source-id: dfa0f6580b9373085eba856de257a8d2452efbdc
2017-08-17 06:55:18 +03:00
warn(`${title} - <i>${idea}</i>`);
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
}
// Provides advice if a test plan is missing.
const includesTestPlan =
danger.github.pr.body &&
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
danger.github.pr.body.toLowerCase().includes('## test plan');
if (!includesTestPlan && !isFromPhabricator) {
// PRs from Phabricator never exports the Test Plan so let's disable this check.
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
const title = ':clipboard: Missing Test Plan';
const idea =
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
'Can you add a Test Plan? ' +
'To do so, add a "## Test Plan" section to your PR description. ' +
'A Test Plan lets us know how these changes were tested.';
message(`${title} - <i>${idea}</i>`);
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
}
// Regex looks for given categories, types, a file/framework/component, and a message - broken into 4 capture groups
const changelogRegex =
/\[\s?(ANDROID|GENERAL|IOS|JS|JAVASCRIPT|INTERNAL)\s?\]\s?\[\s?(ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY)\s?\]\s*?-?\s*?(.*)/gi;
const internalChangelogRegex = /\[\s?(INTERNAL)\s?\].*/gi;
const includesChangelog =
danger.github.pr.body &&
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
(danger.github.pr.body.toLowerCase().includes('## changelog') ||
danger.github.pr.body.toLowerCase().includes('release notes') ||
// PR exports from Phabricator have a `Changelog:` entry for the changelog.
danger.github.pr.body.toLowerCase().includes('changelog:'));
const correctlyFormattedChangelog = changelogRegex.test(danger.github.pr.body);
const containsInternalChangelog = internalChangelogRegex.test(
danger.github.pr.body,
);
// Provides advice if a changelog is missing
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
const changelogInstructions =
'A changelog entry has the following format: `[CATEGORY] [TYPE] - Message`.\n\n<details>CATEGORY may be:\n\n- General\n- iOS\n- Android\n- JavaScript\n- Internal (for changes that do not need to be called out in the release notes)\n\nTYPE may be:\n\n- Added, for new features.\n- Changed, for changes in existing functionality.\n- Deprecated, for soon-to-be removed features.\n- Removed, for now removed features.\n- Fixed, for any bug fixes.\n- Security, in case of vulnerabilities.\n\nMESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.</details>';
if (!includesChangelog) {
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
const title = ':clipboard: Missing Changelog';
const idea =
Adjust pull-bot configuration for new PR template (#23236) Summary: The updated Dangerfile config lets pull-bot warn when the PR lacks a Summary, on top of the existing Test Plan and Changelog warnings. It will also be a bit more lenient when it comes to the changelog, making the `-` optional after TYPE. Finally, I removed the "large PR" warning. We haven't had a problem with large PRs recently, and I feel we can deal with these on a case by case basis. [GENERAL] [Changed] Adjust pull-bot to handle new PR template. Tested against this PR (note the non-standard section titles): ``` $ yarn $ yarn danger pr https://github.com/facebook/react-native/pull/23236 :clipboard: Missing Summary - <i>Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.</i> - :clipboard: Missing Test Plan - <i>Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.</i> - :clipboard: Missing Changelog - <i>Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [`[CATEGORY] [TYPE] - Message`](http://facebook.github.io/react-native/docs/contributing#changelog).</i> Found only warnings, not failing the build ✨ Done in 4.86s. ``` Pull Request resolved: https://github.com/facebook/react-native/pull/23236 Differential Revision: D13915716 Pulled By: cpojer fbshipit-source-id: 6f1c3e67140c14359fc369b36b900aedf9a3bd8a
2019-02-01 13:47:05 +03:00
'Can you add a Changelog? ' +
'To do so, add a "## Changelog" section to your PR description. ' +
changelogInstructions;
message(`${title} - <i>${idea}</i>`);
} else if (!correctlyFormattedChangelog && !containsInternalChangelog) {
const title = ':clipboard: Verify Changelog Format';
const idea = changelogInstructions;
message(`${title} - <i>${idea}</i>`);
Adds Danger support Summary: Testing Danger support in CI. Continuation of #14964, which Circle stopped building. Update your node modules first: `npm install` `npm run danger pr https://github.com/facebook/react-native/pull/14951` Verify output. This PR should trigger a WIP warning, as well as a package.json warning: ``` > react-native@1000.0.0 danger /Users/hramos/git/react-native > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14951" { fails: [], warnings: [ { message: ":construction_worker: Work In Progress - <i>Do not merge yet.</i>" }, { message: ":lock: Changes were made to package.json - <i>This will require a manual import. Once approved, a Facebook employee should import the PR, then run `yarn add` for any new packages.</i>" } ], messages: [], markdowns: ["This PR requires attention from the facebook/react-native team."] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/14946` Verify output. This PR should trigger a warning against the lack of a test plan (note that the PR does have a test plan, but it does not title it as such): ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan</i>" } ], messages: [], markdowns: [] } ``` `npm run danger pr https://github.com/facebook/react-native/pull/13186` Should warn against a missing test plan: ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` If the author is able to issue bot commands, we reasonably assume that this is coming from an established core contributor. Their PRs will be flagged for expedited review: `npm run danger pr https://github.com/facebook/react-native/pull/14895` ``` { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" } ], messages: [], markdowns: ["This PR has been submitted by a core contributor. Notifying facebook/react-native."] } ``` Closes https://github.com/facebook/react-native/pull/15061 Differential Revision: D5436605 Pulled By: hramos fbshipit-source-id: 4ba9e812387d8a69893dab537af9b6cd108753cf
2017-07-18 21:08:35 +03:00
}
Warn if base !== master, tag CODEOWNERS Summary: The following PR modifies the Danger rules in the following way: 1. Verifies if a PR is opened against master. If not, it will warn (if opened against stable) or fail (anything else). 2. No longer adds a markdown message tagging the facebook/react-native team, as the bot does not have the necessary scope to mention the team. 3. Mentions people that have marked themselves as interested in a file, when that file is modified. This is based off CODEOWNERS. The bot should be able to use mentions here as it will act as any other regular user. Verify it tags the right people in https://github.com/facebook/react-native/pull/15139 ``` $ npm run danger pr https://github.com/facebook/react-native/pull/15139 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15139" { fails: [], warnings: [], messages: [], markdowns: ["Attention: grabbou, kureev"] } ``` It should not tag anyone for https://github.com/facebook/react-native/pull/15175: ``` $ npm run danger pr https://github.com/facebook/react-native/pull/15175 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15175" { fails: [], warnings: [], messages: [], markdowns: [] } ``` It should warn on https://github.com/facebook/react-native/pull/14640 as it targets 0.45-stable: ``` $ npm run danger pr https://github.com/facebook/react-native/pull/14640 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14640" { fails: [], warnings: [ { message: ":grey_question: Base Branch - <i>The base branch for this PR is something other than `master`. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on `master` first and then cherry-pick the commits into the branch for that release. The [Releases Guide](https://github.com/facebook/react-native/blob/master/Releases.md) has more information.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` It should not warn on https://github.com/facebook/react-native/pull/15175 because it targets master. ``` $ npm run danger pr https://github.com/facebook/react-native/pull/15175 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15175" { fails: [], warnings: [], messages: [], markdowns: [] } ``` Closes https://github.com/facebook/react-native/pull/15179 Differential Revision: D5490047 Pulled By: hramos fbshipit-source-id: a46a23b7d0a59d12b8039746d6e9c4399ef32d5f
2017-07-25 22:14:41 +03:00
// Warns if the PR is opened against stable, as commits need to be cherry picked and tagged by a release maintainer.
// Fails if the PR is opened against anything other than `main` or `-stable`.
const isMergeRefMain = danger.github.pr.base.ref === 'main';
const isMergeRefStable = danger.github.pr.base.ref.indexOf('-stable') !== -1;
if (!isMergeRefMain && !isMergeRefStable) {
Flag large pull requests, add large-pr command Summary: We sometimes get large PRs that sit for a long time without being reviewed. In some cases, the PR touches too many files or lines, and the author would benefit from splitting the PR into smaller easier-to-review PRs. In this PR, we automatically flag such PRs using the existing Danger PR automation functionality. This PR achieves the objective by doing the following: * Add facebook-open-source-bot to `IssueCommands.txt`, allowing it to add labels and close issues/PRs via facebook-github-bot commands. * Adds a `large-pr` command to facebook-github-bot. This command will add a short blurb, apply a new "Large PR" label, and close the PR. * Updates the Dangerfile to check for PRs that touch over 600 lines and/or files. In such cases it will warn and then issue the large-pr command. Additional changes: * Tag core contributor PRs with the "Core Team" label. This is a slight change in policy, in that the label used to be applied after the fact (after the PR was escalated for review). It's more convenient to monitor labels, so we'll start checking for PRs tagged as such and ensure they get escalated as needed. cc skevy Thanks to TheSavior for suggesting this change. Testing against PR #10084 which touches over 600 lines: ``` $ cd danger $ DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger pr https://github.com/facebook/react-native/pull/10084 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/10084" { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" }, { message: ":exclamation: Big PR - <i>This PR is extremely unlikely to get reviewed because it touches 613 lines.</i>" } ], messages: [], markdowns: ["facebook-github-bot label Needs more information", "facebook-github-bot large-pr"] } ``` Result: successfully flagged as being a large PR. Closes https://github.com/facebook/react-native/pull/15519 Differential Revision: D5647085 Pulled By: hramos fbshipit-source-id: dfa0f6580b9373085eba856de257a8d2452efbdc
2017-08-17 06:55:18 +03:00
const title = ':exclamation: Base Branch';
const idea =
'The base branch for this PR is something other than `main` or a `-stable` branch. [Are you sure you want to target something other than the `main` branch?](https://reactnative.dev/docs/contributing#pull-requests)';
Flag large pull requests, add large-pr command Summary: We sometimes get large PRs that sit for a long time without being reviewed. In some cases, the PR touches too many files or lines, and the author would benefit from splitting the PR into smaller easier-to-review PRs. In this PR, we automatically flag such PRs using the existing Danger PR automation functionality. This PR achieves the objective by doing the following: * Add facebook-open-source-bot to `IssueCommands.txt`, allowing it to add labels and close issues/PRs via facebook-github-bot commands. * Adds a `large-pr` command to facebook-github-bot. This command will add a short blurb, apply a new "Large PR" label, and close the PR. * Updates the Dangerfile to check for PRs that touch over 600 lines and/or files. In such cases it will warn and then issue the large-pr command. Additional changes: * Tag core contributor PRs with the "Core Team" label. This is a slight change in policy, in that the label used to be applied after the fact (after the PR was escalated for review). It's more convenient to monitor labels, so we'll start checking for PRs tagged as such and ensure they get escalated as needed. cc skevy Thanks to TheSavior for suggesting this change. Testing against PR #10084 which touches over 600 lines: ``` $ cd danger $ DANGER_GITHUB_API_TOKEN="e622517d9f1136ea8900""07c6373666312cdfaa69" npm run danger pr https://github.com/facebook/react-native/pull/10084 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/10084" { fails: [], warnings: [ { message: ":clipboard: Test Plan - <i>This PR appears to be missing a Test Plan.</i>" }, { message: ":exclamation: Big PR - <i>This PR is extremely unlikely to get reviewed because it touches 613 lines.</i>" } ], messages: [], markdowns: ["facebook-github-bot label Needs more information", "facebook-github-bot large-pr"] } ``` Result: successfully flagged as being a large PR. Closes https://github.com/facebook/react-native/pull/15519 Differential Revision: D5647085 Pulled By: hramos fbshipit-source-id: dfa0f6580b9373085eba856de257a8d2452efbdc
2017-08-17 06:55:18 +03:00
fail(`${title} - <i>${idea}</i>`);
Warn if base !== master, tag CODEOWNERS Summary: The following PR modifies the Danger rules in the following way: 1. Verifies if a PR is opened against master. If not, it will warn (if opened against stable) or fail (anything else). 2. No longer adds a markdown message tagging the facebook/react-native team, as the bot does not have the necessary scope to mention the team. 3. Mentions people that have marked themselves as interested in a file, when that file is modified. This is based off CODEOWNERS. The bot should be able to use mentions here as it will act as any other regular user. Verify it tags the right people in https://github.com/facebook/react-native/pull/15139 ``` $ npm run danger pr https://github.com/facebook/react-native/pull/15139 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15139" { fails: [], warnings: [], messages: [], markdowns: ["Attention: grabbou, kureev"] } ``` It should not tag anyone for https://github.com/facebook/react-native/pull/15175: ``` $ npm run danger pr https://github.com/facebook/react-native/pull/15175 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15175" { fails: [], warnings: [], messages: [], markdowns: [] } ``` It should warn on https://github.com/facebook/react-native/pull/14640 as it targets 0.45-stable: ``` $ npm run danger pr https://github.com/facebook/react-native/pull/14640 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/14640" { fails: [], warnings: [ { message: ":grey_question: Base Branch - <i>The base branch for this PR is something other than `master`. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on `master` first and then cherry-pick the commits into the branch for that release. The [Releases Guide](https://github.com/facebook/react-native/blob/master/Releases.md) has more information.</i>" } ], messages: [], markdowns: [":page_facing_up: Thanks for your contribution to the docs!"] } ``` It should not warn on https://github.com/facebook/react-native/pull/15175 because it targets master. ``` $ npm run danger pr https://github.com/facebook/react-native/pull/15175 > @ danger /Users/hramos/git/react-native/danger > node ./node_modules/.bin/danger "pr" "https://github.com/facebook/react-native/pull/15175" { fails: [], warnings: [], messages: [], markdowns: [] } ``` Closes https://github.com/facebook/react-native/pull/15179 Differential Revision: D5490047 Pulled By: hramos fbshipit-source-id: a46a23b7d0a59d12b8039746d6e9c4399ef32d5f
2017-07-25 22:14:41 +03:00
}
// If the PR is opened against stable should add `Pick Request` label
if (isMergeRefStable) {
const {owner, repo, number: issueNumber} = danger.github.thisPR;
danger.github.api.request(
'POST /repos/{owner}/{repo}/issues/{issueNumber}/labels',
{
owner,
repo,
issueNumber,
labels: ['Pick Request'],
},
);
}