react-native-macos/.editorconfig

# EditorConfig is awesome: https://EditorConfig.org

# top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf
insert_final_newline = true
indent_style = space
indent_size = 2

[*.gradle]
indent_size = 4

[BUCK]
indent_size = 4

# Windows files
[*.bat]
end_of_line = crlf
https link to EditorConfig.org (#25267) Summary: HTTPS is good and this prevents a HTTP redirect ## Changelog [Internal] [Fixed] - https link to EditorConfig.org Pull Request resolved: https://github.com/facebook/react-native/pull/25267 Differential Revision: D15873696 Pulled By: cpojer fbshipit-source-id: 2d769fe163816c75d1461d09837ec9c06a929e04 2019-06-18 11:54:38 +03:00			`# EditorConfig is awesome: https://EditorConfig.org`
Create .editorconfig 2015-10-10 00:34:00 +03:00
			`# top-most EditorConfig file`
			`root = true`

			`# Unix-style newlines with a newline ending every file`
			`[*]`
			`end_of_line = lf`
			`insert_final_newline = true`
			`indent_style = space`
			`indent_size = 2`
Fix indent of .gradle files Summary: In most .gradle files, lines are indented with 4 spaces, but in some places they are indented with 2 spaces. This PR fixes them and enforce it by adding .editorconfig settings. Closes https://github.com/facebook/react-native/pull/10267 Differential Revision: D4048335 Pulled By: lacker fbshipit-source-id: df2f2556380f56672cf85690eb1c80e640a6aedf 2016-10-20 02:50:39 +03:00
			`[*.gradle]`
			`indent_size = 4`
editorconfig: Set indent_size for BUCK files to 4 (#21554) Summary: The `BUCK` build files' indentation are 4 spaces large. This PR adds a small modification to `.editorconfig` to reflect that. Especially important for them, because an improperly indented line would be a syntax error. Pull Request resolved: https://github.com/facebook/react-native/pull/21554 Differential Revision: D10247954 Pulled By: TheSavior fbshipit-source-id: 98596a563e9f8c36060cd8aa702757eff230c4c3 2018-10-09 09:15:35 +03:00
			`[BUCK]`
			`indent_size = 4`
Fixing the git attrs for all the people and all the files and all future (#31128) Summary: We have had problems with `.gitattributes`, `.bat` and `.pbxproj` (Xcode) files for a while. The two main concerns were: - Xcode project files not diffing correctly. - Windows files having messed up line endings. This PR fixes both issues, hopefully forever. After seeing the diffs from v0.63 -> v0.64 and the changes in https://github.com/facebook/react-native/pull/29792, I, again, felt that this is going to cause problems, so I looked into both issues. I started with `git check-attr -a Artsy.xcodeproj/project.pbxproj` after removing the `.gitattributes` file that contained `.pbxproj -text` and there are no "guessed" attributes that would break things, and diffing and checking in worked well with the current git version. I agree this is not needed, so I left it out. I looked into what it was doing before, and it was telling git (for the xcode project file) to "unset text", which means (according to https://git-scm.com/docs/gitattributes#_text) that it should not try to do any line ending changes when checking in that file. At some point git must have done this, and that's why it was needed, but no more, so it's safe and good to get rid of this, as it helps with nothing anymore. Now for the bat files. We don't need any extra instructions for `gradle` and `.sh` files as they are guessed correctly, so these are also safe to keep removed (https://github.com/facebook/react-native/pull/29792/files#diff-618cd5b83d62060ba3d027e314a21ceaf75d36067ff820db126642944145393eL5). But we do need the `.bat` instruction. I noticed that when working on macOS there were two problems that made things funky. - One, is that the editor (usually vscode but not the important) would convert line endings to lf when editing a bat file. - Two, is that git thought the files are lf line endings. To fix the first one, I added a rule in `.editorconfig` (that's whats important, when any editor just supports editorconfig, but all my editors do). I can't believe how we missed that for sooooo long {emoji:1f605}! To fix the second, I added the `.gitattributes` instruction and* `renormalize`d the files (https://git-scm.com/docs/git-add#Documentation/git-add.txt---renormalize and https://docs.github.com/en/github/using-git/configuring-git-to-handle-line-endings#refreshing-a-repository-after-changing-line-endings). I think the problem all along was that even though the files had crlf, git still thought they were using lf. After the editorconfig change and the renormalization, everything behaves correctly and as expected. Changing bat files on macOS and Windows is fine now, producing only the smallest change needed, no random line ending diffs. Also here is a screenshot of one of the files actually crlf. It's these tiny things at the end of each line {emoji:1f453}. <img width="612" alt="Screenshot 2021-03-10 at 12 20 28" src="https://user-images.githubusercontent.com/100233/110630943-ef536280-819d-11eb-9212-dbd70f038a44.png"> I have tested this on macOS and Windows, doing changes in both bat and xcode files, and verified that diffing and checking in files works well. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Added] - Added an `.editorconfig` file to help with default line endings for Windows files. [Internal] [Fixed] - Added a rule in `.editorconfig` and `.gitattributes` to help with default line endings for Windows files. Pull Request resolved: https://github.com/facebook/react-native/pull/31128 Test Plan: Feel free to go on a macOS or Windows machine (or both) and, using any editor that supports editorconfig, do any change in a `.bat` file. Then look at your git diff in terminal or gui or whatever you use, and then look at the sky and smile. It's fixed. The diff is just your change. Everything is as it should {emoji:1f49c}. Reviewed By: nadiia Differential Revision: D27914636 Pulled By: hramos fbshipit-source-id: fc4e53a4fa42cb13e29686669e8de1679c2242e7 2021-04-21 21:26:18 +03:00
			`# Windows files`
			`[*.bat]`
			`end_of_line = crlf`