2019-04-23 15:44:07 +03:00
|
|
|
def use_react_native! (options={})
|
|
|
|
|
|
|
|
# The prefix to the react-native
|
|
|
|
prefix = options[:path] ||= "../node_modules/react-native"
|
2019-07-02 01:12:56 +03:00
|
|
|
|
2019-05-16 07:55:26 +03:00
|
|
|
# Include Fabric dependencies
|
|
|
|
fabric_enabled = options[:fabric_enabled] ||= false
|
2019-07-02 01:12:56 +03:00
|
|
|
|
2019-04-23 15:44:07 +03:00
|
|
|
# Include DevSupport dependency
|
|
|
|
production = options[:production] ||= false
|
|
|
|
|
|
|
|
# The Pods which should be included in all projects
|
2019-07-02 01:12:56 +03:00
|
|
|
pod 'FBLazyVector', :path => "#{prefix}/Libraries/FBLazyVector"
|
|
|
|
pod 'FBReactNativeSpec', :path => "#{prefix}/Libraries/FBReactNativeSpec"
|
|
|
|
pod 'RCTRequired', :path => "#{prefix}/Libraries/RCTRequired"
|
2019-07-13 00:24:55 +03:00
|
|
|
pod 'RCTTypeSafety', :path => "#{prefix}/Libraries/TypeSafety"
|
2019-04-23 15:44:07 +03:00
|
|
|
pod 'React', :path => "#{prefix}/"
|
CocoaPods frameworks compatibility: Step 2 (#25619)
Summary:
This is my proposal for fixing `use_frameworks!` compatibility without breaking all `<React/*>` imports I outlined in https://github.com/facebook/react-native/pull/25393#issuecomment-508457700. If accepted, it will fix https://github.com/facebook/react-native/issues/25349.
It builds on the changes I made in https://github.com/facebook/react-native/pull/25496 by ensuring each podspec has a unique value for `header_dir` so that framework imports do not conflict. Every podspec which should be included in the `<React/*>` namespace now includes it's headers from `React-Core.podspec`.
The following pods can still be imported with `<React/*>` and so should not have breaking changes: `React-ART`,`React-DevSupport`, `React-CoreModules`, `React-RCTActionSheet`, `React-RCTAnimation`, `React-RCTBlob`, `React-RCTImage`, `React-RCTLinking`, `React-RCTNetwork`, `React-RCTPushNotification`, `React-RCTSettings`, `React-RCTText`, `React-RCTSettings`, `React-RCTVibration`, `React-RCTWebSocket` .
There are still a few breaking changes which I hope will be acceptable:
- `React-Core.podspec` has been moved to the root of the project. Any `Podfile` that references it will need to update the path.
- ~~`React-turbomodule-core`'s headers now live under `<turbomodule/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-turbomodulesamples`'s headers now live under `<turbomodulesamples/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-TypeSaferty`'s headers now live under `<TypeSafety/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511040967.
- ~~`React-jscallinvoker`'s headers now live under `<jscallinvoker/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- Each podspec now uses `s.static_framework = true`. This means that a minimum of CocoaPods 1.5 ([released in April 2018](http://blog.cocoapods.org/CocoaPods-1.5.0/)) is now required. This is needed so that the ` __has_include` conditions can still work when frameworks are enabled.
Still to do:
- ~~Including `React-turbomodule-core` with `use_frameworks!` enabled causes the C++ import failures we saw in https://github.com/facebook/react-native/issues/25349. I'm sure it will be possible to fix this but I need to dig deeper (perhaps a custom modulemap would be needed).~~ Addressed by https://github.com/facebook/react-native/pull/25619/commits/33573511f02f3502a28bad48e085e9a4b8608302.
- I haven't got Fabric working yet. I wonder if it would be acceptable to move Fabric out of the `<React/*>` namespace since it is new? �
## Changelog
[iOS] [Fixed] - Fixed compatibility with CocoaPods frameworks.
Pull Request resolved: https://github.com/facebook/react-native/pull/25619
Test Plan:
### FB
```
buck build catalyst
```
### Sample Project
Everything should work exactly as before, where `use_frameworks!` is not in `Podfile`s. I have a branch on my [sample project](https://github.com/jtreanor/react-native-cocoapods-frameworks) here which has `use_frameworks!` in its `Podfile` to demonstrate this is fixed.
You can see that it works with these steps:
1. `git clone git@github.com:jtreanor/react-native-cocoapods-frameworks.git`
2. `git checkout fix-frameworks-subspecs`
3. `cd ios && pod install`
4. `cd .. && react-native run-ios`
The sample app will build and run successfully. To see that it still works without frameworks, remove `use_frameworks!` from the `Podfile` and do steps 3 and 4 again.
### RNTesterPods
`RNTesterPodsPods` can now work with or without `use_frameworks!`.
1. Go to the `RNTester` directory and run `pod install`.
2. Run the tests in `RNTesterPods.xcworkspace` to see that everything still works fine.
3. Uncomment the `use_frameworks!` line at the top of `RNTester/Podfile` and run `pod install` again.
4. Run the tests again and see that it still works with frameworks enabled.
Reviewed By: PeteTheHeat
Differential Revision: D16465247
Pulled By: PeteTheHeat
fbshipit-source-id: cad837e9cced06d30cc5b372af1c65c7780b9e7a
2019-07-25 08:26:42 +03:00
|
|
|
pod 'React-Core', :path => "#{prefix}/"
|
2019-07-02 01:12:56 +03:00
|
|
|
pod 'React-CoreModules', :path => "#{prefix}/React/CoreModules"
|
2019-04-23 15:44:07 +03:00
|
|
|
pod 'React-RCTActionSheet', :path => "#{prefix}/Libraries/ActionSheetIOS"
|
|
|
|
pod 'React-RCTAnimation', :path => "#{prefix}/Libraries/NativeAnimation"
|
|
|
|
pod 'React-RCTBlob', :path => "#{prefix}/Libraries/Blob"
|
|
|
|
pod 'React-RCTImage', :path => "#{prefix}/Libraries/Image"
|
|
|
|
pod 'React-RCTLinking', :path => "#{prefix}/Libraries/LinkingIOS"
|
|
|
|
pod 'React-RCTNetwork', :path => "#{prefix}/Libraries/Network"
|
|
|
|
pod 'React-RCTSettings', :path => "#{prefix}/Libraries/Settings"
|
|
|
|
pod 'React-RCTText', :path => "#{prefix}/Libraries/Text"
|
|
|
|
pod 'React-RCTVibration', :path => "#{prefix}/Libraries/Vibration"
|
2019-07-25 21:42:49 +03:00
|
|
|
pod 'React-Core/RCTWebSocket', :path => "#{prefix}/"
|
2019-05-03 23:25:56 +03:00
|
|
|
|
2019-04-23 15:44:07 +03:00
|
|
|
unless production
|
2019-07-25 21:42:49 +03:00
|
|
|
pod 'React-Core/DevSupport', :path => "#{prefix}/"
|
2019-04-23 15:44:07 +03:00
|
|
|
end
|
|
|
|
|
|
|
|
pod 'React-cxxreact', :path => "#{prefix}/ReactCommon/cxxreact"
|
|
|
|
pod 'React-jsi', :path => "#{prefix}/ReactCommon/jsi"
|
|
|
|
pod 'React-jsiexecutor', :path => "#{prefix}/ReactCommon/jsiexecutor"
|
|
|
|
pod 'React-jsinspector', :path => "#{prefix}/ReactCommon/jsinspector"
|
2019-07-13 08:34:14 +03:00
|
|
|
pod 'ReactCommon/jscallinvoker', :path => "#{prefix}/ReactCommon"
|
2019-07-13 08:34:14 +03:00
|
|
|
pod 'ReactCommon/turbomodule/core', :path => "#{prefix}/ReactCommon"
|
2019-08-30 17:10:51 +03:00
|
|
|
pod 'Yoga', :path => "#{prefix}/ReactCommon/yoga"
|
2019-04-23 15:44:07 +03:00
|
|
|
|
|
|
|
pod 'DoubleConversion', :podspec => "#{prefix}/third-party-podspecs/DoubleConversion.podspec"
|
|
|
|
pod 'glog', :podspec => "#{prefix}/third-party-podspecs/glog.podspec"
|
|
|
|
pod 'Folly', :podspec => "#{prefix}/third-party-podspecs/Folly.podspec"
|
2019-05-16 07:55:26 +03:00
|
|
|
|
|
|
|
if fabric_enabled
|
|
|
|
pod 'React-Fabric', :path => "#{prefix}/ReactCommon"
|
|
|
|
pod 'React-graphics', :path => "#{prefix}/ReactCommon/fabric/graphics"
|
|
|
|
pod 'React-jsi/Fabric', :path => "#{prefix}/ReactCommon/jsi"
|
|
|
|
pod 'React-RCTFabric', :path => "#{prefix}/React"
|
|
|
|
pod 'Folly/Fabric', :podspec => "#{prefix}/third-party-podspecs/Folly.podspec"
|
|
|
|
end
|
2019-07-02 01:12:56 +03:00
|
|
|
|
2019-04-23 15:44:07 +03:00
|
|
|
end
|