2019-06-24 13:40:38 +03:00
|
|
|
/**
|
|
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
|
|
*
|
|
|
|
* This source code is licensed under the MIT license found in the
|
|
|
|
* LICENSE file in the root directory of this source tree.
|
|
|
|
*/
|
|
|
|
|
2019-06-25 06:15:02 +03:00
|
|
|
#import <ImageIO/ImageIO.h>
|
CocoaPods frameworks compatibility: Step 2 (#25619)
Summary:
This is my proposal for fixing `use_frameworks!` compatibility without breaking all `<React/*>` imports I outlined in https://github.com/facebook/react-native/pull/25393#issuecomment-508457700. If accepted, it will fix https://github.com/facebook/react-native/issues/25349.
It builds on the changes I made in https://github.com/facebook/react-native/pull/25496 by ensuring each podspec has a unique value for `header_dir` so that framework imports do not conflict. Every podspec which should be included in the `<React/*>` namespace now includes it's headers from `React-Core.podspec`.
The following pods can still be imported with `<React/*>` and so should not have breaking changes: `React-ART`,`React-DevSupport`, `React-CoreModules`, `React-RCTActionSheet`, `React-RCTAnimation`, `React-RCTBlob`, `React-RCTImage`, `React-RCTLinking`, `React-RCTNetwork`, `React-RCTPushNotification`, `React-RCTSettings`, `React-RCTText`, `React-RCTSettings`, `React-RCTVibration`, `React-RCTWebSocket` .
There are still a few breaking changes which I hope will be acceptable:
- `React-Core.podspec` has been moved to the root of the project. Any `Podfile` that references it will need to update the path.
- ~~`React-turbomodule-core`'s headers now live under `<turbomodule/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-turbomodulesamples`'s headers now live under `<turbomodulesamples/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-TypeSaferty`'s headers now live under `<TypeSafety/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511040967.
- ~~`React-jscallinvoker`'s headers now live under `<jscallinvoker/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- Each podspec now uses `s.static_framework = true`. This means that a minimum of CocoaPods 1.5 ([released in April 2018](http://blog.cocoapods.org/CocoaPods-1.5.0/)) is now required. This is needed so that the ` __has_include` conditions can still work when frameworks are enabled.
Still to do:
- ~~Including `React-turbomodule-core` with `use_frameworks!` enabled causes the C++ import failures we saw in https://github.com/facebook/react-native/issues/25349. I'm sure it will be possible to fix this but I need to dig deeper (perhaps a custom modulemap would be needed).~~ Addressed by https://github.com/facebook/react-native/pull/25619/commits/33573511f02f3502a28bad48e085e9a4b8608302.
- I haven't got Fabric working yet. I wonder if it would be acceptable to move Fabric out of the `<React/*>` namespace since it is new? �
## Changelog
[iOS] [Fixed] - Fixed compatibility with CocoaPods frameworks.
Pull Request resolved: https://github.com/facebook/react-native/pull/25619
Test Plan:
### FB
```
buck build catalyst
```
### Sample Project
Everything should work exactly as before, where `use_frameworks!` is not in `Podfile`s. I have a branch on my [sample project](https://github.com/jtreanor/react-native-cocoapods-frameworks) here which has `use_frameworks!` in its `Podfile` to demonstrate this is fixed.
You can see that it works with these steps:
1. `git clone git@github.com:jtreanor/react-native-cocoapods-frameworks.git`
2. `git checkout fix-frameworks-subspecs`
3. `cd ios && pod install`
4. `cd .. && react-native run-ios`
The sample app will build and run successfully. To see that it still works without frameworks, remove `use_frameworks!` from the `Podfile` and do steps 3 and 4 again.
### RNTesterPods
`RNTesterPodsPods` can now work with or without `use_frameworks!`.
1. Go to the `RNTester` directory and run `pod install`.
2. Run the tests in `RNTesterPods.xcworkspace` to see that everything still works fine.
3. Uncomment the `use_frameworks!` line at the top of `RNTester/Podfile` and run `pod install` again.
4. Run the tests again and see that it still works with frameworks enabled.
Reviewed By: PeteTheHeat
Differential Revision: D16465247
Pulled By: PeteTheHeat
fbshipit-source-id: cad837e9cced06d30cc5b372af1c65c7780b9e7a
2019-07-25 08:26:42 +03:00
|
|
|
#import <React/RCTAnimatedImage.h>
|
2019-06-24 13:40:38 +03:00
|
|
|
|
|
|
|
@interface RCTGIFCoderFrame : NSObject
|
|
|
|
|
|
|
|
@property (nonatomic, assign) NSUInteger index;
|
|
|
|
@property (nonatomic, assign) NSTimeInterval duration;
|
|
|
|
|
|
|
|
@end
|
|
|
|
|
|
|
|
@implementation RCTGIFCoderFrame
|
|
|
|
@end
|
|
|
|
|
|
|
|
@implementation RCTAnimatedImage {
|
|
|
|
CGImageSourceRef _imageSource;
|
|
|
|
CGFloat _scale;
|
|
|
|
NSUInteger _loopCount;
|
|
|
|
NSUInteger _frameCount;
|
|
|
|
NSArray<RCTGIFCoderFrame *> *_frames;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (instancetype)initWithData:(NSData *)data scale:(CGFloat)scale
|
|
|
|
{
|
|
|
|
if (self = [super init]) {
|
|
|
|
CGImageSourceRef imageSource = CGImageSourceCreateWithData((__bridge CFDataRef)data, NULL);
|
|
|
|
if (!imageSource) {
|
|
|
|
return nil;
|
|
|
|
}
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
BOOL framesValid = [self scanAndCheckFramesValidWithSource:imageSource];
|
|
|
|
if (!framesValid) {
|
|
|
|
CFRelease(imageSource);
|
|
|
|
return nil;
|
|
|
|
}
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
_imageSource = imageSource;
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
// grab image at the first index
|
|
|
|
UIImage *image = [self animatedImageFrameAtIndex:0];
|
|
|
|
if (!image) {
|
|
|
|
return nil;
|
|
|
|
}
|
|
|
|
self = [super initWithCGImage:image.CGImage scale:MAX(scale, 1) orientation:image.imageOrientation];
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didReceiveMemoryWarning:) name:UIApplicationDidReceiveMemoryWarningNotification object:nil];
|
|
|
|
}
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
return self;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (BOOL)scanAndCheckFramesValidWithSource:(CGImageSourceRef)imageSource
|
|
|
|
{
|
|
|
|
if (!imageSource) {
|
|
|
|
return NO;
|
|
|
|
}
|
|
|
|
NSUInteger frameCount = CGImageSourceGetCount(imageSource);
|
|
|
|
NSUInteger loopCount = [self imageLoopCountWithSource:imageSource];
|
|
|
|
NSMutableArray<RCTGIFCoderFrame *> *frames = [NSMutableArray array];
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
for (size_t i = 0; i < frameCount; i++) {
|
|
|
|
RCTGIFCoderFrame *frame = [[RCTGIFCoderFrame alloc] init];
|
|
|
|
frame.index = i;
|
|
|
|
frame.duration = [self frameDurationAtIndex:i source:imageSource];
|
|
|
|
[frames addObject:frame];
|
|
|
|
}
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
_frameCount = frameCount;
|
|
|
|
_loopCount = loopCount;
|
|
|
|
_frames = [frames copy];
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
return YES;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (NSUInteger)imageLoopCountWithSource:(CGImageSourceRef)source
|
|
|
|
{
|
|
|
|
NSUInteger loopCount = 1;
|
|
|
|
NSDictionary *imageProperties = (__bridge_transfer NSDictionary *)CGImageSourceCopyProperties(source, nil);
|
|
|
|
NSDictionary *gifProperties = imageProperties[(__bridge NSString *)kCGImagePropertyGIFDictionary];
|
|
|
|
if (gifProperties) {
|
|
|
|
NSNumber *gifLoopCount = gifProperties[(__bridge NSString *)kCGImagePropertyGIFLoopCount];
|
|
|
|
if (gifLoopCount != nil) {
|
|
|
|
loopCount = gifLoopCount.unsignedIntegerValue;
|
2019-08-28 18:13:27 +03:00
|
|
|
// A loop count of 1 means it should repeat twice, 2 means, thrice, etc.
|
|
|
|
if (loopCount != 0) {
|
|
|
|
loopCount++;
|
|
|
|
}
|
2019-06-24 13:40:38 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return loopCount;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (float)frameDurationAtIndex:(NSUInteger)index source:(CGImageSourceRef)source
|
|
|
|
{
|
|
|
|
float frameDuration = 0.1f;
|
|
|
|
CFDictionaryRef cfFrameProperties = CGImageSourceCopyPropertiesAtIndex(source, index, nil);
|
|
|
|
if (!cfFrameProperties) {
|
|
|
|
return frameDuration;
|
|
|
|
}
|
|
|
|
NSDictionary *frameProperties = (__bridge NSDictionary *)cfFrameProperties;
|
|
|
|
NSDictionary *gifProperties = frameProperties[(NSString *)kCGImagePropertyGIFDictionary];
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
NSNumber *delayTimeUnclampedProp = gifProperties[(NSString *)kCGImagePropertyGIFUnclampedDelayTime];
|
|
|
|
if (delayTimeUnclampedProp != nil) {
|
|
|
|
frameDuration = [delayTimeUnclampedProp floatValue];
|
|
|
|
} else {
|
|
|
|
NSNumber *delayTimeProp = gifProperties[(NSString *)kCGImagePropertyGIFDelayTime];
|
|
|
|
if (delayTimeProp != nil) {
|
|
|
|
frameDuration = [delayTimeProp floatValue];
|
|
|
|
}
|
|
|
|
}
|
2019-06-25 06:15:02 +03:00
|
|
|
|
2019-06-24 13:40:38 +03:00
|
|
|
CFRelease(cfFrameProperties);
|
|
|
|
return frameDuration;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (NSUInteger)animatedImageLoopCount
|
|
|
|
{
|
|
|
|
return _loopCount;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (NSUInteger)animatedImageFrameCount
|
|
|
|
{
|
|
|
|
return _frameCount;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (NSTimeInterval)animatedImageDurationAtIndex:(NSUInteger)index
|
|
|
|
{
|
|
|
|
if (index >= _frameCount) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
return _frames[index].duration;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (UIImage *)animatedImageFrameAtIndex:(NSUInteger)index
|
|
|
|
{
|
|
|
|
CGImageRef imageRef = CGImageSourceCreateImageAtIndex(_imageSource, index, NULL);
|
|
|
|
if (!imageRef) {
|
|
|
|
return nil;
|
|
|
|
}
|
|
|
|
UIImage *image = [[UIImage alloc] initWithCGImage:imageRef scale:_scale orientation:UIImageOrientationUp];
|
|
|
|
CGImageRelease(imageRef);
|
|
|
|
return image;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)didReceiveMemoryWarning:(NSNotification *)notification
|
|
|
|
{
|
|
|
|
if (_imageSource) {
|
|
|
|
for (size_t i = 0; i < _frameCount; i++) {
|
|
|
|
CGImageSourceRemoveCacheAtIndex(_imageSource, i);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)dealloc
|
|
|
|
{
|
|
|
|
if (_imageSource) {
|
|
|
|
CFRelease(_imageSource);
|
|
|
|
_imageSource = NULL;
|
|
|
|
}
|
|
|
|
[[NSNotificationCenter defaultCenter] removeObserver:self name:UIApplicationDidReceiveMemoryWarningNotification object:nil];
|
|
|
|
}
|
|
|
|
|
|
|
|
@end
|