2019-10-16 20:03:47 +03:00
|
|
|
/*
|
2018-09-12 01:27:47 +03:00
|
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
2018-01-26 20:06:14 +03:00
|
|
|
*
|
2018-02-17 05:24:55 +03:00
|
|
|
* This source code is licensed under the MIT license found in the
|
|
|
|
* LICENSE file in the root directory of this source tree.
|
2018-01-26 20:06:14 +03:00
|
|
|
*/
|
|
|
|
|
|
|
|
#import <XCTest/XCTest.h>
|
|
|
|
|
CocoaPods frameworks compatibility: Step 2 (#25619)
Summary:
This is my proposal for fixing `use_frameworks!` compatibility without breaking all `<React/*>` imports I outlined in https://github.com/facebook/react-native/pull/25393#issuecomment-508457700. If accepted, it will fix https://github.com/facebook/react-native/issues/25349.
It builds on the changes I made in https://github.com/facebook/react-native/pull/25496 by ensuring each podspec has a unique value for `header_dir` so that framework imports do not conflict. Every podspec which should be included in the `<React/*>` namespace now includes it's headers from `React-Core.podspec`.
The following pods can still be imported with `<React/*>` and so should not have breaking changes: `React-ART`,`React-DevSupport`, `React-CoreModules`, `React-RCTActionSheet`, `React-RCTAnimation`, `React-RCTBlob`, `React-RCTImage`, `React-RCTLinking`, `React-RCTNetwork`, `React-RCTPushNotification`, `React-RCTSettings`, `React-RCTText`, `React-RCTSettings`, `React-RCTVibration`, `React-RCTWebSocket` .
There are still a few breaking changes which I hope will be acceptable:
- `React-Core.podspec` has been moved to the root of the project. Any `Podfile` that references it will need to update the path.
- ~~`React-turbomodule-core`'s headers now live under `<turbomodule/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-turbomodulesamples`'s headers now live under `<turbomodulesamples/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- ~~`React-TypeSaferty`'s headers now live under `<TypeSafety/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511040967.
- ~~`React-jscallinvoker`'s headers now live under `<jscallinvoker/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823.
- Each podspec now uses `s.static_framework = true`. This means that a minimum of CocoaPods 1.5 ([released in April 2018](http://blog.cocoapods.org/CocoaPods-1.5.0/)) is now required. This is needed so that the ` __has_include` conditions can still work when frameworks are enabled.
Still to do:
- ~~Including `React-turbomodule-core` with `use_frameworks!` enabled causes the C++ import failures we saw in https://github.com/facebook/react-native/issues/25349. I'm sure it will be possible to fix this but I need to dig deeper (perhaps a custom modulemap would be needed).~~ Addressed by https://github.com/facebook/react-native/pull/25619/commits/33573511f02f3502a28bad48e085e9a4b8608302.
- I haven't got Fabric working yet. I wonder if it would be acceptable to move Fabric out of the `<React/*>` namespace since it is new? �
## Changelog
[iOS] [Fixed] - Fixed compatibility with CocoaPods frameworks.
Pull Request resolved: https://github.com/facebook/react-native/pull/25619
Test Plan:
### FB
```
buck build catalyst
```
### Sample Project
Everything should work exactly as before, where `use_frameworks!` is not in `Podfile`s. I have a branch on my [sample project](https://github.com/jtreanor/react-native-cocoapods-frameworks) here which has `use_frameworks!` in its `Podfile` to demonstrate this is fixed.
You can see that it works with these steps:
1. `git clone git@github.com:jtreanor/react-native-cocoapods-frameworks.git`
2. `git checkout fix-frameworks-subspecs`
3. `cd ios && pod install`
4. `cd .. && react-native run-ios`
The sample app will build and run successfully. To see that it still works without frameworks, remove `use_frameworks!` from the `Podfile` and do steps 3 and 4 again.
### RNTesterPods
`RNTesterPodsPods` can now work with or without `use_frameworks!`.
1. Go to the `RNTester` directory and run `pod install`.
2. Run the tests in `RNTesterPods.xcworkspace` to see that everything still works fine.
3. Uncomment the `use_frameworks!` line at the top of `RNTester/Podfile` and run `pod install` again.
4. Run the tests again and see that it still works with frameworks enabled.
Reviewed By: PeteTheHeat
Differential Revision: D16465247
Pulled By: PeteTheHeat
fbshipit-source-id: cad837e9cced06d30cc5b372af1c65c7780b9e7a
2019-07-25 08:26:42 +03:00
|
|
|
#import <React/RCTBlobManager.h>
|
2018-01-26 20:06:14 +03:00
|
|
|
|
|
|
|
@interface RCTBlobManagerTests : XCTestCase
|
|
|
|
|
|
|
|
@end
|
|
|
|
|
|
|
|
@implementation RCTBlobManagerTests
|
|
|
|
{
|
|
|
|
RCTBlobManager *_module;
|
|
|
|
NSMutableData *_data;
|
|
|
|
NSString *_blobId;
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)setUp
|
|
|
|
{
|
|
|
|
[super setUp];
|
|
|
|
|
|
|
|
_module = [RCTBlobManager new];
|
|
|
|
[_module setValue:nil forKey:@"bridge"];
|
|
|
|
NSInteger size = 120;
|
|
|
|
_data = [NSMutableData dataWithCapacity:size];
|
|
|
|
for (NSInteger i = 0; i < size / 4; i++) {
|
|
|
|
uint32_t randomBits = arc4random();
|
|
|
|
[_data appendBytes:(void *)&randomBits length:4];
|
|
|
|
}
|
|
|
|
_blobId = [NSUUID UUID].UUIDString;
|
|
|
|
[_module store:_data withId:_blobId];
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)testResolve
|
|
|
|
{
|
|
|
|
XCTAssertTrue([_data isEqualToData:[_module resolve:_blobId offset:0 size:_data.length]]);
|
|
|
|
NSData *rangeData = [_data subdataWithRange:NSMakeRange(30, _data.length - 30)];
|
|
|
|
XCTAssertTrue([rangeData isEqualToData:[_module resolve:_blobId offset:30 size:_data.length - 30]]);
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)testResolveMap
|
|
|
|
{
|
|
|
|
NSDictionary<NSString *, id> *map = @{
|
|
|
|
@"blobId": _blobId,
|
|
|
|
@"size": @(_data.length),
|
|
|
|
@"offset": @0,
|
|
|
|
};
|
|
|
|
XCTAssertTrue([_data isEqualToData:[_module resolve:map]]);
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)testResolveURL
|
|
|
|
{
|
|
|
|
NSURLComponents *components = [NSURLComponents new];
|
|
|
|
[components setPath:_blobId];
|
|
|
|
[components setQuery:[NSString stringWithFormat:@"offset=0&size=%lu", (unsigned long)_data.length]];
|
|
|
|
XCTAssertTrue([_data isEqualToData:[_module resolveURL:[components URL]]]);
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)testRemove
|
|
|
|
{
|
|
|
|
XCTAssertNotNil([_module resolve:_blobId offset:0 size:_data.length]);
|
|
|
|
[_module remove:_blobId];
|
|
|
|
XCTAssertNil([_module resolve:_blobId offset:0 size:_data.length]);
|
|
|
|
}
|
|
|
|
|
|
|
|
- (void)testCreateFromParts
|
|
|
|
{
|
|
|
|
NSDictionary<NSString *, id> *blobData = @{
|
|
|
|
@"blobId": _blobId,
|
|
|
|
@"offset": @0,
|
|
|
|
@"size": @(_data.length),
|
|
|
|
};
|
|
|
|
NSDictionary<NSString *, id> *blob = @{
|
|
|
|
@"data": blobData,
|
|
|
|
@"type": @"blob",
|
|
|
|
};
|
|
|
|
NSString *stringData = @"i \u2665 dogs";
|
|
|
|
NSDictionary<NSString *, id> *string = @{
|
|
|
|
@"data": stringData,
|
|
|
|
@"type": @"string",
|
|
|
|
};
|
|
|
|
NSString *resultId = [NSUUID UUID].UUIDString;
|
|
|
|
NSArray<id> *parts = @[blob, string];
|
|
|
|
|
|
|
|
[_module createFromParts:parts withId:resultId];
|
|
|
|
|
|
|
|
NSMutableData *expectedData = [NSMutableData new];
|
|
|
|
[expectedData appendData:_data];
|
|
|
|
[expectedData appendData:[stringData dataUsingEncoding:NSUTF8StringEncoding]];
|
|
|
|
|
|
|
|
NSData *result = [_module resolve:resultId offset:0 size:expectedData.length];
|
|
|
|
|
|
|
|
XCTAssertTrue([expectedData isEqualToData:result]);
|
|
|
|
}
|
|
|
|
|
|
|
|
@end
|