Change type of params in methods' protocols to nongeneric
Summary: It was mistake which I fix here. Type of param in protocols should be generated struct. See generated struct in snap. It's exactly how it was in previous codegen Reviewed By: RSNara Differential Revision: D16770579 fbshipit-source-id: dac9c15c5d91a41ab2d06aea416f64bd7deb4476
This commit is contained in:
Родитель
d3c30cdfe1
Коммит
024ce5d1d4
|
@ -182,26 +182,30 @@ module.exports = {
|
||||||
.map(prop => {
|
.map(prop => {
|
||||||
const nativeArgs = prop.typeAnnotation.params
|
const nativeArgs = prop.typeAnnotation.params
|
||||||
.map((param, i) => {
|
.map((param, i) => {
|
||||||
|
let paramObjCType;
|
||||||
if (
|
if (
|
||||||
param.typeAnnotation.type === 'ObjectTypeAnnotation' &&
|
param.typeAnnotation.type === 'ObjectTypeAnnotation' &&
|
||||||
param.typeAnnotation.properties
|
param.typeAnnotation.properties
|
||||||
) {
|
) {
|
||||||
objectForGeneratingStructs.push({
|
const variableName =
|
||||||
name:
|
|
||||||
capitalizeFirstLetter(prop.name) +
|
capitalizeFirstLetter(prop.name) +
|
||||||
capitalizeFirstLetter(param.name),
|
capitalizeFirstLetter(param.name);
|
||||||
|
objectForGeneratingStructs.push({
|
||||||
|
name: variableName,
|
||||||
object: {
|
object: {
|
||||||
type: 'ObjectTypeAnnotation',
|
type: 'ObjectTypeAnnotation',
|
||||||
properties: param.typeAnnotation.properties,
|
properties: param.typeAnnotation.properties,
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
}
|
paramObjCType = `JS::Native::_MODULE_NAME_::::Spec${variableName}&`;
|
||||||
const paramObjCType = translatePrimitiveJSTypeToObjCType(
|
} else {
|
||||||
|
paramObjCType = translatePrimitiveJSTypeToObjCType(
|
||||||
param,
|
param,
|
||||||
`Unspopported type for param "${param.name}" in ${
|
`Unspopported type for param "${param.name}" in ${
|
||||||
prop.name
|
prop.name
|
||||||
}. Found: ${param.typeAnnotation.type}`,
|
}. Found: ${param.typeAnnotation.type}`,
|
||||||
);
|
);
|
||||||
|
}
|
||||||
return `${i === 0 ? '' : param.name}:(${paramObjCType})${
|
return `${i === 0 ? '' : param.name}:(${paramObjCType})${
|
||||||
param.name
|
param.name
|
||||||
}`;
|
}`;
|
||||||
|
|
|
@ -149,7 +149,7 @@ inline NSString *JS::NativeSampleTurboModule::SpecDifficultAE::F() const
|
||||||
|
|
||||||
|
|
||||||
@protocol NativeSampleTurboModuleSpec <RCTBridgeModule, RCTTurboModule>
|
@protocol NativeSampleTurboModuleSpec <RCTBridgeModule, RCTTurboModule>
|
||||||
- (NSDictionary *) difficult:(NSDictionary *)A;
|
- (NSDictionary *) difficult:(JS::NativeSampleTurboModule::SpecDifficultA&)A;
|
||||||
@end
|
@end
|
||||||
|
|
||||||
|
|
||||||
|
|
Загрузка…
Ссылка в новой задаче