From 062c1f7277ebaadda5e6aff1e839618caf0ea0ac Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Wed, 16 Feb 2022 15:17:32 -0800 Subject: [PATCH] Unblock CI by disabling integration testing for `test_ios_unit_hermes` (#33128) Summary: I'm disabling the integration test step for `test_ios_unit_hermes` as they're currently failign wiht a `SIGSEGV` introduced by 9010bfe457b77862024214ce6210504ff1786ef5 The change is legit, but is introducing an ABI incompatibility that is making the app crash at runtime. We can re-enable them as soon as Hermes 0.12.0 is released. ## Changelog [Internal] - Unblock CI by disabling integration testing for `test_ios_unit_hermes` Pull Request resolved: https://github.com/facebook/react-native/pull/33128 Test Plan: Will wait for a Circle CI green before merging Reviewed By: neildhar Differential Revision: D34285751 Pulled By: cortinico fbshipit-source-id: 40f8e3d1b41fc4d5f0459003dcd19d651aefbeb7 --- .circleci/config.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index b6e34fe025..54fb2376a7 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -966,7 +966,10 @@ workflows: - test_ios: name: test_ios_unit_hermes use_hermes: true - run_unit_tests: true + # TODO(ncor, neildhar) Integration tests for iOS + Hermes are currently + # disabled due to an ABI incompatibility introduced by D33830544. + # They can be re-enabled as soon as Hermes 0.12.0 is released. + run_unit_tests: false filters: branches: ignore: gh-pages