Replace unique_ptrs in ScriptStore.h with shared_ptrs. (#132)

This commit is contained in:
Yichen Yao 2019-08-08 13:51:17 -07:00 коммит произвёл GitHub
Родитель 2c52bb06eb
Коммит 0785bf81b7
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 2 добавлений и 2 удалений

Просмотреть файл

@ -11,7 +11,7 @@ using ScriptVersion_t = uint64_t; // It shouldbe std::optional<uint64_t> once w
using JSRuntimeVersion_t = uint64_t; // 0 implies version can't be computed. We assert whenever that happens.
struct VersionedBuffer {
std::unique_ptr<const facebook::jsi::Buffer> buffer;
std::shared_ptr<const facebook::jsi::Buffer> buffer;
ScriptVersion_t version;
};
@ -34,7 +34,7 @@ struct PreparedScriptStore {
// RuntimeSignature : Javascript engine type and version
// prepareTag : Custom tag to uniquely identify JS engine specific preparation schemes. It is usually useful while experimentation and can be null.
// It is possible that no prepared script is available for a given script & runtime signature. This method should null if so
virtual std::unique_ptr<const facebook::jsi::Buffer> tryGetPreparedScript(
virtual std::shared_ptr<const facebook::jsi::Buffer> tryGetPreparedScript(
const ScriptSignature& scriptSignature,
const JSRuntimeSignature& runtimeSignature,
const char* prepareTag // Optional tag. For e.g. eagerly evaluated vs lazy cache.