From 0a95edf6eaeafdc91b96b25c8b049cc051173652 Mon Sep 17 00:00:00 2001 From: Philipp von Weitershausen Date: Fri, 5 Jun 2015 19:00:17 -0700 Subject: [PATCH] [ReactNative] use Map, not Object when functions are keys --- Libraries/LinkingIOS/LinkingIOS.js | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/Libraries/LinkingIOS/LinkingIOS.js b/Libraries/LinkingIOS/LinkingIOS.js index 7bd5c008b2..84960ff323 100644 --- a/Libraries/LinkingIOS/LinkingIOS.js +++ b/Libraries/LinkingIOS/LinkingIOS.js @@ -13,9 +13,10 @@ var RCTDeviceEventEmitter = require('RCTDeviceEventEmitter'); var RCTLinkingManager = require('NativeModules').LinkingManager; +var Map = require('Map'); var invariant = require('invariant'); -var _notifHandlers = {}; +var _notifHandlers = new Map(); var _initialURL = RCTLinkingManager && RCTLinkingManager.initialURL; @@ -80,10 +81,6 @@ var DEVICE_NOTIF_EVENT = 'openURL'; * } * }); * ``` - * - * _The iOS simulator does not support the `mailto:` and `tel:` schemas - * because the Mail and Phone apps are not installed - you will need to test - * them on a device._ */ class LinkingIOS { /** @@ -95,10 +92,11 @@ class LinkingIOS { type === 'url', 'LinkingIOS only supports `url` events' ); - _notifHandlers[handler] = RCTDeviceEventEmitter.addListener( + var listener = RCTDeviceEventEmitter.addListener( DEVICE_NOTIF_EVENT, handler ); + _notifHandlers.set(handler, listener); } /** @@ -109,11 +107,12 @@ class LinkingIOS { type === 'url', 'LinkingIOS only supports `url` events' ); - if (!_notifHandlers[handler]) { + var listener = _notifHandlers.get(handler); + if (!listener) { return; } - _notifHandlers[handler].remove(); - _notifHandlers[handler] = null; + listener.remove(); + _notifHandlers.delete(handler); } /**