From 0c4c6ca319fa9dfb23d047e0c7d2a81281d1d8a3 Mon Sep 17 00:00:00 2001 From: Sam Zhou Date: Wed, 27 Apr 2022 19:15:55 -0700 Subject: [PATCH] Add annotations to unannotated variable declarations [manually-modified] Reviewed By: panagosg7 Differential Revision: D35948108 fbshipit-source-id: 7d286c9dd66dbd25281e2d831691f8bb34504b5d --- Libraries/Core/Devtools/parseHermesStack.js | 2 +- Libraries/Interaction/BridgeSpyStallHandler.js | 7 ++++--- Libraries/Interaction/InteractionManager.js | 2 +- Libraries/Lists/VirtualizedList.js | 9 ++++++--- Libraries/LogBox/Data/LogBoxData.js | 2 +- Libraries/ReactNative/AppContainer.js | 2 +- Libraries/Utilities/stringifySafe.js | 5 ++++- Libraries/WebSocket/WebSocket.js | 2 +- .../hermes/inspector/tools/msggen/src/Property.js | 2 +- .../js/examples/Accessibility/AccessibilityExample.js | 2 +- 10 files changed, 21 insertions(+), 14 deletions(-) diff --git a/Libraries/Core/Devtools/parseHermesStack.js b/Libraries/Core/Devtools/parseHermesStack.js index cd21958d9e..6670cfde25 100644 --- a/Libraries/Core/Devtools/parseHermesStack.js +++ b/Libraries/Core/Devtools/parseHermesStack.js @@ -100,7 +100,7 @@ function parseLine(line: string): ?HermesStackEntry { module.exports = function parseHermesStack(stack: string): HermesParsedStack { const lines = stack.split(/\n/); - let entries = []; + let entries: Array = []; let lastMessageLine = -1; for (let i = 0; i < lines.length; ++i) { const line = lines[i]; diff --git a/Libraries/Interaction/BridgeSpyStallHandler.js b/Libraries/Interaction/BridgeSpyStallHandler.js index 5162d799e4..25cc22b42b 100644 --- a/Libraries/Interaction/BridgeSpyStallHandler.js +++ b/Libraries/Interaction/BridgeSpyStallHandler.js @@ -10,14 +10,15 @@ 'use strict'; +import type {SpyData} from '../BatchedBridge/MessageQueue'; const JSEventLoopWatchdog = require('./JSEventLoopWatchdog'); -const MessageQueue = require('../BatchedBridge/MessageQueue'); +const MessageQueue = require('../BatchedBridge/MessageQueue'); const infoLog = require('../Utilities/infoLog'); const BridgeSpyStallHandler = { register: function () { - let spyBuffer = []; + let spyBuffer: Array = []; MessageQueue.spy(data => { spyBuffer.push(data); }); @@ -27,7 +28,7 @@ const BridgeSpyStallHandler = { infoLog( spyBuffer.length + ' bridge messages during stall: ', spyBuffer.map(info => { - let args = ''; + let args: string | Array = ''; try { args = JSON.stringify(info.args); } catch (e1) { diff --git a/Libraries/Interaction/InteractionManager.js b/Libraries/Interaction/InteractionManager.js index 0122ab70d6..3c80412db8 100644 --- a/Libraries/Interaction/InteractionManager.js +++ b/Libraries/Interaction/InteractionManager.js @@ -154,7 +154,7 @@ const _interactionSet = new Set(); const _addInteractionSet = new Set(); const _deleteInteractionSet = new Set(); const _taskQueue = new TaskQueue({onMoreTasks: _scheduleUpdate}); -let _nextUpdateHandle = 0; +let _nextUpdateHandle: $FlowFixMe | TimeoutID = 0; let _inc = 0; let _deadline = -1; diff --git a/Libraries/Lists/VirtualizedList.js b/Libraries/Lists/VirtualizedList.js index 77b69cd72a..258a12e66b 100644 --- a/Libraries/Lists/VirtualizedList.js +++ b/Libraries/Lists/VirtualizedList.js @@ -1128,7 +1128,7 @@ class VirtualizedList extends React.PureComponent { )} ); - let ret = innerRet; + let ret: React.Node = innerRet; if (__DEV__) { ret = ( @@ -1742,7 +1742,10 @@ class VirtualizedList extends React.PureComponent { return; } this.setState(state => { - let newState; + let newState: ?( + | {first: number, last: number, ...} + | $TEMPORARY$object<{first: number, last: number}> + ); const {contentLength, offset, visibleLength} = this._scrollMetrics; if (!isVirtualizationDisabled) { // If we run this with bogus data, we'll force-render window {first: 0, last: 0}, @@ -2109,7 +2112,7 @@ function describeNestedLists(childList: { ` listKey: ${childList.key}\n` + ` cellKey: ${childList.cellKey}`; - let debugInfo = childList.parentDebugInfo; + let debugInfo: ?ListDebugInfo = childList.parentDebugInfo; while (debugInfo) { trace += `\n Parent (${debugInfo.horizontal ? 'horizontal' : 'vertical'}):\n` + diff --git a/Libraries/LogBox/Data/LogBoxData.js b/Libraries/LogBox/Data/LogBoxData.js index aaf6705724..77b1340182 100644 --- a/Libraries/LogBox/Data/LogBoxData.js +++ b/Libraries/LogBox/Data/LogBoxData.js @@ -156,7 +156,7 @@ function appendNewLog(newLog) { // sybolication for up to a second before adding the log. const OPTIMISTIC_WAIT_TIME = 1000; - let addPendingLog = () => { + let addPendingLog: ?() => void = () => { logs.add(newLog); if (_selectedIndex < 0) { setSelectedLog(logs.size - 1); diff --git a/Libraries/ReactNative/AppContainer.js b/Libraries/ReactNative/AppContainer.js index 30c8db33c3..8495893f8e 100644 --- a/Libraries/ReactNative/AppContainer.js +++ b/Libraries/ReactNative/AppContainer.js @@ -88,7 +88,7 @@ class AppContainer extends React.Component { } } - let innerView = ( + let innerView: React.Node = ( = value; if (Array.isArray(value)) { if (stack.length >= maxDepth) { retval = `[ ... array with ${value.length} values ... ]`; diff --git a/Libraries/WebSocket/WebSocket.js b/Libraries/WebSocket/WebSocket.js index 78312d4d68..d3b0c8a481 100644 --- a/Libraries/WebSocket/WebSocket.js +++ b/Libraries/WebSocket/WebSocket.js @@ -230,7 +230,7 @@ class WebSocket extends (EventTarget(...WEBSOCKET_EVENTS): any) { if (ev.id !== this._socketId) { return; } - let data = ev.data; + let data: Blob | BlobData | ArrayBuffer | string = ev.data; switch (ev.type) { case 'binary': data = base64.toByteArray(ev.data).buffer; diff --git a/ReactCommon/hermes/inspector/tools/msggen/src/Property.js b/ReactCommon/hermes/inspector/tools/msggen/src/Property.js index 681ccaf367..2ee60145ff 100644 --- a/ReactCommon/hermes/inspector/tools/msggen/src/Property.js +++ b/ReactCommon/hermes/inspector/tools/msggen/src/Property.js @@ -195,7 +195,7 @@ class ArrayProperty extends Property { getFullCppType(): string { let elemType: string = 'folly::dynamic'; - let recursive = false; + let recursive: ?(false | boolean) = false; if (this.items) { if (this.items.type) { diff --git a/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js b/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js index 9b8f2876d3..7c7e74c0d8 100644 --- a/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js +++ b/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js @@ -228,7 +228,7 @@ class CheckboxExample extends React.Component< }; _onCheckboxPress = () => { - let checkboxState = false; + let checkboxState: boolean | $TEMPORARY$string<'mixed'> = false; if (this.state.checkboxState === false) { checkboxState = 'mixed'; } else if (this.state.checkboxState === 'mixed') {