Remove RCTViewConfigEventValidAttributesDisabled

Summary:
Changelog: [Internal]

Codemod-bot already hardcoded this to false a while back, so cleaning up the code related to it.

Reviewed By: RSNara

Differential Revision: D41615378

fbshipit-source-id: 7b62b20b8e25f0a06d207b2457d6caf9ad5c695e
This commit is contained in:
Pieter De Baets 2022-12-02 09:08:16 -08:00 коммит произвёл Facebook GitHub Bot
Родитель d9666962f7
Коммит 1452a55845
4 изменённых файлов: 4 добавлений и 36 удалений

Просмотреть файл

@ -37,10 +37,7 @@ export function DynamicallyInjectedByGestureHandler<T: {...}>(object: T): T {
export function ConditionallyIgnoredEventHandlers<T: {[name: string]: true}>( export function ConditionallyIgnoredEventHandlers<T: {[name: string]: true}>(
value: T, value: T,
): T | void { ): T | void {
if ( if (Platform.OS === 'ios') {
Platform.OS === 'ios' &&
!(global.RN$ViewConfigEventValidAttributesDisabled === true)
) {
return value; return value;
} }
return undefined; return undefined;

Просмотреть файл

@ -56,11 +56,6 @@ RCT_EXTERN void RCTEnableTurboModuleEagerInit(BOOL enabled);
RCT_EXTERN BOOL RCTTurboModuleManagerDelegateLockingDisabled(void); RCT_EXTERN BOOL RCTTurboModuleManagerDelegateLockingDisabled(void);
RCT_EXTERN void RCTDisableTurboModuleManagerDelegateLocking(BOOL enabled); RCT_EXTERN void RCTDisableTurboModuleManagerDelegateLocking(BOOL enabled);
// Turn off validAttribute: entries inside ViewConfigs for events
// TODO(109509380): Remove this gating
RCT_EXTERN BOOL RCTViewConfigEventValidAttributesDisabled(void);
RCT_EXTERN void RCTDisableViewConfigEventValidAttributes(BOOL disabled);
typedef enum { typedef enum {
kRCTGlobalScope, kRCTGlobalScope,
kRCTGlobalScopeUsingRetainJSCallback, kRCTGlobalScopeUsingRetainJSCallback,

Просмотреть файл

@ -120,18 +120,6 @@ void RCTDisableTurboModuleManagerDelegateLocking(BOOL disabled)
turboModuleManagerDelegateLockingDisabled = disabled; turboModuleManagerDelegateLockingDisabled = disabled;
} }
// Turn off TurboModule delegate locking
static BOOL viewConfigEventValidAttributesDisabled = NO;
BOOL RCTViewConfigEventValidAttributesDisabled(void)
{
return viewConfigEventValidAttributesDisabled;
}
void RCTDisableViewConfigEventValidAttributes(BOOL disabled)
{
viewConfigEventValidAttributesDisabled = disabled;
}
@interface RCTBridge () <RCTReloadListener> @interface RCTBridge () <RCTReloadListener>
@end @end

Просмотреть файл

@ -431,25 +431,13 @@ static RCTPropBlock createNSInvocationSetter(NSMethodSignature *typeSignature, S
if ([type isEqualToString:@"RCTBubblingEventBlock"]) { if ([type isEqualToString:@"RCTBubblingEventBlock"]) {
[bubblingEvents addObject:RCTNormalizeInputEventName(name)]; [bubblingEvents addObject:RCTNormalizeInputEventName(name)];
propTypes[name] = @"BOOL";
// TODO(109509380): Remove this gating
if (!RCTViewConfigEventValidAttributesDisabled()) {
propTypes[name] = @"BOOL";
}
} else if ([type isEqualToString:@"RCTCapturingEventBlock"]) { } else if ([type isEqualToString:@"RCTCapturingEventBlock"]) {
[capturingEvents addObject:RCTNormalizeInputEventName(name)]; [capturingEvents addObject:RCTNormalizeInputEventName(name)];
propTypes[name] = @"BOOL";
// TODO(109509380): Remove this gating
if (!RCTViewConfigEventValidAttributesDisabled()) {
propTypes[name] = @"BOOL";
}
} else if ([type isEqualToString:@"RCTDirectEventBlock"]) { } else if ([type isEqualToString:@"RCTDirectEventBlock"]) {
[directEvents addObject:RCTNormalizeInputEventName(name)]; [directEvents addObject:RCTNormalizeInputEventName(name)];
propTypes[name] = @"BOOL";
// TODO(109509380): Remove this gating
if (!RCTViewConfigEventValidAttributesDisabled()) {
propTypes[name] = @"BOOL";
}
} else { } else {
propTypes[name] = type; propTypes[name] = type;
} }