From 17082d92cf2599d5bef7128422d009e9d6f40025 Mon Sep 17 00:00:00 2001 From: Kevin Gozali Date: Thu, 21 Feb 2019 20:03:10 -0800 Subject: [PATCH] NativeModules iOS: downgrade duplicated module message to warning instead of error Summary: [iOS] [Changed] - There seems to be a potential race condition during reloading that could cause "double registration" of modules. This should be mostly harmless, so downgrade to warning for the message instead of redboxing. Reviewed By: cpojer Differential Revision: D14179922 fbshipit-source-id: 5c16ac674f633a548353277d9f875544ed10ba9b --- React/CxxBridge/RCTCxxBridge.mm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm index fbcde6a33d..3c56f756f5 100644 --- a/React/CxxBridge/RCTCxxBridge.mm +++ b/React/CxxBridge/RCTCxxBridge.mm @@ -615,9 +615,9 @@ struct RCTInstanceCallback : public InstanceCallback { continue; } else if ([moduleData.moduleClass new] != nil) { // Both modules were non-nil, so it's unclear which should take precedence - RCTLogError(@"Attempted to register RCTBridgeModule class %@ for the " - "name '%@', but name was already registered by class %@", - moduleClass, moduleName, moduleData.moduleClass); + RCTLogWarn(@"Attempted to register RCTBridgeModule class %@ for the " + "name '%@', but name was already registered by class %@", + moduleClass, moduleName, moduleData.moduleClass); } }