deprecate mHasConstants in ReactModuleInfo (#39458)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39458

## Changelog
[Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated

getting rid of `mHasConstants` ivar here and marking the getter as deprecated

Reviewed By: cortinico

Differential Revision: D49262577

fbshipit-source-id: 5394281bdc4a315ffc0d1debfaef1808dc6f4299

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/model/ReactModuleInfo.java

@@ -16,7 +16,6 @@ public class ReactModuleInfo {
   private final String mName;
   private final boolean mCanOverrideExistingModule;
   private final boolean mNeedsEagerInit;
-  private final boolean mHasConstants;
   private final boolean mIsCxxModule;
   private final String mClassName;
   private final boolean mIsTurboModule;
@@ -33,7 +32,6 @@ public class ReactModuleInfo {
     mClassName = className;
     mCanOverrideExistingModule = canOverrideExistingModule;
     mNeedsEagerInit = needsEagerInit;
-    mHasConstants = hasConstants;
     mIsCxxModule = isCxxModule;
     mIsTurboModule = isTurboModule;
   }
@@ -54,8 +52,10 @@ public class ReactModuleInfo {
     return mNeedsEagerInit;
   }
 
+  /** @deprecated this is hardcoded to return true, regardless if the module has constants or not */
+  @Deprecated
   public boolean hasConstants() {
-    return mHasConstants;
+    return true;
   }
 
   public boolean isCxxModule() {