From 2191c9ed58f15e2e874203873a9d99726e9b82de Mon Sep 17 00:00:00 2001 From: Jordan Brown Date: Fri, 18 Jan 2019 06:41:25 -0800 Subject: [PATCH] remove unused suppressions in xplat Summary: Removes unused suppressions before deploying 0.91. See D13708161 for more context on why these couldn't be removed before. I will follow up with 2 more diffs: 1. A diff that bumps the flow version in xplat and removes unused suppressions 2. A diff that adds new suppressions for 0.91 Reviewed By: samwgoldman Differential Revision: D13720219 fbshipit-source-id: b07dd163962fed7ff27ce3e0a4a73a71c51965d9 --- Libraries/Components/DatePicker/DatePickerIOS.ios.js | 1 - Libraries/Components/ScrollView/ScrollView.js | 1 - RNTester/js/ListViewPagingExample.js | 1 - RNTester/js/RNTesterExampleList.js | 5 ----- 4 files changed, 8 deletions(-) diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js index 0442cf395a..a93516c9a1 100644 --- a/Libraries/Components/DatePicker/DatePickerIOS.ios.js +++ b/Libraries/Components/DatePicker/DatePickerIOS.ios.js @@ -117,7 +117,6 @@ class DatePickerIOS extends React.Component { mode: 'datetime', }; - // $FlowFixMe How to type a native component to be able to call setNativeProps _picker: ?React.ElementRef = null; componentDidUpdate() { diff --git a/Libraries/Components/ScrollView/ScrollView.js b/Libraries/Components/ScrollView/ScrollView.js index 9a8be2df5e..bf189f0a42 100644 --- a/Libraries/Components/ScrollView/ScrollView.js +++ b/Libraries/Components/ScrollView/ScrollView.js @@ -761,7 +761,6 @@ class ScrollView extends React.Component { } _getKeyForIndex(index, childArray) { - // $FlowFixMe Invalid prop usage const child = childArray[index]; return child && child.key; } diff --git a/RNTester/js/ListViewPagingExample.js b/RNTester/js/ListViewPagingExample.js index 4aade764f4..aa41c9d4e5 100644 --- a/RNTester/js/ListViewPagingExample.js +++ b/RNTester/js/ListViewPagingExample.js @@ -88,7 +88,6 @@ class Thumb extends React.Component<{}, $FlowFixMeState> { } class ListViewPagingExample extends React.Component<$FlowFixMeProps, *> { - // $FlowFixMe found when converting React.createClass to ES6 constructor(props) { super(props); const getSectionData = (dataBlob, sectionID) => { diff --git a/RNTester/js/RNTesterExampleList.js b/RNTester/js/RNTesterExampleList.js index 98ebda4a4f..a52875a90e 100644 --- a/RNTester/js/RNTesterExampleList.js +++ b/RNTester/js/RNTesterExampleList.js @@ -20,8 +20,6 @@ const RNTesterActions = require('./RNTesterActions'); const RNTesterExampleFilter = require('./RNTesterExampleFilter'); const View = require('View'); -/* $FlowFixMe(>=0.78.0 site=react_native_android_fb) This issue was found when - * making Flow check .android.js files. */ import type {RNTesterExample} from 'RNTesterTypes'; import type {ViewStyleProp} from 'StyleSheet'; @@ -71,9 +69,6 @@ const renderSectionHeader = ({section}) => ( class RNTesterExampleList extends React.Component { render() { const filter = ({example, filterRegex}) => - /* $FlowFixMe(>=0.68.0 site=react_native_fb) This comment suppresses an - * error found when Flow v0.68 was deployed. To see the error delete this - * comment and run Flow. */ filterRegex.test(example.module.title) && (!Platform.isTV || example.supportsTVOS);