From 254404b98c8a65bb2f8a0d88b86e087f8f213af1 Mon Sep 17 00:00:00 2001 From: Marc Horowitz Date: Tue, 21 Jun 2016 22:06:09 -0700 Subject: [PATCH] if !WITH_JSCEXTENSIONS, append a \0 Reviewed By: astreet Differential Revision: D3459183 fbshipit-source-id: f62110e67faed827d888afc9a39d1586cdeeb074 --- ReactCommon/cxxreact/Value.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/ReactCommon/cxxreact/Value.h b/ReactCommon/cxxreact/Value.h index cfa74f4ac7..42a736064e 100644 --- a/ReactCommon/cxxreact/Value.h +++ b/ReactCommon/cxxreact/Value.h @@ -98,15 +98,18 @@ public: static String createExpectingAscii(const char* utf8, size_t len) { #if WITH_FBJSCEXTENSIONS - return String( - JSStringCreateWithUTF8CStringExpectAscii(utf8, len), true); + return String(JSStringCreateWithUTF8CStringExpectAscii(utf8, len), true); #else - return String(JSStringCreateWithUTF8CString(utf8), true); + return createExpectingAscii(std::string(utf8, len)); #endif } static String createExpectingAscii(std::string const &utf8) { - return String::createExpectingAscii(utf8.c_str(), utf8.size()); +#if WITH_FBJSCEXTENSIONS + return createExpectingAscii(utf8.c_str(), utf8.size()); +#else + return String(JSStringCreateWithUTF8CString(utf8.c_str()), true); +#endif } static String ref(JSStringRef string) {