Annotate arguments in AnimationKeyFrame ctor
Summary: changelog: [internal] Just improvement to readability. Reviewed By: philIip Differential Revision: D30767100 fbshipit-source-id: eb5d36712f8096e6becd8db1e9d47128d5754624
This commit is contained in:
Родитель
10ab64888f
Коммит
273f631535
|
@ -371,12 +371,12 @@ LayoutAnimationKeyFrameManager::pullTransaction(
|
||||||
|
|
||||||
if (wasInsertedTagRemoved && haveConfiguration) {
|
if (wasInsertedTagRemoved && haveConfiguration) {
|
||||||
movesToAnimate.push_back(AnimationKeyFrame{
|
movesToAnimate.push_back(AnimationKeyFrame{
|
||||||
{},
|
/* .finalMutationsForKeyFrame = */ {},
|
||||||
AnimationConfigurationType::Update,
|
/* .type = */ AnimationConfigurationType::Update,
|
||||||
mutation.newChildShadowView.tag,
|
/* .tag = */ mutation.newChildShadowView.tag,
|
||||||
mutation.parentShadowView,
|
/* .parentView = */ mutation.parentShadowView,
|
||||||
movedIt->second.oldChildShadowView,
|
/* .viewStart = */ movedIt->second.oldChildShadowView,
|
||||||
mutation.newChildShadowView});
|
/* .viewEnd = */ mutation.newChildShadowView});
|
||||||
}
|
}
|
||||||
|
|
||||||
// Creates and inserts should also be executed immediately.
|
// Creates and inserts should also be executed immediately.
|
||||||
|
@ -524,14 +524,14 @@ LayoutAnimationKeyFrameManager::pullTransaction(
|
||||||
mutation);
|
mutation);
|
||||||
|
|
||||||
keyFrame = AnimationKeyFrame{
|
keyFrame = AnimationKeyFrame{
|
||||||
{},
|
/* .finalMutationsForKeyFrame = */ {},
|
||||||
AnimationConfigurationType::Create,
|
/* .type = */ AnimationConfigurationType::Create,
|
||||||
tag,
|
/* .tag = */ tag,
|
||||||
parent,
|
/* .parentView = */ parent,
|
||||||
viewStart,
|
/* .viewStart = */ viewStart,
|
||||||
viewFinal,
|
/* .viewEnd = */ viewFinal,
|
||||||
baselineShadowView,
|
/* .viewPrev = */ baselineShadowView,
|
||||||
0};
|
/* .initialProgress = */ 0};
|
||||||
} else if (mutation.type == ShadowViewMutation::Type::Delete) {
|
} else if (mutation.type == ShadowViewMutation::Type::Delete) {
|
||||||
// This is just for assertion purposes.
|
// This is just for assertion purposes.
|
||||||
// The NDEBUG check here is to satisfy the compiler in certain environments
|
// The NDEBUG check here is to satisfy the compiler in certain environments
|
||||||
|
@ -562,14 +562,14 @@ LayoutAnimationKeyFrameManager::pullTransaction(
|
||||||
mutation);
|
mutation);
|
||||||
|
|
||||||
keyFrame = AnimationKeyFrame{
|
keyFrame = AnimationKeyFrame{
|
||||||
{mutation},
|
/* .finalMutationsForKeyFrame = */ {mutation},
|
||||||
AnimationConfigurationType::Update,
|
/* .type = */ AnimationConfigurationType::Update,
|
||||||
tag,
|
/* .tag = */ tag,
|
||||||
parent,
|
/* .parentView = */ parent,
|
||||||
viewStart,
|
/* .viewStart = */ viewStart,
|
||||||
viewFinal,
|
/* .viewEnd = */ viewFinal,
|
||||||
baselineShadowView,
|
/* .viewPrev = */ baselineShadowView,
|
||||||
0};
|
/* .initialProgress = */ 0};
|
||||||
} else {
|
} else {
|
||||||
// This should just be "Remove" instructions that are not animated
|
// This should just be "Remove" instructions that are not animated
|
||||||
// (either this is a "move", or there's a corresponding "Delete"
|
// (either this is a "move", or there's a corresponding "Delete"
|
||||||
|
@ -650,14 +650,14 @@ LayoutAnimationKeyFrameManager::pullTransaction(
|
||||||
mutation);
|
mutation);
|
||||||
|
|
||||||
keyFrame = AnimationKeyFrame{
|
keyFrame = AnimationKeyFrame{
|
||||||
{mutation, deleteMutation},
|
/* .finalMutationsForKeyFrame */ {mutation, deleteMutation},
|
||||||
AnimationConfigurationType::Delete,
|
/* .type */ AnimationConfigurationType::Delete,
|
||||||
tag,
|
/* .tag */ tag,
|
||||||
parent,
|
/* .parentView */ parent,
|
||||||
viewStart,
|
/* .viewStart */ viewStart,
|
||||||
viewFinal,
|
/* .viewEnd */ viewFinal,
|
||||||
baselineShadowView,
|
/* .viewPrev */ baselineShadowView,
|
||||||
0};
|
/* .initialProgress */ 0};
|
||||||
} else {
|
} else {
|
||||||
PrintMutationInstruction(
|
PrintMutationInstruction(
|
||||||
"Executing Remove Immediately, due to reordering operation",
|
"Executing Remove Immediately, due to reordering operation",
|
||||||
|
|
Загрузка…
Ссылка в новой задаче