From 2b27323308f7f1865139a226a5b78f23bd8f9b04 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Fri, 30 Apr 2021 10:45:02 -0700 Subject: [PATCH] Remove unnecessary access to UIKit on main thread in [RCTRedBox dealloc] Summary: Changelog: Fix main thread access to UIKit in RCTRedBox {F611784226} Xcode's main thread checker complains about this during reload. it is not needed to set `dataSource` and `delegate` to nil because the table view is about to be destroyed. Reviewed By: mdvacca Differential Revision: D28089039 fbshipit-source-id: 13b62cafb4790fc15b5a5dde131d4ae64bd97c82 --- React/CoreModules/RCTRedBox.mm | 6 ------ 1 file changed, 6 deletions(-) diff --git a/React/CoreModules/RCTRedBox.mm b/React/CoreModules/RCTRedBox.mm index ce47519514..921e52baea 100644 --- a/React/CoreModules/RCTRedBox.mm +++ b/React/CoreModules/RCTRedBox.mm @@ -210,12 +210,6 @@ RCT_NOT_IMPLEMENTED(-(instancetype)initWithCoder : (NSCoder *)aDecoder) -- (void)dealloc -{ - _stackTraceTableView.dataSource = nil; - _stackTraceTableView.delegate = nil; -} - - (NSString *)stripAnsi:(NSString *)text { NSError *error = nil;