From 2ca507bf9e00ce62643fb72b0c41fd5868984cb3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Gregorczyk?= Date: Mon, 21 Nov 2016 16:40:22 -0800 Subject: [PATCH] Remove supported platforms from JSC and all the things that depends on it Reviewed By: bnham Differential Revision: D4213580 fbshipit-source-id: 3830c15b0097030a4e4611aac814b12e1d6ae696 --- ReactAndroid/src/main/jni/react/jni/BUCK | 4 ---- ReactAndroid/src/main/jni/xreact/jni/BUCK | 4 ---- ReactCommon/cxxreact/BUCK | 2 -- ReactCommon/inspector/BUCK | 2 -- ReactCommon/jschelpers/BUCK | 2 -- 5 files changed, 14 deletions(-) diff --git a/ReactAndroid/src/main/jni/react/jni/BUCK b/ReactAndroid/src/main/jni/react/jni/BUCK index 19068c1e2f..cde9f884dd 100644 --- a/ReactAndroid/src/main/jni/react/jni/BUCK +++ b/ReactAndroid/src/main/jni/react/jni/BUCK @@ -1,14 +1,10 @@ include_defs('//ReactAndroid/DEFS') -# We depend on JSC, support the same platforms -SUPPORTED_PLATFORMS = '^android-(armv7|x86)$' - # TODO(cjhopman): Remove this target (or move the xreact target to this directory). cxx_library( name='jni', soname = 'libreactnativejni.$(ext)', header_namespace = 'react/jni', - supported_platforms_regex = SUPPORTED_PLATFORMS, srcs = [ 'Dummy.cpp', ], diff --git a/ReactAndroid/src/main/jni/xreact/jni/BUCK b/ReactAndroid/src/main/jni/xreact/jni/BUCK index 020aa13c47..640c87d203 100644 --- a/ReactAndroid/src/main/jni/xreact/jni/BUCK +++ b/ReactAndroid/src/main/jni/xreact/jni/BUCK @@ -1,8 +1,5 @@ include_defs('//ReactAndroid/DEFS') -# We depend on JSC, support the same platforms -SUPPORTED_PLATFORMS = '^android-(armv7|x86)$' - EXPORTED_HEADERS = [ 'CxxModuleWrapper.h', 'JSLoader.h', @@ -19,7 +16,6 @@ cxx_library( name='jni', soname = 'libreactnativejnifb.$(ext)', header_namespace = 'xreact/jni', - supported_platforms_regex = SUPPORTED_PLATFORMS, deps = JSC_DEPS + [ '//native/fb:fb', '//native/third-party/android-ndk:android', diff --git a/ReactCommon/cxxreact/BUCK b/ReactCommon/cxxreact/BUCK index f2df126171..6849c64136 100644 --- a/ReactCommon/cxxreact/BUCK +++ b/ReactCommon/cxxreact/BUCK @@ -21,8 +21,6 @@ if THIS_IS_FBANDROID: def react_library(**kwargs): kwargs = kwargs_add( kwargs, - # We depend on JSC, support the same platforms - supported_platforms_regex = '^android-(armv7|x86)$', compiler_flags = [ '-Wno-pessimizing-move', ], diff --git a/ReactCommon/inspector/BUCK b/ReactCommon/inspector/BUCK index e5844b775d..85a9e57793 100644 --- a/ReactCommon/inspector/BUCK +++ b/ReactCommon/inspector/BUCK @@ -7,8 +7,6 @@ def library(**kwargs): include_defs('//ReactAndroid/DEFS') cxx_library( force_static = True, - # We depend on JSC, support the same platforms - supported_platforms_regex = '^android-(armv7|x86)$', deps = JSC_DEPS + [ '//xplat/folly:molly', react_native_xplat_target('jschelpers:jschelpers'), diff --git a/ReactCommon/jschelpers/BUCK b/ReactCommon/jschelpers/BUCK index 14034778ae..fb96390ce5 100644 --- a/ReactCommon/jschelpers/BUCK +++ b/ReactCommon/jschelpers/BUCK @@ -11,8 +11,6 @@ if THIS_IS_FBANDROID: cxx_library( name = 'jschelpers', force_static = True, - # We depend on JSC, support the same platforms - supported_platforms_regex = '^android-(armv7|x86)$', compiler_flags = [ '-Wall', '-fexceptions',