Rename the folly `headers_only` target to warn
Summary: This target is not a good idea for a number of reasons: 1. It groups up multiple targets which breaks the dependency graph 2. It does not handle dependency remapping correctly 3. It has no mirror into fbcode We should warn people this is a bad idea Reviewed By: alexmalyshev Differential Revision: D36519357 fbshipit-source-id: d60ca3237c7710118732578fecd1b2fc8903321b
This commit is contained in:
Родитель
a3e25b23c6
Коммит
2d66bd4851
2
BUCK
2
BUCK
|
@ -165,7 +165,7 @@ rn_xplat_cxx_library2(
|
|||
":RCTCxxUtils",
|
||||
":ReactInternal",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
react_native_xplat_target("cxxreact:module"),
|
||||
react_native_xplat_target("cxxreact:bridge"),
|
||||
react_native_xplat_target("reactperflogger:reactperflogger"),
|
||||
|
|
|
@ -47,7 +47,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
],
|
||||
|
|
|
@ -140,7 +140,7 @@ rn_xplat_cxx_library(
|
|||
":jsbigstring",
|
||||
":module",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:jsi",
|
||||
|
|
|
@ -15,7 +15,7 @@ rn_xplat_cxx_library(
|
|||
tests = [":tests"],
|
||||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
],
|
||||
exported_deps = [
|
||||
react_native_xplat_target("butter:butter"),
|
||||
|
|
|
@ -38,7 +38,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
],
|
||||
|
|
|
@ -56,7 +56,7 @@ rn_xplat_cxx_library(
|
|||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
],
|
||||
|
|
|
@ -70,7 +70,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -52,7 +52,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -52,7 +52,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
react_native_xplat_target("react/debug:debug"),
|
||||
|
|
|
@ -47,7 +47,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -46,7 +46,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -47,7 +47,7 @@ rn_xplat_cxx_library(
|
|||
tests = [":tests"],
|
||||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
react_native_xplat_target("react/debug:debug"),
|
||||
|
|
|
@ -41,7 +41,7 @@ rn_xplat_cxx_library(
|
|||
],
|
||||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
react_native_xplat_target("react/renderer/core:core"),
|
||||
react_native_xplat_target("react/renderer/components/view:view"),
|
||||
|
|
|
@ -71,7 +71,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -78,7 +78,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -46,7 +46,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -53,7 +53,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -78,7 +78,7 @@ rn_xplat_cxx_library(
|
|||
],
|
||||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
react_native_xplat_target("react/debug:debug"),
|
||||
|
|
|
@ -54,7 +54,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -57,7 +57,7 @@ rn_xplat_cxx_library(
|
|||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:container_evicting_cache_map",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -54,7 +54,7 @@ rn_xplat_cxx_library(
|
|||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:container_evicting_cache_map",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -51,7 +51,7 @@ rn_xplat_cxx_library(
|
|||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:container_evicting_cache_map",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -46,7 +46,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -53,7 +53,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -50,7 +50,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -50,7 +50,7 @@ rn_xplat_cxx_library(
|
|||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
react_native_xplat_target("butter:butter"),
|
||||
|
|
|
@ -108,7 +108,7 @@ rn_xplat_cxx_library(
|
|||
react_native_xplat_target("butter:butter"),
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
],
|
||||
|
|
|
@ -99,7 +99,7 @@ rn_xplat_cxx_library(
|
|||
tests = [":tests"],
|
||||
visibility = ["PUBLIC"],
|
||||
deps = [
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
react_native_xplat_target("react/debug:debug"),
|
||||
|
|
|
@ -47,7 +47,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
react_native_xplat_target("react/debug:debug"),
|
||||
],
|
||||
|
|
|
@ -50,7 +50,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
react_native_xplat_target("butter:butter"),
|
||||
|
|
|
@ -47,7 +47,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -50,7 +50,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
react_native_xplat_target("butter:butter"),
|
||||
|
|
|
@ -49,7 +49,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -117,7 +117,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
|
@ -46,7 +46,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
react_native_xplat_target("react/utils:utils"),
|
||||
|
|
|
@ -49,7 +49,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:JSIDynamic",
|
||||
|
|
|
@ -57,7 +57,7 @@ rn_xplat_cxx_library(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/folly:container_evicting_cache_map",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
"//xplat/jsi:jsi",
|
||||
|
|
|
@ -427,7 +427,7 @@ def rn_codegen_components(
|
|||
deps = [
|
||||
"//third-party/glog:glog",
|
||||
"//xplat/fbsystrace:fbsystrace",
|
||||
"//xplat/folly:headers_only",
|
||||
"//xplat/folly:headers_only_do_not_use",
|
||||
"//xplat/folly:memory",
|
||||
"//xplat/folly:molly",
|
||||
YOGA_CXX_TARGET,
|
||||
|
|
Загрузка…
Ссылка в новой задаче