From 3525998884d564202c07c28a7b3efeab8a52eae4 Mon Sep 17 00:00:00 2001 From: Kathy Gray Date: Tue, 4 Jul 2017 03:54:57 -0700 Subject: [PATCH] Setup experiment for split packages Reviewed By: javache Differential Revision: D5314224 fbshipit-source-id: b9bc28b8f4e058db1dcc0c17f7dc84bf15eb33f9 --- .../java/com/facebook/react/ReactInstanceManager.java | 5 +++-- .../com/facebook/react/ReactInstanceManagerBuilder.java | 9 ++++++++- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index 30083fc71a..8963e64da3 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -223,7 +223,8 @@ public class ReactInstanceManager { @Nullable DevBundleDownloadListener devBundleDownloadListener, boolean setupReactContextInBackgroundEnabled, boolean useSeparateUIBackgroundThread, - int minNumShakes) { + int minNumShakes, + boolean splitPackagesEnabled) { Log.d(ReactConstants.TAG, "ReactInstanceManager.ctor()"); initializeSoLoaderIfNecessary(applicationContext); @@ -256,7 +257,7 @@ public class ReactInstanceManager { mUseSeparateUIBackgroundThread = useSeparateUIBackgroundThread; mMinNumShakes = minNumShakes; - if (true) { // TODO Change to a QE-determined experiment variable in separate commit + if (!splitPackagesEnabled) { CoreModulesPackage coreModulesPackage = new CoreModulesPackage( this, diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java index f0ec73da67..890db96d0e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java @@ -47,6 +47,7 @@ public class ReactInstanceManagerBuilder { protected boolean mSetupReactContextInBackground; protected boolean mUseSeparateUIBackgroundThread; protected int mMinNumShakes = 1; + protected boolean mEnableSplitPackage; /* package protected */ ReactInstanceManagerBuilder() { } @@ -213,6 +214,11 @@ public class ReactInstanceManagerBuilder { return this; } + public ReactInstanceManagerBuilder setEnableSplitPackage(boolean enableSplitPackage) { + mEnableSplitPackage = enableSplitPackage; + return this; + } + /** * Instantiates a new {@link ReactInstanceManager}. * Before calling {@code build}, the following must be called: @@ -262,6 +268,7 @@ public class ReactInstanceManagerBuilder { mDevBundleDownloadListener, mSetupReactContextInBackground, mUseSeparateUIBackgroundThread, - mMinNumShakes); + mMinNumShakes, + mEnableSplitPackage); } }