Delete unnecessary DevSupportManager constructor
Summary: ## Rationale This DevSupportManagerBase constructor isn't used anywhere, aside from VeniceDevSupportManager. Even in VeniceDevSupportManager, we should use the more specific constructor, because it informs readers of the class what specifically is being nullified in the base class. So, this diff gets rid of the smaller arity constructor. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D29004542 fbshipit-source-id: 74e20db93cf1871a364bf228dc089cd7d124297f
This commit is contained in:
Родитель
7c6eb1fecb
Коммит
39d9122445
|
@ -57,25 +57,6 @@ import java.util.concurrent.TimeoutException;
|
|||
* {@code <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>}
|
||||
*/
|
||||
public final class BridgeDevSupportManager extends DevSupportManagerBase {
|
||||
|
||||
public BridgeDevSupportManager(
|
||||
Context applicationContext,
|
||||
ReactInstanceDevHelper reactInstanceDevHelper,
|
||||
@Nullable String packagerPathForJSBundleName,
|
||||
boolean enableOnCreate,
|
||||
int minNumShakes) {
|
||||
|
||||
super(
|
||||
applicationContext,
|
||||
reactInstanceDevHelper,
|
||||
packagerPathForJSBundleName,
|
||||
enableOnCreate,
|
||||
null,
|
||||
null,
|
||||
minNumShakes,
|
||||
null);
|
||||
}
|
||||
|
||||
public BridgeDevSupportManager(
|
||||
Context applicationContext,
|
||||
ReactInstanceDevHelper reactInstanceManagerHelper,
|
||||
|
|
|
@ -123,24 +123,6 @@ public abstract class DevSupportManagerBase
|
|||
|
||||
private @Nullable Activity currentActivity;
|
||||
|
||||
public DevSupportManagerBase(
|
||||
Context applicationContext,
|
||||
ReactInstanceDevHelper reactInstanceDevHelper,
|
||||
@Nullable String packagerPathForJSBundleName,
|
||||
boolean enableOnCreate,
|
||||
int minNumShakes) {
|
||||
|
||||
this(
|
||||
applicationContext,
|
||||
reactInstanceDevHelper,
|
||||
packagerPathForJSBundleName,
|
||||
enableOnCreate,
|
||||
null,
|
||||
null,
|
||||
minNumShakes,
|
||||
null);
|
||||
}
|
||||
|
||||
public DevSupportManagerBase(
|
||||
Context applicationContext,
|
||||
ReactInstanceDevHelper reactInstanceDevHelper,
|
||||
|
|
Загрузка…
Ссылка в новой задаче